public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Harshal Dev <harshal.dev@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: dma: qcom: bam-dma: Add support for kaanapali BAM v2.0.0
Date: Mon, 27 Apr 2026 14:04:48 +0530	[thread overview]
Message-ID: <e00eb12b-e8ad-4db3-b4f3-c8a81f6a081b@oss.qualcomm.com> (raw)
In-Reply-To: <20260425-handsome-papaya-porcupine-d42df7@quoll>

On 25-04-2026 15:53, Krzysztof Kozlowski wrote:
> On Fri, Apr 24, 2026 at 05:04:15PM +0530, Kuldeep Singh wrote:
>> Kaanapali support newer BAM v2.0.0 version.
>> Document the compatible string and update example along with it.
> 
> And why v2.0.0 is not compatible with v1.7.0? Or what is not compatible?

Kindly check patch 2/3 of series to understand register level 
differences in v1.7.0 to v2.0.0.

> 
>>
>> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
>> ---
>>   .../devicetree/bindings/dma/qcom,bam-dma.yaml       | 21 +++++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>> index 6493a6968bb4..0923fb189ada 100644
>> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>> @@ -23,6 +23,8 @@ properties:
>>             - qcom,bam-v1.4.0
>>             # MSM8916, SDM630
>>             - qcom,bam-v1.7.0
>> +          # Kaanapali
>> +          - qcom,bam-v2.0.0
>>         - items:
>>             - enum:
>>                 # SDM845, SM6115, SM8150, SM8250 and QCM2290
>> @@ -118,4 +120,23 @@ examples:
>>           #dma-cells = <1>;
>>           qcom,ee = <0>;
>>       };
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
> 
> Drop the example, no need for difference in compatible.
The current example captures an old instance and doesn't give complete 
picture.
Example, doesn't specify iommus, qcom,controlled-remotely etc. whereas 
recent ones don't specify clocks and reg address/size cells are 2 not 1.

I believe current example doesn't give enough info and hence want to 
extend and highlight latest usage for either v1.7.4 or v2.0.0

Do you want me to have separate patch for this change if looks ok?

-- 
Regards
Kuldeep


  parent reply	other threads:[~2026-04-27  8:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 11:34 [PATCH 0/3] Add support for qcrypto in kaanapali Kuldeep Singh
2026-04-24 11:34 ` [PATCH 1/3] dt-bindings: dma: qcom: bam-dma: Add support for kaanapali BAM v2.0.0 Kuldeep Singh
2026-04-25 10:23   ` Krzysztof Kozlowski
2026-04-25 10:24     ` Krzysztof Kozlowski
2026-04-27  8:48       ` Kuldeep Singh
2026-04-27  8:34     ` Kuldeep Singh [this message]
2026-04-27 11:50       ` Krzysztof Kozlowski
2026-04-28  5:56         ` Kuldeep Singh
2026-04-24 11:34 ` [PATCH 2/3] dmaengine: qcom: bam_dma: Add support for " Kuldeep Singh
2026-04-24 11:34 ` [PATCH 3/3] arm64: dts: qcom: kaanapali: Add qcrypto node support Kuldeep Singh
2026-04-24 12:03   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e00eb12b-e8ad-4db3-b4f3-c8a81f6a081b@oss.qualcomm.com \
    --to=kuldeep.singh@oss.qualcomm.com \
    --cc=Frank.Li@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=harshal.dev@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox