From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Caleb Connolly <caleb.connolly@linaro.org>,
Wasim Nazir <quic_wasimn@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board
Date: Thu, 14 Mar 2024 08:01:25 +0100 [thread overview]
Message-ID: <3163c850-a0e0-4170-a5ee-cfc412b875b4@linaro.org> (raw)
In-Reply-To: <fc00af46-1521-4bb8-9b7c-237cbd26a17c@linaro.org>
On 14/03/2024 05:15, Caleb Connolly wrote:
>
>
> On 13/03/2024 07:12, Wasim Nazir wrote:
>> Document board bindings for Rb5gen2.
>> Rb5gen2 is using Rb5 gen2 SOM which is based on QCS8550 SoC.
>> RB5gen2 is development kit used for IOT solutions.
>>
>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 8115088a6076..de6139db8ef6 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1013,6 +1013,13 @@ properties:
>> - const: qcom,qcs8550
>> - const: qcom,sm8550
>>
>> + - items:
>> + - enum:
>> + - qcom,qcs8550-rb5gen2
>> + - const: qcom,qcs8550-rb5gen2-som
> Is this a Thundercomm SoM like the other RBx boards? If so, shouldn't it
> be "thundercomm,c8550-som" (Or "qcom,c8550-som")?
If this is the same product, then yes. It's clearly not Qualcomm:
https://www.thundercomm.com/product/c8550-som/
If not, can you point us to any resources on this?
Eh, let me un-review it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-14 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 7:12 [PATCH v3 0/3] arm64: qcom: add support for QCS8550 RB5gen2 board Wasim Nazir
2024-03-13 7:12 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board Wasim Nazir
2024-03-13 7:19 ` Krzysztof Kozlowski
2024-03-14 7:01 ` Krzysztof Kozlowski
2024-03-14 4:15 ` Caleb Connolly
2024-03-14 7:01 ` Krzysztof Kozlowski [this message]
2024-03-13 7:12 ` [PATCH v3 2/3] arm64: dts: qcom: Add initial support for rb5gen2 SOM Wasim Nazir
2024-03-13 18:32 ` Konrad Dybcio
2024-03-13 7:12 ` [PATCH v3 3/3] arm64: dts: qcom: Add initial support for rb5gen2 board Wasim Nazir
2024-04-23 13:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3163c850-a0e0-4170-a5ee-cfc412b875b4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wasimn@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox