From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Wasim Nazir <quic_wasimn@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: Add initial support for rb5gen2 SOM
Date: Wed, 13 Mar 2024 19:32:20 +0100 [thread overview]
Message-ID: <eda651eb-6b8c-4cb0-ac08-c38666599338@linaro.org> (raw)
In-Reply-To: <20240313071238.3290-3-quic_wasimn@quicinc.com>
On 3/13/24 08:12, Wasim Nazir wrote:
> Rb5gen2 SOM is based on QCS8550 SoC, used for Rb5gen2 board.
> This initial version describes regulators & ufs storage.
[...]
> +
> +&ufs_mem_hc {
> + reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
> + vcc-supply = <&vreg_l17b_2p5>;
> + vcc-max-microamp = <1300000>;
> + vccq-supply = <&vreg_l1g_1p2>;
> + vccq-max-microamp = <1200000>;
You want regulator-allow-set-mode and regulator-allowed-modes,
unless for some reason you want them to be in HPM permanently,
in which case you should definitely comment why
Konrad
next prev parent reply other threads:[~2024-03-13 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 7:12 [PATCH v3 0/3] arm64: qcom: add support for QCS8550 RB5gen2 board Wasim Nazir
2024-03-13 7:12 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board Wasim Nazir
2024-03-13 7:19 ` Krzysztof Kozlowski
2024-03-14 7:01 ` Krzysztof Kozlowski
2024-03-14 4:15 ` Caleb Connolly
2024-03-14 7:01 ` Krzysztof Kozlowski
2024-03-13 7:12 ` [PATCH v3 2/3] arm64: dts: qcom: Add initial support for rb5gen2 SOM Wasim Nazir
2024-03-13 18:32 ` Konrad Dybcio [this message]
2024-03-13 7:12 ` [PATCH v3 3/3] arm64: dts: qcom: Add initial support for rb5gen2 board Wasim Nazir
2024-04-23 13:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eda651eb-6b8c-4cb0-ac08-c38666599338@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wasimn@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox