Devicetree
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
@ 2026-09-01  3:53 Fenglin Wu
  2026-09-28  7:19 ` Jingyi Wang
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Fenglin Wu @ 2026-09-01  3:53 UTC (permalink / raw)
  To: linux-arm-msm, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: David Collins, Subbaraman Narayanamurthy, Kamal Wadhwa, kernel,
	linux-kernel, devicetree, Yijie Yang, Krzysztof Kozlowski,
	Fenglin Wu

The PMIC arbiter in the Qualcomm Maili SoC is version v8.5, which
is the same with Hawi and compatible with Glymur. Hence, add a string
for "qcom,maili-spmi-pmic-arb" as a compatible entry for
"qcom,glymur-spmi-pmic-arb".

Reviewed-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
---
Changes in v2:
- Added trailers
- Link to v1: https://patch.msgid.link/20260609-maili-spmi-binding-v1-1-80fc4b6bb80f@oss.qualcomm.com
---
 Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml
index 1593a1183a36..44c864fd5fc7 100644
--- a/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml
+++ b/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml
@@ -27,6 +27,7 @@ properties:
           - enum:
               - qcom,hawi-spmi-pmic-arb
               - qcom,kaanapali-spmi-pmic-arb
+              - qcom,maili-spmi-pmic-arb
           - const: qcom,glymur-spmi-pmic-arb
       - enum:
           - qcom,glymur-spmi-pmic-arb

---
base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a
change-id: 20260609-maili-spmi-binding-dbecf60b498e

Best regards,
--  
Fenglin Wu <fenglin.wu@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
  2026-09-01  3:53 [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC Fenglin Wu
@ 2026-09-28  7:19 ` Jingyi Wang
  2026-09-28  8:23   ` Krzysztof Kozlowski
  2026-09-28 11:36 ` Abel Vesa
  2026-09-29 20:34 ` Bjorn Andersson
  2 siblings, 1 reply; 7+ messages in thread
From: Jingyi Wang @ 2026-09-28  7:19 UTC (permalink / raw)
  To: Fenglin Wu, linux-arm-msm, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: David Collins, Subbaraman Narayanamurthy, Kamal Wadhwa, kernel,
	linux-kernel, devicetree, Yijie Yang, Krzysztof Kozlowski

Tested-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

This patch applies cleanly on the lasted linux-next tag.

Thanks,
Jingyi

On 9/1/2026 11:53 AM, Fenglin Wu wrote:
> The PMIC arbiter in the Qualcomm Maili SoC is version v8.5, which
> is the same with Hawi and compatible with Glymur. Hence, add a string
> for "qcom,maili-spmi-pmic-arb" as a compatible entry for
> "qcom,glymur-spmi-pmic-arb".
> 
> Reviewed-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> ---
> Changes in v2:
> - Added trailers
> - Link to v1: https://patch.msgid.link/20260609-maili-spmi-binding-v1-1-80fc4b6bb80f@oss.qualcomm.com
> ---
>   Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml
> index 1593a1183a36..44c864fd5fc7 100644
> --- a/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml
> +++ b/Documentation/devicetree/bindings/spmi/qcom,glymur-spmi-pmic-arb.yaml
> @@ -27,6 +27,7 @@ properties:
>             - enum:
>                 - qcom,hawi-spmi-pmic-arb
>                 - qcom,kaanapali-spmi-pmic-arb
> +              - qcom,maili-spmi-pmic-arb
>             - const: qcom,glymur-spmi-pmic-arb
>         - enum:
>             - qcom,glymur-spmi-pmic-arb
> 
> ---
> base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a
> change-id: 20260609-maili-spmi-binding-dbecf60b498e
> 
> Best regards,
> --
> Fenglin Wu <fenglin.wu@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
  2026-09-28  7:19 ` Jingyi Wang
@ 2026-09-28  8:23   ` Krzysztof Kozlowski
  2026-09-28  9:55     ` Aiqun(Maria) Yu
  0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-28  8:23 UTC (permalink / raw)
  To: Jingyi Wang, Fenglin Wu, linux-arm-msm, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: David Collins, Subbaraman Narayanamurthy, Kamal Wadhwa, kernel,
	linux-kernel, devicetree, Yijie Yang

On 28/09/2026 09:19, Jingyi Wang wrote:
> Tested-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

NAK

You cannot test it. Otherwise explain me how did you execute this code.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
  2026-09-28  8:23   ` Krzysztof Kozlowski
@ 2026-09-28  9:55     ` Aiqun(Maria) Yu
  2026-09-28 10:15       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Aiqun(Maria) Yu @ 2026-09-28  9:55 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Jingyi Wang, Fenglin Wu, linux-arm-msm,
	Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: David Collins, Subbaraman Narayanamurthy, Kamal Wadhwa, kernel,
	linux-kernel, devicetree, Yijie Yang

On 9/28/2026 4:23 PM, Krzysztof Kozlowski wrote:
> On 28/09/2026 09:19, Jingyi Wang wrote:
>> Tested-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> 
> NAK
> 
> You cannot test it. Otherwise explain me how did you execute this code.

Jingyi is posting the Maili device tree from [1] and get dtb checking
using this binding. And with a newer linux-next tag like 0916.

pls have more details of what kind of verification that you needed for
the Tested-by and remove the NAK.
[1]
https://lore.kernel.org/all/20260922-maili-dts-v1-0-ac2b1b76bfd9@oss.qualcomm.com/

> 
> Best regards,
> Krzysztof
> 
> 


-- 
Thx and BRs,
Aiqun(Maria) Yu

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
  2026-09-28  9:55     ` Aiqun(Maria) Yu
@ 2026-09-28 10:15       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-28 10:15 UTC (permalink / raw)
  To: Aiqun(Maria) Yu, Jingyi Wang, Fenglin Wu, linux-arm-msm,
	Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: David Collins, Subbaraman Narayanamurthy, Kamal Wadhwa, kernel,
	linux-kernel, devicetree, Yijie Yang

On 28/09/2026 11:55, Aiqun(Maria) Yu wrote:
> On 9/28/2026 4:23 PM, Krzysztof Kozlowski wrote:
>> On 28/09/2026 09:19, Jingyi Wang wrote:
>>> Tested-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>>
>> NAK
>>
>> You cannot test it. Otherwise explain me how did you execute this code.
> 
> Jingyi is posting the Maili device tree from [1] and get dtb checking
> using this binding. And with a newer linux-next tag like 0916.

Again, let me quote:

"how did you execute this code"

And to clarify - execute on target. Build process is not testing. Where
do you see "Tested---by: Rob's bot" for every patch"

> 
> pls have more details of what kind of verification that you needed for
> the Tested-by and remove the NAK.

You CANNOT test a binding in the meaning of Linux kernel process. It's
impossible and I commented on this already multiple times.

It's a fake test, don't ever send it.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
  2026-09-01  3:53 [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC Fenglin Wu
  2026-09-28  7:19 ` Jingyi Wang
@ 2026-09-28 11:36 ` Abel Vesa
  2026-09-29 20:34 ` Bjorn Andersson
  2 siblings, 0 replies; 7+ messages in thread
From: Abel Vesa @ 2026-09-28 11:36 UTC (permalink / raw)
  To: Fenglin Wu
  Cc: linux-arm-msm, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, David Collins, Subbaraman Narayanamurthy,
	Kamal Wadhwa, kernel, linux-kernel, devicetree, Yijie Yang,
	Krzysztof Kozlowski

On 26-08-31 20:53:44, Fenglin Wu wrote:
> The PMIC arbiter in the Qualcomm Maili SoC is version v8.5, which
> is the same with Hawi and compatible with Glymur. Hence, add a string
> for "qcom,maili-spmi-pmic-arb" as a compatible entry for
> "qcom,glymur-spmi-pmic-arb".
> 
> Reviewed-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
  2026-09-01  3:53 [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC Fenglin Wu
  2026-09-28  7:19 ` Jingyi Wang
  2026-09-28 11:36 ` Abel Vesa
@ 2026-09-29 20:34 ` Bjorn Andersson
  2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2026-09-29 20:34 UTC (permalink / raw)
  To: linux-arm-msm, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Fenglin Wu
  Cc: David Collins, Subbaraman Narayanamurthy, Kamal Wadhwa, kernel,
	linux-kernel, devicetree, Yijie Yang, Krzysztof Kozlowski


On Mon, 31 Aug 2026 20:53:44 -0700, Fenglin Wu wrote:
> The PMIC arbiter in the Qualcomm Maili SoC is version v8.5, which
> is the same with Hawi and compatible with Glymur. Hence, add a string
> for "qcom,maili-spmi-pmic-arb" as a compatible entry for
> "qcom,glymur-spmi-pmic-arb".

Applied, thanks!

[1/1] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC
      commit: 769ff2033eb181cd87564aa41d3a3979e9e55377

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-09-29 20:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-01  3:53 [PATCH v2] dt-bindings: spmi: glymur-spmi-pmic-arb: Add compatible for Qualcomm Maili SoC Fenglin Wu
2026-09-28  7:19 ` Jingyi Wang
2026-09-28  8:23   ` Krzysztof Kozlowski
2026-09-28  9:55     ` Aiqun(Maria) Yu
2026-09-28 10:15       ` Krzysztof Kozlowski
2026-09-28 11:36 ` Abel Vesa
2026-09-29 20:34 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox