public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexander Koskovich <akoskovich@pm.me>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Luca Weiss <luca.weiss@fairphone.com>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v4 6/7] drm/msm/adreno: add Adreno 810 GPU support
Date: Fri, 24 Apr 2026 11:40:48 +0200	[thread overview]
Message-ID: <31c1a601-c249-426b-8f0e-30d729907a89@oss.qualcomm.com> (raw)
In-Reply-To: <oka0Q911ixJLZzAbfWBx54dOmxbQAre36QqHUX4iDZoH3TE5jD-IqTAHspti6B8kfpLQ-OTnuWjFdXtsqJM-CUC8G9R3x_9vFI--LnpppiA=@pm.me>

On 4/23/26 10:34 PM, Alexander Koskovich wrote:
> On Wednesday, April 22nd, 2026 at 9:04 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
> 
>> On 4/16/26 1:05 PM, Alexander Koskovich wrote:
>>> Add catalog entry and register configuration for the Adreno 810
>>> found in Qualcomm SM7635 (Milos) based devices.
>>>
>>> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
>>> ---

[...]

>>> +static const u32 a810_ifpc_reglist_regs[] = {
>>> +	REG_A8XX_RBBM_NC_MODE_CNTL,
>>> +	REG_A8XX_RBBM_PERFCTR_CNTL,
>>
>> This list matches the expectations, modulo this RBBM_PERFCTR_CNTL
> 
> Note on this, added this shortly before submitting this series as requested by Akhil:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40613#note_3395308

Yes, I forgot about that bit. So it's OK.

[...]

>>> +		.speedbins = ADRENO_SPEEDBINS(
>>> +			{ 0,   0 },
>>> +			{ 242, 1 },
>>> +			{ 221, 2 },
>>> +		),
>>
>> The DTs I have all point to SMEM-based SKU checks. Did you find these
>> numbers empirically?
> 
> Yes, and I used speedbin instead as upstream doesn't support the SKU checks
> downstream does. Utilizing GPU_CC_FREQ_LIMIT_VAL to serve as speedbin
> on this platform.

Hm, I'm not sure whether it's a stable identifier on this platform, or
whether it just worked by change. Akhil?

Konrad

  reply	other threads:[~2026-04-24  9:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 11:04 [PATCH RFC v4 0/7] Add support for Adreno 810 GPU Alexander Koskovich
2026-04-16 11:04 ` [PATCH RFC v4 1/7] dt-bindings: display/msm/gmu: Document Adreno 810 GMU Alexander Koskovich
2026-04-16 11:05 ` [PATCH RFC v4 2/7] dt-bindings: display/msm/gpu: Document A810 GPU Alexander Koskovich
2026-04-16 11:05 ` [PATCH RFC v4 3/7] drm/msm/adreno: rename llc_mmio to cx_misc_mmio Alexander Koskovich
2026-04-16 11:05 ` [PATCH RFC v4 4/7] drm/msm/adreno: set cx_misc_mmio regardless of if platform has LLCC Alexander Koskovich
2026-04-16 11:05 ` [PATCH RFC v4 5/7] drm/msm/a8xx: use pipe protect slot 15 for last-span-unbound feature Alexander Koskovich
2026-04-16 11:05 ` [PATCH RFC v4 6/7] drm/msm/adreno: add Adreno 810 GPU support Alexander Koskovich
2026-04-22 13:04   ` Konrad Dybcio
2026-04-23 20:27     ` Alexander Koskovich
2026-04-24  9:42       ` Konrad Dybcio
2026-04-22 13:04   ` Konrad Dybcio
2026-04-23 20:34     ` Alexander Koskovich
2026-04-24  9:40       ` Konrad Dybcio [this message]
2026-04-16 11:05 ` [PATCH RFC v4 7/7] arm64: dts: qcom: milos: Add Adreno 810 GPU and GMU nodes Alexander Koskovich
2026-04-18 17:53   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31c1a601-c249-426b-8f0e-30d729907a89@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox