public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: socfpga: Add the Agilex7 series SoC's
Date: Tue, 14 Apr 2026 14:55:38 +0200	[thread overview]
Message-ID: <321be4a9-2633-403b-ac44-4ec9102f7d14@kernel.org> (raw)
In-Reply-To: <a2945037-d8c9-45b5-b161-ac55ac9b0835@kernel.org>

On 14/04/2026 14:53, Dinh Nguyen wrote:
> 
> 
> On 4/14/26 02:17, Krzysztof Kozlowski wrote:
>> On Mon, Apr 13, 2026 at 09:45:52AM -0500, Dinh Nguyen wrote:
>>> The Agilex7 is a series of devices from Altera that are derived from
>>> the Agilex family.
>>>
>>> The Agilex7F device supports PCIE 4.0 and DDR4. The Agilex7I device supports
>>> PCIE 5.0 and DDR4, while the Agilex7M device supports DDR4, DDR5, LPDDR5
>>> and PCIE 5.0.
>>>
>>> All other peripherals from these devices are the same as the Agilex
>>> device.
>>>
>>> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
>>> ---
>>>   Documentation/devicetree/bindings/arm/altera.yaml | 10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
>>> index 206686f3eebc..5ee09f8d4698 100644
>>> --- a/Documentation/devicetree/bindings/arm/altera.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
>>> @@ -115,6 +115,16 @@ properties:
>>>                 - intel,socfpga-agilex5-socdk-nand
>>>             - const: intel,socfpga-agilex5
>>>   
>>> +      - description: Agilex7 series F, I and M boards
>>> +        items:
>>> +          - enum:
>>> +              - intel,socfpga-agilex7m-socdk
>>> +          - enum:
>>> +              - intel,socfpga-agilex7f
>>> +              - intel,socfpga-agilex7i
>>> +              - intel,socfpga-agilex7m
>>> +          - const: intel,socfpga-agilex
>>
>> And separate question - why previous soc "agilex" is used as fallback?
>> Even more confusing.
>>
> 
> You're right. Sorry for the confusion. The Agilex7M, I, F devices are 
> basically "agilex" devices with some few additions (PCIE, DDR5). Maybe I 
> should place the Agilex7M/I/F devices into the "agilex" boards area?

Compatibles should be specific and not based on families, thus what is
"intel,socfpga-agilex"? SoC, right?

Then "intel,socfpga-agilex7f" is a new SoC, no?

Best regards,
Krzysztof

  reply	other threads:[~2026-04-14 12:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 14:45 [PATCH 1/2] dt-bindings: socfpga: Add the Agilex7 series SoC's Dinh Nguyen
2026-04-13 14:45 ` [PATCH 2/2] arm64: dts: Add SoCFPGA Agilex7M devkit Dinh Nguyen
2026-04-14  7:16 ` [PATCH 1/2] dt-bindings: socfpga: Add the Agilex7 series SoC's Krzysztof Kozlowski
2026-04-14  7:17 ` Krzysztof Kozlowski
2026-04-14 12:53   ` Dinh Nguyen
2026-04-14 12:55     ` Krzysztof Kozlowski [this message]
2026-04-16 15:20       ` Dinh Nguyen
2026-04-17  6:43         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=321be4a9-2633-403b-ac44-4ec9102f7d14@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox