Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur
@ 2026-11-18  7:00 Wenjia Zhang
  2026-11-18  7:00 ` [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add Glymur support Wenjia Zhang
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Wenjia Zhang @ 2026-11-18  7:00 UTC (permalink / raw)
  To: Abel Vesa, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, Wenjia Zhang

This series enables the Inline Crypto Engine (ICE) for UFS storage
on the Qualcomm Glymur platform, including the Glymur QCB board.

The hardware reports ICE v4.0.3 with Hardware Key Manager (HWKM) v2.

Patch 1 documents the Glymur ICE compatible string. 
Patch 2 adds the ICE node with its registers, clocks and power domain,
and connects the UFS host controller to ICE through the qcom,ice phandle.

Dependencies:
Patch 2 requires the UFS nodes added by patch 1/3 ("arm64: dts: qcom: glymur: Add UFS nodes")
from the Glymur UFS support series [1]. Its patch ID is recorded as a prerequisite below.
Board-level UFS operation also requires the QCB enablement and PHY support from that series.

Validation:
- Observed ICE v4.0.3 and HWKM v2 during probe.
- Standard-key and wrapped-key tests passed
- checkpatch --strict --no-signoff: no errors, warnings or checks.
- Targeted ICE DT binding validation passed.
- Glymur QCB DTB compilation passed.

Prerequisite:
[1] https://lore.kernel.org/all/20261028-glymur_ufs_qcb_enablement-v5-0-09cda5e3bab3@oss.qualcomm.com/

---
Wenjia Zhang (2):
      dt-bindings: crypto: qcom,inline-crypto-engine: Add Glymur support
      arm64: dts: qcom: glymur: Add ICE node for UFS inline encryption

 .../bindings/crypto/qcom,inline-crypto-engine.yaml          |  1 +
 arch/arm64/boot/dts/qcom/glymur.dtsi                        | 13 +++++++++++++
 2 files changed, 14 insertions(+)
---
base-commit: 749a4de370409464cf8501ec5b2451df45c84eb4
change-id: 20261117-glymur_ufs_ice-f469fdfcf38c
prerequisite-patch-id: 7b02d96573a31d29765df0f0377fa934abe79e05

Best regards,
-- 
Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add Glymur support
  2026-11-18  7:00 [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Wenjia Zhang
@ 2026-11-18  7:00 ` Wenjia Zhang
  2026-11-18  7:00 ` [PATCH 2/2] arm64: dts: qcom: glymur: Add ICE node for UFS inline encryption Wenjia Zhang
  2026-11-18  8:20 ` [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Gopikrishna Garmidi
  2 siblings, 0 replies; 4+ messages in thread
From: Wenjia Zhang @ 2026-11-18  7:00 UTC (permalink / raw)
  To: Abel Vesa, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, Wenjia Zhang

Document the compatible string for the Inline Crypto Engine (ICE)
found on the Qualcomm Glymur SoC.

Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
index b98c4c6b77f05a4295b7225007187a7b05387338..01a1a36652d759610e36d5ac3ad56f4b2d45b96b 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
@@ -14,6 +14,7 @@ properties:
     items:
       - enum:
           - qcom,eliza-inline-crypto-engine
+          - qcom,glymur-inline-crypto-engine
           - qcom,hawi-inline-crypto-engine
           - qcom,ipq5210-inline-crypto-engine
           - qcom,ipq5424-inline-crypto-engine

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: glymur: Add ICE node for UFS inline encryption
  2026-11-18  7:00 [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Wenjia Zhang
  2026-11-18  7:00 ` [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add Glymur support Wenjia Zhang
@ 2026-11-18  7:00 ` Wenjia Zhang
  2026-11-18  8:20 ` [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Gopikrishna Garmidi
  2 siblings, 0 replies; 4+ messages in thread
From: Wenjia Zhang @ 2026-11-18  7:00 UTC (permalink / raw)
  To: Abel Vesa, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, Wenjia Zhang

Add the Inline Crypto Engine (ICE) device node to describe the
hardware-accelerated inline encryption for UFS storage on the
Glymur QCB board.

Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index 165dfa11f17f55478cfda09c3db2143a1e5b91b8..ba949704e3b4fe2aa497873be6fa0a5cd2f3a1b4 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -4156,6 +4156,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			phys = <&ufs_mem_phy>;
 			phy-names = "ufsphy";
 
+			qcom,ice = <&ice>;
+
 			#reset-cells = <1>;
 
 			status = "disabled";
@@ -4201,6 +4203,17 @@ opp-403000000 {
 			};
 		};
 
+		ice: crypto@1d88000 {
+			compatible = "qcom,glymur-inline-crypto-engine",
+				     "qcom,inline-crypto-engine";
+			reg = <0x0 0x01d88000 0x0 0x18000>;
+			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>,
+				 <&gcc GCC_UFS_PHY_AHB_CLK>;
+			clock-names = "core",
+				      "iface";
+			power-domains = <&gcc GCC_UFS_PHY_GDSC>;
+		};
+
 		cryptobam: dma-controller@1dc4000 {
 			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
 			reg = <0x0 0x01dc4000 0x0 0x28000>;

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur
  2026-11-18  7:00 [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Wenjia Zhang
  2026-11-18  7:00 ` [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add Glymur support Wenjia Zhang
  2026-11-18  7:00 ` [PATCH 2/2] arm64: dts: qcom: glymur: Add ICE node for UFS inline encryption Wenjia Zhang
@ 2026-11-18  8:20 ` Gopikrishna Garmidi
  2 siblings, 0 replies; 4+ messages in thread
From: Gopikrishna Garmidi @ 2026-11-18  8:20 UTC (permalink / raw)
  To: Wenjia Zhang, Abel Vesa, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree



On 11/18/2026 12:30 PM, Wenjia Zhang wrote:
> This series enables the Inline Crypto Engine (ICE) for UFS storage
> on the Qualcomm Glymur platform, including the Glymur QCB board.
> 
> The hardware reports ICE v4.0.3 with Hardware Key Manager (HWKM) v2.
> 
> Patch 1 documents the Glymur ICE compatible string.
> Patch 2 adds the ICE node with its registers, clocks and power domain,
> and connects the UFS host controller to ICE through the qcom,ice phandle.
> 
> Dependencies:
> Patch 2 requires the UFS nodes added by patch 1/3 ("arm64: dts: qcom: glymur: Add UFS nodes")
> from the Glymur UFS support series [1]. Its patch ID is recorded as a prerequisite below.
> Board-level UFS operation also requires the QCB enablement and PHY support from that series.
> 
> Validation:
> - Observed ICE v4.0.3 and HWKM v2 during probe.
> - Standard-key and wrapped-key tests passed
> - checkpatch --strict --no-signoff: no errors, warnings or checks.
> - Targeted ICE DT binding validation passed.
> - Glymur QCB DTB compilation passed.
> 
> Prerequisite:
> [1] https://lore.kernel.org/all/20261028-glymur_ufs_qcb_enablement-v5-0-09cda5e3bab3@oss.qualcomm.com/
> 
Hi Wenjia,

Please drop the prerequisite and dependencies from the cover letter. The 
UFS series is already in linux-next.

Also, I can't apply this series on top of the latest linux-next. Please 
rebase and resend.

Thanks,
Gopikrishna

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-18  8:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  7:00 [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Wenjia Zhang
2026-11-18  7:00 ` [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add Glymur support Wenjia Zhang
2026-11-18  7:00 ` [PATCH 2/2] arm64: dts: qcom: glymur: Add ICE node for UFS inline encryption Wenjia Zhang
2026-11-18  8:20 ` [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Gopikrishna Garmidi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox