Re: [PATCH 3/6] regulator: qcom-pm8008: Add PM8010 mode support

[Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>]

On 9/18/2026 10:22 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] redundant use of to_i2c_client() when accessing of_node
> --
> 
> commit f34c6623337a92a1f38e24ae60d1ae6ced8eed2d
> Author: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
> 

...

>>  
>> +	is_pm8010 = of_device_is_compatible(to_i2c_client(dev->parent)->dev.of_node,
>> +					    "qcom,pm8010-i2c");
>> +
> 
> [Severity: Low]
> Is there a reason to use to_i2c_client() when accessing of_node in
> pm8008_regulator_probe()?
> 
> Since to_i2c_client() is defined as container_of(d, struct i2c_client, dev),
> accessing the dev member of the resulting structure evaluates back to the
> exact original pointer (dev->parent).
> 
> The expression to_i2c_client(dev->parent)->dev.of_node is functionally
> identical to simply using dev->parent->of_node, making the macro usage
> entirely redundant.

I'll make this fix in the next version of this series.

Thanks,
Jishnu