Re: [PATCH 4/6] mfd: qcom-pm8008: Add PM8010 support

[Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>]

On 9/18/2026 10:21 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] mfd: complex data passed via match table .data field
> --
> 
> commit a6c2d131522cd1b3f195202001e9365b690fa7f6
> Author: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> mfd: qcom-pm8008: Add PM8010 support
> 

...

> [ ... ]
>> +static const struct pm8008_match_data pm8008_data = {
>> +	.irq_chip_desc = &pm8008_irq_chip,
>> +	.mfd_cells = pm8008_cells,
>> +	.num_mfd_cells = ARRAY_SIZE(pm8008_cells),
>> +};
>> +
>> +static const struct pm8008_match_data pm8010_data = {
>> +	.irq_chip_desc = &pm8010_irq_chip,
>> +	.mfd_cells = pm8010_cells,
>> +	.num_mfd_cells = ARRAY_SIZE(pm8010_cells),
>> +};
>> +
>>  static const struct of_device_id pm8008_match[] = {
>> -	{ .compatible = "qcom,pm8008", },
>> +	{ .compatible = "qcom,pm8008", .data = &pm8008_data },
>> +	{ .compatible = "qcom,pm8010-i2c", .data = &pm8010_data },
>>  	{ },
>>  };
> 
> [Severity: Medium]
> Does this match table improperly embed complex pointers?
> 
> The MFD documentation explicitly flags passing complex pointers via the
> .data field of match tables as a pattern to avoid. Using an ID enum
> such as (void *)TYPE_PM8008 instead of passing the &pm8008_data pointer
> would comply with the core subsystem patterns.
> 

I'll make this fix in the next version of this series.

Thanks,
Jishnu