Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sdm845-lg: fix sdcard pinctrl nodes
@ 2026-08-02 19:06 Paul Sajna
  2026-08-03 10:10 ` David Heidelberg
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Sajna @ 2026-08-02 19:06 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Anton Bambura, Stefan Hansson
  Cc: linux-arm-msm, devicetree, linux-kernel, stable,
	~postmarketos/upstreaming, phone-devel, David Heidelberg,
	Paul Sajna

sdcard was previously rather unreliable during boot on sdm845-lg-judyln

Identified and applied correct settings from downstream lineageos kernel.

Verified card was properly detected over 5 reboots with rootfs on sdcard.

Refer to downstream: https://github.com/LineageOS/android_kernel_lge_sdm845/blob/efa8458f79dffeb380d43b38b9403407f87d9f05/arch/arm64/boot/dts/qcom/sdm845-pinctrl.dtsi#L148-L303

Fixes: 28ae8aa3923c ("arm64: dts: qcom: add device tree for LG G7 and LG V35")
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 5ac2e058827c..055d17e966be 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -581,33 +581,26 @@ &tlmm {
 	sdc2_clk: sdc2-clk-state {
 		pins = "sdc2_clk";
 		bias-disable;
-
-		/*
-		 * It seems that mmc_test reports errors if drive
-		 * strength is not 16 on clk, cmd, and data pins.
-		 *
-		 * TODO: copy-pasted from mtp, try other values
-		 * on these devices.
-		 */
 		drive-strength = <16>;
 	};
 
 	sdc2_cmd: sdc2-cmd-state {
 		pins = "sdc2_cmd";
 		bias-pull-up;
-		drive-strength = <16>;
+		drive-strength = <10>;
 	};
 
 	sdc2_data: sdc2-data-state {
 		pins = "sdc2_data";
 		bias-pull-up;
-		drive-strength = <16>;
+		drive-strength = <10>;
 	};
 
 	sd_card_det_n: sd-card-det-n-state {
 		pins = "gpio126";
 		function = "gpio";
 		bias-pull-up;
+		drive-strength = <2>;
 	};
 };
 

---
base-commit: 415606a7be939835db9b0d6b711887586646346d
change-id: 20260802-judyln-sdcard-fix-12c2a04a7ad5

Best regards,
--  
Paul Sajna <sajattack@postmarketos.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sdm845-lg: fix sdcard pinctrl nodes
  2026-08-02 19:06 [PATCH] arm64: dts: qcom: sdm845-lg: fix sdcard pinctrl nodes Paul Sajna
@ 2026-08-03 10:10 ` David Heidelberg
  0 siblings, 0 replies; 2+ messages in thread
From: David Heidelberg @ 2026-08-03 10:10 UTC (permalink / raw)
  To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Anton Bambura, Stefan Hansson
  Cc: linux-arm-msm, devicetree, linux-kernel, stable, phone-devel

On 02/08/2026 21:06, Paul Sajna wrote:
> sdcard was previously rather unreliable during boot on sdm845-lg-judyln
> 
> Identified and applied correct settings from downstream lineageos kernel.
> 
> Verified card was properly detected over 5 reboots with rootfs on sdcard.
> 
> Refer to downstream: https://github.com/LineageOS/android_kernel_lge_sdm845/blob/efa8458f79dffeb380d43b38b9403407f87d9f05/arch/arm64/boot/dts/qcom/sdm845-pinctrl.dtsi#L148-L303
> 
> Fixes: 28ae8aa3923c ("arm64: dts: qcom: add device tree for LG G7 and LG V35")
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++----------
>   1 file changed, 3 insertions(+), 10 deletions(-)
> 
Reviewed-by: David Heidelberg <david@ixit.cz>

Thank you!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-03 10:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-02 19:06 [PATCH] arm64: dts: qcom: sdm845-lg: fix sdcard pinctrl nodes Paul Sajna
2026-08-03 10:10 ` David Heidelberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox