From: Arnd Bergmann <arnd@arndb.de>
To: Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
marc.zyngier@arm.com, benh@kernel.crashing.org, jk@ozlabs.org,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] doc/devicetree: Add Aspeed VIC bindings
Date: Mon, 09 May 2016 14:55:59 +0200 [thread overview]
Message-ID: <4320787.nfPydvIlpT@wuerfel> (raw)
In-Reply-To: <1462797239-14765-2-git-send-email-joel@jms.id.au>
On Monday 09 May 2016 22:03:58 Joel Stanley wrote:
> +
> +- compatible : should be "aspeed,ast2400-vic".
> +
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> + interrupt source. The value shall be 1.
> +- valid-sources : bitmask of valid irq sources
> +
> +Example:
> +
> + vic: interrupt-controller {
> + compatible = "aspeed,ast2400-new-vic";
>
The example doesn't match the binding regarding the compatible string,
otherwise looks ok to me.
Arnd
next prev parent reply other threads:[~2016-05-09 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 12:33 [PATCH 0/2] irqchip: Support Aspeed IRQ controller Joel Stanley
[not found] ` <1462797239-14765-1-git-send-email-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2016-05-09 12:33 ` [PATCH 1/2] doc/devicetree: Add Aspeed VIC bindings Joel Stanley
2016-05-09 12:50 ` Baruch Siach
2016-05-09 12:55 ` Arnd Bergmann [this message]
2016-05-09 15:20 ` Mark Rutland
2016-05-09 22:04 ` Benjamin Herrenschmidt
2016-05-09 12:33 ` [PATCH 2/2] irqchip: Add irq controller for Aspeed Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4320787.nfPydvIlpT@wuerfel \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox