From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>,
Harshal Dev <harshal.dev@oss.qualcomm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] dt-bindings: arm: qcom: Document SA8797P Ride board
Date: Wed, 20 May 2026 11:46:37 +0200 [thread overview]
Message-ID: <439bcc77-c1ed-497a-948d-692b5145149c@kernel.org> (raw)
In-Reply-To: <20260520-acoustic-inchworm-of-education-2fb9ba@quoll>
On 20/05/2026 09:38, Krzysztof Kozlowski wrote:
> On Tue, May 19, 2026 at 02:35:04PM +0800, Shawn Guo wrote:
>> The Nord is a new generation of SoC series from Qualcomm, and SA8797P
>> is the automotive variant of Nord. SA8797P Ride is the automotive‑grade
>> development board built on SA8797P SoC. Document the board with a fallback
>> on SA8797P and Nord compatible.
>>
>> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index af266d584fae..ab25323c3581 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -303,6 +303,12 @@ properties:
>> - xiaomi,sagit
>> - const: qcom,msm8998
>>
>> + - items:
>> + - enum:
>> + - qcom,sa8797p-ride
>> + - const: qcom,sa8797p
>
> We do not use model compatibles for Shikra, Eliza, Hawi, Glymur etc, so
> this is inconsistent and should be somehow explained in the commit msg.
With explanation why dedicated model compatible for Nord makes sense:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-20 9:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 6:34 [PATCH v2 0/8] Add initial device trees for Nord SA8797P Shawn Guo
2026-05-19 6:34 ` [PATCH v2 1/8] dt-bindings: arm: qcom,ids: Add SoC ID " Shawn Guo
2026-05-19 6:34 ` [PATCH v2 2/8] soc: qcom: socinfo: " Shawn Guo
2026-05-19 6:35 ` [PATCH v2 3/8] soc: qcom: socinfo: Add PMIC PMAU0102 Shawn Guo
2026-05-19 6:35 ` [PATCH v2 4/8] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE Shawn Guo
2026-05-19 10:50 ` Harshal Dev
2026-05-19 6:35 ` [PATCH v2 5/8] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-05-19 7:04 ` sashiko-bot
2026-05-19 6:35 ` [PATCH v2 6/8] arm64: dts: qcom: Add device tree for Nord SA8797P SoC Shawn Guo
2026-05-19 7:16 ` sashiko-bot
2026-05-19 6:35 ` [PATCH v2 7/8] dt-bindings: arm: qcom: Document SA8797P Ride board Shawn Guo
2026-05-19 7:28 ` sashiko-bot
2026-05-20 7:38 ` Krzysztof Kozlowski
2026-05-20 9:46 ` Krzysztof Kozlowski [this message]
2026-05-19 6:35 ` [PATCH v2 8/8] arm64: dts: qcom: Add device tree for " Shawn Guo
2026-05-19 7:35 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439bcc77-c1ed-497a-948d-692b5145149c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=deepti.jaggi@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=harshal.dev@oss.qualcomm.com \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox