Re: [PATCH v3 3/4] PCI: of: introduce of_pci_verify_node()

[Alex Elder <elder@riscstar.com>]

On 9/2/26 7:54 AM, Alex Elder wrote:
>>> I would love to get some pointers from others on how to
>>> do this correctly, but in any case I'll do a little more
>>> research on this before I post version 4.
>>
>> I'm willing to wait and see if anyone cares about cardbus. I doubt it.
>> Maybe there's some old PowerBooks with cardbus?
> 
> I'll give it another few days before posting v4.
> 
>> "pciex" should probably be handled.
> 
> I'll add that.  I'll also try to find what the range
> of "compliant" device types is; I presume it's in the
> devicetree spec.

I'm about to send v4 of this series.  Here is some information on
this suggestion:
- "cardbus" is referenced in two places (two very similar functions,
   one for PowerPC and one for SPARC.
     of_create_pci_dev() in "arch/powerpc/kernel/pci_of_scan.c"
     of_create_pci_dev() in "arch/sparc/kernel/pci.c"
   Based on the tone of your earlier comment, I'll ignore "cardbus".
- "pciex" is checked in 6 places, one of which is generic (the other
   five are related to the above two architectures).  The generic
   one is in of_bus_pci_match(), mentioned earlier.

Sashiko's suggestion only mentioned those two device_type values.
I'll just add a test for "pciex" as you suggested.

Herve, I will retain your "reviewed-by" tag; if you disagree with
this minor change say so and I'll remove it in v5.

					-Alex