* [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv
@ 2022-12-09 21:54 Marijn Suijten
2022-12-09 22:27 ` Luca Weiss
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marijn Suijten @ 2022-12-09 21:54 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Marijn Suijten,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno, Luca Weiss,
linux-arm-msm, devicetree, linux-kernel
This was pointed out in review but never followed up on thanks to
sidetracked discussions about labels vs node names.
Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
arch/arm64/boot/dts/qcom/pmi8950.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index 32d27e2187e3..8008f02434a9 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -47,7 +47,7 @@ adc-chan@9 {
adc-chan@a {
reg = <VADC_REF_1250MV>;
qcom,pre-scaling = <1 1>;
- label = "ref_1250v";
+ label = "ref_1250mv";
};
adc-chan@d {
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv
2022-12-09 21:54 [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv Marijn Suijten
@ 2022-12-09 22:27 ` Luca Weiss
2022-12-10 9:33 ` Konrad Dybcio
2022-12-28 4:36 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Luca Weiss @ 2022-12-09 22:27 UTC (permalink / raw)
To: phone-devel, Marijn Suijten
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Marijn Suijten,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno, linux-arm-msm,
devicetree, linux-kernel
On Freitag, 9. Dezember 2022 22:54:37 CET Marijn Suijten wrote:
> This was pointed out in review but never followed up on thanks to
> sidetracked discussions about labels vs node names.
>
> Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950
> peripheral") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> arch/arm64/boot/dts/qcom/pmi8950.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> b/arch/arm64/boot/dts/qcom/pmi8950.dtsi index 32d27e2187e3..8008f02434a9
> 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> @@ -47,7 +47,7 @@ adc-chan@9 {
> adc-chan@a {
> reg = <VADC_REF_1250MV>;
> qcom,pre-scaling = <1 1>;
> - label = "ref_1250v";
> + label = "ref_1250mv";
Indeed 1250V are maybe a bit much ;) Thanks!
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
> };
>
> adc-chan@d {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv
2022-12-09 21:54 [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv Marijn Suijten
2022-12-09 22:27 ` Luca Weiss
@ 2022-12-10 9:33 ` Konrad Dybcio
2022-12-28 4:36 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-12-10 9:33 UTC (permalink / raw)
To: Marijn Suijten, phone-devel
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno, Luca Weiss, linux-arm-msm, devicetree,
linux-kernel
On 9.12.2022 22:54, Marijn Suijten wrote:
> This was pointed out in review but never followed up on thanks to
> sidetracked discussions about labels vs node names.
>
> Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/pmi8950.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> index 32d27e2187e3..8008f02434a9 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> @@ -47,7 +47,7 @@ adc-chan@9 {
> adc-chan@a {
> reg = <VADC_REF_1250MV>;
> qcom,pre-scaling = <1 1>;
> - label = "ref_1250v";
> + label = "ref_1250mv";
> };
>
> adc-chan@d {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv
2022-12-09 21:54 [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv Marijn Suijten
2022-12-09 22:27 ` Luca Weiss
2022-12-10 9:33 ` Konrad Dybcio
@ 2022-12-28 4:36 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-12-28 4:36 UTC (permalink / raw)
To: Marijn Suijten, phone-devel
Cc: konrad.dybcio, ~postmarketos/upstreaming, luca, Martin Botka,
krzysztof.kozlowski+dt, konrad.dybcio, linux-kernel,
jami.kettunen, AngeloGioacchino Del Regno, robh+dt, devicetree,
agross, linux-arm-msm, kholk11
On Fri, 9 Dec 2022 22:54:37 +0100, Marijn Suijten wrote:
> This was pointed out in review but never followed up on thanks to
> sidetracked discussions about labels vs node names.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv
commit: 3c3d2cb221b8647d1c547b4c44d2d6060cc742a9
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-28 4:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-09 21:54 [PATCH] arm64: dts: qcom: pmi8950: Correct rev_1250v channel label to mv Marijn Suijten
2022-12-09 22:27 ` Luca Weiss
2022-12-10 9:33 ` Konrad Dybcio
2022-12-28 4:36 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox