Re: [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/01/2025 06:45, Wenhua Lin wrote:
> Due to the platform's new project uart ip upgrade,
> the new project's timeout interrupt needs to use bit17
> while other projects' timeout interrupt needs to use
> bit13, using private data to adapt and be compatible

Where is private data in this patch?

> with all projects. The sc9632-uart is incompatible
> with sc9836-uart, Add sc9632-uart dedicated compatible
> for representing uart of the new project UMS9632 SoC.

First part of commit said these are not compatible. Here you claim they
are compatible, so this is just confusing.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> index a2a5056eba04..35fe9c301cd2 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> @@ -17,13 +17,17 @@ properties:
>      oneOf:
>        - items:
>            - enum:
> -              - sprd,sc9632-uart

No, not explained, not justified.

>                - sprd,sc9860-uart
>                - sprd,sc9863a-uart
>                - sprd,ums512-uart
>                - sprd,ums9620-uart
>            - const: sprd,sc9836-uart
>        - const: sprd,sc9836-uart
> +      - items:
> +          - enum:
> +              - sprd,sc9632-uart
> +          - const: sprd,sc9632-uart

This means nothing. Device cannot be compatible with itself.


Best regards,
Krzysztof