* [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 @ 2025-01-14 5:45 Wenhua Lin 2025-01-14 7:38 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Wenhua Lin @ 2025-01-14 5:45 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, Cixi Geng, linux-kernel, linux-serial, devicetree, wenhua lin, Wenhua Lin, Xiongpeng Wu, Zhaochen Su, Zhirong Qiu Due to the platform's new project uart ip upgrade, the new project's timeout interrupt needs to use bit17 while other projects' timeout interrupt needs to use bit13, using private data to adapt and be compatible with all projects. The sc9632-uart is incompatible with sc9836-uart, Add sc9632-uart dedicated compatible for representing uart of the new project UMS9632 SoC. Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com> --- Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml index a2a5056eba04..35fe9c301cd2 100644 --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml @@ -17,13 +17,17 @@ properties: oneOf: - items: - enum: - - sprd,sc9632-uart - sprd,sc9860-uart - sprd,sc9863a-uart - sprd,ums512-uart - sprd,ums9620-uart - const: sprd,sc9836-uart - const: sprd,sc9836-uart + - items: + - enum: + - sprd,sc9632-uart + - const: sprd,sc9632-uart + - const: sprd,sc9632-uart reg: maxItems: 1 -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 2025-01-14 5:45 [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 Wenhua Lin @ 2025-01-14 7:38 ` Krzysztof Kozlowski 2025-01-14 7:40 ` Krzysztof Kozlowski 2025-01-20 3:21 ` wenhua lin 0 siblings, 2 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2025-01-14 7:38 UTC (permalink / raw) To: Wenhua Lin, Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, Cixi Geng, linux-kernel, linux-serial, devicetree, wenhua lin, Xiongpeng Wu, Zhaochen Su, Zhirong Qiu On 14/01/2025 06:45, Wenhua Lin wrote: > Due to the platform's new project uart ip upgrade, > the new project's timeout interrupt needs to use bit17 > while other projects' timeout interrupt needs to use > bit13, using private data to adapt and be compatible Where is private data in this patch? > with all projects. The sc9632-uart is incompatible > with sc9836-uart, Add sc9632-uart dedicated compatible > for representing uart of the new project UMS9632 SoC. First part of commit said these are not compatible. Here you claim they are compatible, so this is just confusing. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com> > --- > Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > index a2a5056eba04..35fe9c301cd2 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > @@ -17,13 +17,17 @@ properties: > oneOf: > - items: > - enum: > - - sprd,sc9632-uart No, not explained, not justified. > - sprd,sc9860-uart > - sprd,sc9863a-uart > - sprd,ums512-uart > - sprd,ums9620-uart > - const: sprd,sc9836-uart > - const: sprd,sc9836-uart > + - items: > + - enum: > + - sprd,sc9632-uart > + - const: sprd,sc9632-uart This means nothing. Device cannot be compatible with itself. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 2025-01-14 7:38 ` Krzysztof Kozlowski @ 2025-01-14 7:40 ` Krzysztof Kozlowski 2025-01-20 3:34 ` wenhua lin 2025-01-20 3:21 ` wenhua lin 1 sibling, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2025-01-14 7:40 UTC (permalink / raw) To: Wenhua Lin, Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, Cixi Geng, linux-kernel, linux-serial, devicetree, wenhua lin, Xiongpeng Wu, Zhaochen Su, Zhirong Qiu On 14/01/2025 08:38, Krzysztof Kozlowski wrote: > >> - sprd,sc9860-uart >> - sprd,sc9863a-uart >> - sprd,ums512-uart >> - sprd,ums9620-uart >> - const: sprd,sc9836-uart >> - const: sprd,sc9836-uart >> + - items: >> + - enum: >> + - sprd,sc9632-uart >> + - const: sprd,sc9632-uart > > This means nothing. Device cannot be compatible with itself. And probably will fail testing, so please respond here with pasted results of dt_binding_check and dtbs_check as proof that you actually run them. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 2025-01-14 7:40 ` Krzysztof Kozlowski @ 2025-01-20 3:34 ` wenhua lin 0 siblings, 0 replies; 6+ messages in thread From: wenhua lin @ 2025-01-20 3:34 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Wenhua Lin, Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Orson Zhai, Baolin Wang, Chunyan Zhang, Cixi Geng, linux-kernel, linux-serial, devicetree, Xiongpeng Wu, Zhaochen Su, Zhirong Qiu On Tue, Jan 14, 2025 at 3:40 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 14/01/2025 08:38, Krzysztof Kozlowski wrote: > > > >> - sprd,sc9860-uart > >> - sprd,sc9863a-uart > >> - sprd,ums512-uart > >> - sprd,ums9620-uart > >> - const: sprd,sc9836-uart > >> - const: sprd,sc9836-uart > >> + - items: > >> + - enum: > >> + - sprd,sc9632-uart > >> + - const: sprd,sc9632-uart > > > > This means nothing. Device cannot be compatible with itself. > > And probably will fail testing, so please respond here with pasted > results of dt_binding_check and dtbs_check as proof that you actually > run them. > > Hi Krzysztof: We made a very elementary mistake. Thank you for your reminder. We will modify it on PATCH V2 and provide dt_binding_check results. Thanks > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 2025-01-14 7:38 ` Krzysztof Kozlowski 2025-01-14 7:40 ` Krzysztof Kozlowski @ 2025-01-20 3:21 ` wenhua lin 2025-01-20 7:23 ` Krzysztof Kozlowski 1 sibling, 1 reply; 6+ messages in thread From: wenhua lin @ 2025-01-20 3:21 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Wenhua Lin, Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Orson Zhai, Baolin Wang, Chunyan Zhang, Cixi Geng, linux-kernel, linux-serial, devicetree, Xiongpeng Wu, Zhaochen Su, Zhirong Qiu On Tue, Jan 14, 2025 at 3:38 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 14/01/2025 06:45, Wenhua Lin wrote: > > Due to the platform's new project uart ip upgrade, > > the new project's timeout interrupt needs to use bit17 > > while other projects' timeout interrupt needs to use > > bit13, using private data to adapt and be compatible > > Where is private data in this patch? Hi Krzysztof: This private data is a modification of the serial driver. Due to the modification of the driver, the new project ums9632 SoC needs to use SC9632 to be compatible. Thanks > > > with all projects. The sc9632-uart is incompatible > > with sc9836-uart, Add sc9632-uart dedicated compatible > > for representing uart of the new project UMS9632 SoC. > > First part of commit said these are not compatible. Here you claim they > are compatible, so this is just confusing. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > Hi Krzysztof: Sorry, I may have made a mistake, the patch version was submitted incorrectly. We want to submit this version https://lore.kernel.org/all/987b764e-17a6-4280-95e2-858d4c74a8d5@kernel.org/, but since this submission PATCH V1 has been merged, we made a new submission, but when doing the dtbs_check and dt_binding_check checks locally, we deliberately changed an error to see if the check is effective, but when submitting, the patch version was submitted incorrectly. Thanks > > > > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com> > > --- > > Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > index a2a5056eba04..35fe9c301cd2 100644 > > --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > @@ -17,13 +17,17 @@ properties: > > oneOf: > > - items: > > - enum: > > - - sprd,sc9632-uart > > No, not explained, not justified. > > > - sprd,sc9860-uart > > - sprd,sc9863a-uart > > - sprd,ums512-uart > > - sprd,ums9620-uart > > - const: sprd,sc9836-uart > > - const: sprd,sc9836-uart > > + - items: > > + - enum: > > + - sprd,sc9632-uart > > + - const: sprd,sc9632-uart > > This means nothing. Device cannot be compatible with itself. > Hi Krzysztof: We need UMS9632 SoC to compatible with sc9632. But now this patch version is submitted incorrectly, we will modify it in PATCH V2 version. Example: @@ -188,8 +188,8 @@ apb@20200000 { #size-cells = <1>; uart0: serial@0 { - compatible = "sprd,ums9620-uart", - "sprd,sc9836-uart"; + compatible = "sprd,ums9632-uart", + "sprd,sc9632-uart"; reg = <0 0x100>; interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>; clocks = <&ext_26m>; @@ -197,8 +197,8 @@ uart0: serial@0 { }; uart1: serial@10000 { - compatible = "sprd,ums9620-uart", - "sprd,sc9836-uart"; + compatible = "sprd,ums9632-uart", + "sprd,sc9632-uart"; reg = <0x10000 0x100>; interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>; clocks = <&ext_26m>; Thanks > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 2025-01-20 3:21 ` wenhua lin @ 2025-01-20 7:23 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2025-01-20 7:23 UTC (permalink / raw) To: wenhua lin Cc: Wenhua Lin, Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Orson Zhai, Baolin Wang, Chunyan Zhang, Cixi Geng, linux-kernel, linux-serial, devicetree, Xiongpeng Wu, Zhaochen Su, Zhirong Qiu On 20/01/2025 04:21, wenhua lin wrote: > On Tue, Jan 14, 2025 at 3:38 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 14/01/2025 06:45, Wenhua Lin wrote: >>> Due to the platform's new project uart ip upgrade, >>> the new project's timeout interrupt needs to use bit17 >>> while other projects' timeout interrupt needs to use >>> bit13, using private data to adapt and be compatible >> >> Where is private data in this patch? > > Hi Krzysztof: > This private data is a modification of the serial driver. > Due to the modification of the driver, the new project ums9632 SoC > needs to use SC9632 to be compatible. This patch is about bindings, so your driver implementation usually does not matter. Explain the hardware. > Thanks Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-20 7:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-01-14 5:45 [PATCH] dt-bindings: serial: Add a new compatible string for UMS9632 Wenhua Lin 2025-01-14 7:38 ` Krzysztof Kozlowski 2025-01-14 7:40 ` Krzysztof Kozlowski 2025-01-20 3:34 ` wenhua lin 2025-01-20 3:21 ` wenhua lin 2025-01-20 7:23 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox