* [PATCH] nvmem: rockchip-efuse: amend compatible rk322x-efuse to rk3228-efuse
@ 2017-06-22 8:46 Frank Wang
[not found] ` <1498121207-24941-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Frank Wang @ 2017-06-22 8:46 UTC (permalink / raw)
To: srinivas.kandagatla, robh+dt, mark.rutland, heiko
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
huangtao, finley.xiao, cl, wmc, Frank Wang
As the comments from Heiko Stuebner <heiko@sntech.de> that compatible
should not contain any placeholders, this patch fix it for rk3228 SoC.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 2 +-
drivers/nvmem/rockchip-efuse.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
index 194926f..1ff02afd 100644
--- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
+++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
@@ -4,7 +4,7 @@ Required properties:
- compatible: Should be one of the following.
- "rockchip,rk3066a-efuse" - for RK3066a SoCs.
- "rockchip,rk3188-efuse" - for RK3188 SoCs.
- - "rockchip,rk322x-efuse" - for RK322x SoCs.
+ - "rockchip,rk3228-efuse" - for RK3228 SoCs.
- "rockchip,rk3288-efuse" - for RK3288 SoCs.
- "rockchip,rk3399-efuse" - for RK3399 SoCs.
- reg: Should contain the registers location and exact eFuse size
diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
index a0d4ede..63e3eb5 100644
--- a/drivers/nvmem/rockchip-efuse.c
+++ b/drivers/nvmem/rockchip-efuse.c
@@ -170,7 +170,7 @@ static const struct of_device_id rockchip_efuse_match[] = {
.data = (void *)&rockchip_rk3288_efuse_read,
},
{
- .compatible = "rockchip,rk322x-efuse",
+ .compatible = "rockchip,rk3228-efuse",
.data = (void *)&rockchip_rk3288_efuse_read,
},
{
--
2.0.0
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1498121207-24941-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>]
* Re: [PATCH] nvmem: rockchip-efuse: amend compatible rk322x-efuse to rk3228-efuse [not found] ` <1498121207-24941-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> @ 2017-06-22 9:10 ` Heiko Stuebner 2017-06-26 18:39 ` Rob Herring 1 sibling, 0 replies; 3+ messages in thread From: Heiko Stuebner @ 2017-06-22 9:10 UTC (permalink / raw) To: Frank Wang Cc: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, huangtao-TNX95d0MmH7DzftRWevZcw, finley.xiao-TNX95d0MmH7DzftRWevZcw, cl-TNX95d0MmH7DzftRWevZcw, wmc-TNX95d0MmH7DzftRWevZcw Am Donnerstag, 22. Juni 2017, 16:46:47 CEST schrieb Frank Wang: > As the comments from Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> that compatible > should not contain any placeholders, this patch fix it for rk3228 SoC. > > Signed-off-by: Frank Wang <frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> not sure how this slipped through in the first place, but the rk322x compatible would only make it into 4.13, so it should still be fine to simply correct that issue, before it hits mainline. Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> > --- > Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 2 +- > drivers/nvmem/rockchip-efuse.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > index 194926f..1ff02afd 100644 > --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > @@ -4,7 +4,7 @@ Required properties: > - compatible: Should be one of the following. > - "rockchip,rk3066a-efuse" - for RK3066a SoCs. > - "rockchip,rk3188-efuse" - for RK3188 SoCs. > - - "rockchip,rk322x-efuse" - for RK322x SoCs. > + - "rockchip,rk3228-efuse" - for RK3228 SoCs. > - "rockchip,rk3288-efuse" - for RK3288 SoCs. > - "rockchip,rk3399-efuse" - for RK3399 SoCs. > - reg: Should contain the registers location and exact eFuse size > diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c > index a0d4ede..63e3eb5 100644 > --- a/drivers/nvmem/rockchip-efuse.c > +++ b/drivers/nvmem/rockchip-efuse.c > @@ -170,7 +170,7 @@ static const struct of_device_id rockchip_efuse_match[] = { > .data = (void *)&rockchip_rk3288_efuse_read, > }, > { > - .compatible = "rockchip,rk322x-efuse", > + .compatible = "rockchip,rk3228-efuse", > .data = (void *)&rockchip_rk3288_efuse_read, > }, > { > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmem: rockchip-efuse: amend compatible rk322x-efuse to rk3228-efuse [not found] ` <1498121207-24941-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2017-06-22 9:10 ` Heiko Stuebner @ 2017-06-26 18:39 ` Rob Herring 1 sibling, 0 replies; 3+ messages in thread From: Rob Herring @ 2017-06-26 18:39 UTC (permalink / raw) To: Frank Wang Cc: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, mark.rutland-5wv7dgnIgG8, heiko-4mtYJXux2i+zQB+pC5nmwQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, huangtao-TNX95d0MmH7DzftRWevZcw, finley.xiao-TNX95d0MmH7DzftRWevZcw, cl-TNX95d0MmH7DzftRWevZcw, wmc-TNX95d0MmH7DzftRWevZcw On Thu, Jun 22, 2017 at 04:46:47PM +0800, Frank Wang wrote: > As the comments from Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> that compatible > should not contain any placeholders, this patch fix it for rk3228 SoC. > > Signed-off-by: Frank Wang <frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > --- > Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 2 +- > drivers/nvmem/rockchip-efuse.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-26 18:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-22 8:46 [PATCH] nvmem: rockchip-efuse: amend compatible rk322x-efuse to rk3228-efuse Frank Wang
[not found] ` <1498121207-24941-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-06-22 9:10 ` Heiko Stuebner
2017-06-26 18:39 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox