From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org>,
Markus Fischer <markus.fischer.ec-Jj5Fu8i2Z9Q@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Michael Weiss <michael.weiss-Jj5Fu8i2Z9Q@public.gmane.org>,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
Wolfgang Grandegger <wg-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board
Date: Mon, 03 May 2010 11:34:27 -0500 [thread overview]
Message-ID: <4BDEFB13.5060407@freescale.com> (raw)
In-Reply-To: <g2tfa686aa41005020754t46934f13hbd5c75a6b7668a54-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Grant Likely wrote:
>> + // IPIC
>> + // interrupts cell = <intr #, sense>
>> + // sense values match linux IORESOURCE_IRQ_* defines:
>> + // sense == 8: Level, low assertion
>> + // sense == 2: Edge, high-to-low change
>> + //
>> + ipic: interrupt-controller@c00 {
>> + compatible = "fsl,mpc5121-ipic", "fsl,ipic";
>> + interrupt-controller;
>> + #address-cells = <0>;
>
> Don't need #address-cells here
#address-cells is required by ePAPR for interrupt controllers if an
interrupt-map is used. While there isn't one in this tree, it's best to
just always include #address-cells in interrupt controller nodes.
-Scott
next prev parent reply other threads:[~2010-05-03 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1272659448-23302-1-git-send-email-agust@denx.de>
[not found] ` <1272659448-23302-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2010-04-30 20:30 ` [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board Anatolij Gustschin
[not found] ` <1272659448-23302-2-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2010-05-02 14:54 ` Grant Likely
2010-05-03 9:22 ` Anatolij Gustschin
[not found] ` <g2tfa686aa41005020754t46934f13hbd5c75a6b7668a54-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-03 16:34 ` Scott Wood [this message]
[not found] ` <4BDEFB13.5060407-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-05-19 21:27 ` Grant Likely
2010-05-19 21:37 ` Scott Wood
[not found] ` <4BF45A1F.70100-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-05-19 21:47 ` Grant Likely
[not found] ` <AANLkTinxuFz3SSLZtF3yGYtRN8nsW8_6EDiqzmJilYE9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-22 21:39 ` Scott Wood
2010-05-03 10:23 ` [PATCH v2 " Anatolij Gustschin
[not found] ` <1272882222-12253-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2010-07-23 13:49 ` [PATCH v3 " Anatolij Gustschin
[not found] ` <1279892973-24110-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2010-07-25 7:42 ` Grant Likely
[not found] ` <AANLkTi=Ee6HR+Ux0g4V1+81DXUmsO=UDhi6jWsDgGchv-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-27 10:36 ` Anatolij Gustschin
2010-07-27 16:58 ` Grant Likely
[not found] ` <AANLkTika=KeKcaY_FF8tN5Fy-H+cozjZsGObXoQhKiVh-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-27 17:28 ` Anatolij Gustschin
2010-07-27 17:43 ` Grant Likely
2010-07-27 21:26 ` [PATCH v4 " Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDEFB13.5060407@freescale.com \
--to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dzu-ynQEQJNshbs@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=markus.fischer.ec-Jj5Fu8i2Z9Q@public.gmane.org \
--cc=michael.weiss-Jj5Fu8i2Z9Q@public.gmane.org \
--cc=wg-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox