[PATCH] distclean: Remove generated .dtb files

[PATCH] distclean: Remove generated .dtb files

[Dirk Behme]

The patch 'arm/dt: Add dtb make rule' adds support to
create a .dtb file. But this is never removed afterwards.
Remove the generated .dtb file if 'distclean' is called.

Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
CC: Rob Herring <rob.herring@calxeda.com>
CC: Shawn Guo <shawn.guo@freescale.com>
CC: Jason Liu <jason.hui@linaro.org>
CC: Grant Likely <grant.likely@secretlab.ca>
---
 arch/arm/boot/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
index 1cd9b0a..08f0d35 100644
--- a/arch/arm/boot/Makefile
+++ b/arch/arm/boot/Makefile
@@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
 
 $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
 
+clean-files := *.dtb
+
 quiet_cmd_uimage = UIMAGE  $@
       cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
 		   -C none -a $(LOADADDR) -e $(STARTADDR) \
-- 
1.7.0.4

Re: [PATCH] distclean: Remove generated .dtb files

[Grant Likely]

On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
> The patch 'arm/dt: Add dtb make rule' adds support to
> create a .dtb file. But this is never removed afterwards.
> Remove the generated .dtb file if 'distclean' is called.
> 
> Signed-off-by: Dirk Behme <dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
> CC: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> CC: Shawn Guo <shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> CC: Jason Liu <jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

> ---
>  arch/arm/boot/Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
> index 1cd9b0a..08f0d35 100644
> --- a/arch/arm/boot/Makefile
> +++ b/arch/arm/boot/Makefile
> @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
>  
>  $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
>  
> +clean-files := *.dtb
> +
>  quiet_cmd_uimage = UIMAGE  $@
>        cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
>  		   -C none -a $(LOADADDR) -e $(STARTADDR) \
> -- 
> 1.7.0.4
> 

Re: [PATCH] distclean: Remove generated .dtb files

[Grant Likely]

On Sun, Nov 6, 2011 at 11:38 AM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
> On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
>> The patch 'arm/dt: Add dtb make rule' adds support to
>> create a .dtb file. But this is never removed afterwards.
>> Remove the generated .dtb file if 'distclean' is called.
>>
>> Signed-off-by: Dirk Behme <dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
>> CC: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> CC: Shawn Guo <shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>> CC: Jason Liu <jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>
> Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

... although why are only the .dtb files needed in the clean list?
How are the other built files cleaned?  'make clean' does remove the
other images, but I don't know what the mechanism is.

g.

>
>> ---
>>  arch/arm/boot/Makefile |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
>> index 1cd9b0a..08f0d35 100644
>> --- a/arch/arm/boot/Makefile
>> +++ b/arch/arm/boot/Makefile
>> @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
>>
>>  $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
>>
>> +clean-files := *.dtb
>> +
>>  quiet_cmd_uimage = UIMAGE  $@
>>        cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
>>                  -C none -a $(LOADADDR) -e $(STARTADDR) \
>> --
>> 1.7.0.4
>>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [PATCH] distclean: Remove generated .dtb files

[Dirk Behme]

On 06.11.2011 19:42, Grant Likely wrote:
> On Sun, Nov 6, 2011 at 11:38 AM, Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>  wrote:
>> On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
>>> The patch 'arm/dt: Add dtb make rule' adds support to
>>> create a .dtb file. But this is never removed afterwards.
>>> Remove the generated .dtb file if 'distclean' is called.
>>>
>>> Signed-off-by: Dirk Behme<dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
>>> CC: Rob Herring<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>>> CC: Shawn Guo<shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>> CC: Jason Liu<jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>> CC: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>>
>> Acked-by: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>
> ... although why are only the .dtb files needed in the clean list?
> How are the other built files cleaned?  'make clean' does remove the
> other images, but I don't know what the mechanism is.

A lot of stuff is removed by the top level Makefile [1]. But as the 
patch "arm/dt: Add dtb make rule" adds the .dtb generation to 
arch/arm/boot/Makefile, we thought it would be a good place to add the 
removal of that file there, too.

Hmm, not sure if this answers your question, though ;)

Best regards

Dirk

[1] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Makefile;h=ed25c5b35470dc2035f8b024994fa6cb7cecaca6;hb=HEAD#l1188

>>
>>> ---
>>>   arch/arm/boot/Makefile |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
>>> index 1cd9b0a..08f0d35 100644
>>> --- a/arch/arm/boot/Makefile
>>> +++ b/arch/arm/boot/Makefile
>>> @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
>>>
>>>   $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
>>>
>>> +clean-files := *.dtb
>>> +
>>>   quiet_cmd_uimage = UIMAGE  $@
>>>         cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
>>>                   -C none -a $(LOADADDR) -e $(STARTADDR) \
>>> --
>>> 1.7.0.4
>>>
>>
>
>
>

Re: [PATCH] distclean: Remove generated .dtb files

[Grant Likely]

[-- Attachment #1.1: Type: text/plain, Size: 1516 bytes --]

On Nov 6, 2011 11:25 PM, "Dirk Behme" <dirk.behme-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote:
>
> On 06.11.2011 19:42, Grant Likely wrote:
>>
>> On Sun, Nov 6, 2011 at 11:38 AM, Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
 wrote:
>>>
>>> On Sat, Nov 05, 2011 at 07:19:15AM +0100, Dirk Behme wrote:
>>>>
>>>> The patch 'arm/dt: Add dtb make rule' adds support to
>>>> create a .dtb file. But this is never removed afterwards.
>>>> Remove the generated .dtb file if 'distclean' is called.
>>>>
>>>> Signed-off-by: Dirk Behme<dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
>>>> CC: Rob Herring<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>>>> CC: Shawn Guo<shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>>> CC: Jason Liu<jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>>> CC: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>>>
>>>
>>> Acked-by: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>>
>>
>> ... although why are only the .dtb files needed in the clean list?
>> How are the other built files cleaned?  'make clean' does remove the
>> other images, but I don't know what the mechanism is.
>
>
> A lot of stuff is removed by the top level Makefile [1]. But as the patch
"arm/dt: Add dtb make rule" adds the .dtb generation to
arch/arm/boot/Makefile, we thought it would be a good place to add the
removal of that file there, too.
>
> Hmm, not sure if this answers your question, though ;)

Okay. Good enough for me.

g.

[-- Attachment #1.2: Type: text/html, Size: 2487 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] distclean: Remove generated .dtb files

[Rob Herring]

On 11/05/2011 01:19 AM, Dirk Behme wrote:
> The patch 'arm/dt: Add dtb make rule' adds support to
> create a .dtb file. But this is never removed afterwards.
> Remove the generated .dtb file if 'distclean' is called.
> 
> Signed-off-by: Dirk Behme <dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
> CC: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> CC: Shawn Guo <shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> CC: Jason Liu <jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> ---

Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>

>  arch/arm/boot/Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
> index 1cd9b0a..08f0d35 100644
> --- a/arch/arm/boot/Makefile
> +++ b/arch/arm/boot/Makefile
> @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
>  
>  $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
>  
> +clean-files := *.dtb
> +
>  quiet_cmd_uimage = UIMAGE  $@
>        cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
>  		   -C none -a $(LOADADDR) -e $(STARTADDR) \

Re: [PATCH] distclean: Remove generated .dtb files

[Dirk Behme]

On 07.11.2011 14:51, Rob Herring wrote:
> On 11/05/2011 01:19 AM, Dirk Behme wrote:
>> The patch 'arm/dt: Add dtb make rule' adds support to
>> create a .dtb file. But this is never removed afterwards.
>> Remove the generated .dtb file if 'distclean' is called.
>>
>> Signed-off-by: Dirk Behme<dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
>> CC: Rob Herring<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> CC: Shawn Guo<shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>> CC: Jason Liu<jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> CC: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> ---
>
> Acked-by: Rob Herring<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
...
> Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

Submitted to Russell King's Patch Tracking System:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7152/1

Thanks

Dirk

>>   arch/arm/boot/Makefile |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
>> index 1cd9b0a..08f0d35 100644
>> --- a/arch/arm/boot/Makefile
>> +++ b/arch/arm/boot/Makefile
>> @@ -71,6 +71,8 @@ $(obj)/%.dtb: $(src)/dts/%.dts
>>
>>   $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
>>
>> +clean-files := *.dtb
>> +
>>   quiet_cmd_uimage = UIMAGE  $@
>>         cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \
>>   		   -C none -a $(LOADADDR) -e $(STARTADDR) \
>
>