* [PATCH] arm64: dts: qcom: glymur-crd: Enable LID sensor
@ 2026-04-28 12:32 Abel Vesa
2026-04-28 12:42 ` Konrad Dybcio
2026-05-12 20:22 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Abel Vesa @ 2026-04-28 12:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa
The Glymur CRD has a Hall-effect sensor used for detecting when the
lid is opened or closed. Describe it as an SW_LID gpio-key switch.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
index 2852d257ac8c..357d4ad8380a 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
@@ -10,6 +10,8 @@
#include "pmk8850.dtsi" /* SPMI0: SID-0 */
#include "smb2370.dtsi" /* SPMI2: SID-9/10/11 */
+#include <dt-bindings/input/gpio-keys.h>
+
/ {
model = "Qualcomm Technologies, Inc. Glymur CRD";
compatible = "qcom,glymur-crd", "qcom,glymur";
@@ -44,7 +46,7 @@ sleep_clk: sleep-clk {
gpio-keys {
compatible = "gpio-keys";
- pinctrl-0 = <&key_vol_up_default>;
+ pinctrl-0 = <&key_vol_up_default>, <&hall_int_n_default>;
pinctrl-names = "default";
key-volume-up {
@@ -55,6 +57,15 @@ key-volume-up {
linux,can-disable;
wakeup-source;
};
+
+ switch-lid {
+ label = "lid";
+ gpios = <&tlmm 92 GPIO_ACTIVE_LOW>;
+ linux,input-type = <EV_SW>;
+ linux,code = <SW_LID>;
+ wakeup-source;
+ wakeup-event-action = <EV_ACT_DEASSERTED>;
+ };
};
vreg_nvme: regulator-nvme {
@@ -565,6 +576,12 @@ &tlmm {
<10 2>, /* OOB UART */
<44 4>; /* Security SPI (TPM) */
+ hall_int_n_default: hall-int-n-state {
+ pins = "gpio92";
+ function = "gpio";
+ bias-disable;
+ };
+
pcie4_default: pcie4-default-state {
clkreq-n-pins {
pins = "gpio147";
---
base-commit: 39704f00f747aba3144289870b5fd8ac230a9aaf
change-id: 20260424-glymur-dts-add-lid-sensor-e3da709a7ee9
Best regards,
--
Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable LID sensor
2026-04-28 12:32 [PATCH] arm64: dts: qcom: glymur-crd: Enable LID sensor Abel Vesa
@ 2026-04-28 12:42 ` Konrad Dybcio
2026-05-12 20:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-04-28 12:42 UTC (permalink / raw)
To: Abel Vesa, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 4/28/26 2:32 PM, Abel Vesa wrote:
> The Glymur CRD has a Hall-effect sensor used for detecting when the
> lid is opened or closed. Describe it as an SW_LID gpio-key switch.
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable LID sensor
2026-04-28 12:32 [PATCH] arm64: dts: qcom: glymur-crd: Enable LID sensor Abel Vesa
2026-04-28 12:42 ` Konrad Dybcio
@ 2026-05-12 20:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-05-12 20:22 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa
Cc: linux-arm-msm, devicetree, linux-kernel
On Tue, 28 Apr 2026 15:32:29 +0300, Abel Vesa wrote:
> The Glymur CRD has a Hall-effect sensor used for detecting when the
> lid is opened or closed. Describe it as an SW_LID gpio-key switch.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: glymur-crd: Enable LID sensor
commit: 627aab9bfe03613c9f0142d5a70faa7ff9634569
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-12 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 12:32 [PATCH] arm64: dts: qcom: glymur-crd: Enable LID sensor Abel Vesa
2026-04-28 12:42 ` Konrad Dybcio
2026-05-12 20:22 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox