From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: george.moussalem@outlook.com, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Praveenkumar I <praveenkumar.i@oss.qualcomm.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
Nitheesh Sekar <quic_nsekar@quicinc.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Stanislaw Pal <kuncy7@gmail.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v4 00/13] Enable USB3 for Qualcomm IPQ5018
Date: Tue, 20 Oct 2026 09:59:27 +0200 [thread overview]
Message-ID: <4f586fa8-e7c1-42fd-b853-a2093e8a243b@oss.qualcomm.com> (raw)
In-Reply-To: <20260908-ipq5018-usb3-v4-0-b789702f0695@outlook.com>
On 9/8/26 11:40 AM, George Moussalem via B4 Relay wrote:
> Patch series adds Qualcomm 22ull Super-Speed USB UNIPHY driver support
> present in Qualcomm IPQ5018 and IPQ5332 SoC which is required to enable
> USB3. This PHY is interfaced with SNPS DWC3 USB and SNPS DWC PCIe.
> Either one of the interface can use it via the mux selection present in
> the TCSR register. Current patch series adds the support for UNIPHY with
> DWC3 USB.
>
> The series is now split into 3 parts:
> 1. Flatten USB Controller Nodes on IPQ SoCs
> link: https://lore.kernel.org/r/20260906-ipq-flatten-usb-v3-0-13e4e0f63123@outlook.com
> 2. Enable USB3 for Qualcomm IPQ5018 (this patch series)
> 3. Enable USB3 for Qualcomm IPQ5332 (to be submitted)
>
> ---
> Changes in v4:
[...]
> - It's worth noting that I left the logic to register 1 phy in this
> patch unchanged despite Konard's suggestion to register both
> (PCIe and USB3) to avoid changing the existing binding for the
> existing PCIe phy instances in ipq5018/ipq5332. Although the silicon
> is capable of supporting both PCIe and USB3, the instances in scope
> are wired for single mode only. The next patch set will register both
> PCIe and USB3 PHYs for the combo PHY instance in IPQ5332 and use
> #phy-cells to select the right PHY in the respective PCIe and USB3
> controller nodes.
We need a bindings change either way, so might as well do it
"right"!
Konrad
prev parent reply other threads:[~2026-10-20 7:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 9:40 [PATCH v4 00/13] Enable USB3 for Qualcomm IPQ5018 George Moussalem via B4 Relay
2026-09-08 9:40 ` [PATCH v4 01/13] dt-bindings: phy: qcom,ipq5332-uniphy-pcie: Document the IPQ5018 USB3 PHY George Moussalem via B4 Relay
2026-09-08 9:40 ` [PATCH v4 02/13] phy: qualcomm: qcom-uniphy-pcie-28lp: Convert to PCIe/USB3 combo PHY driver George Moussalem via B4 Relay
2026-10-12 12:37 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 03/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Remove unused of_device.h header file George Moussalem via B4 Relay
2026-10-12 12:38 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 04/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Drop unused phy_to_dw_phy macro George Moussalem via B4 Relay
2026-10-12 12:39 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 05/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Refactor init regs table definitions George Moussalem via B4 Relay
2026-10-12 12:40 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 06/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Use bulk reset_control API George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 07/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Assert reset on clock enable failure George Moussalem via B4 Relay
2026-10-12 12:41 ` Manivannan Sadhasivam
2026-09-08 9:41 ` [PATCH v4 08/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Add support for USB3 PHY on IPQ5018 George Moussalem via B4 Relay
2026-10-12 12:48 ` Manivannan Sadhasivam
2026-09-08 9:41 ` [PATCH v4 09/13] arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 10/13] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018 George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 11/13] arm64: dts: qcom: ipq5018: Add clocks required for USB3 support George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 12/13] arm64: dts: qcom: ipq5018: Add Super-Speed UNIPHY to USB node George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 13/13] arm64: dts: qcom: ipq5018-rdp432-c2: Enable USB Super-Speed PHY George Moussalem via B4 Relay
2026-10-20 7:59 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f586fa8-e7c1-42fd-b853-a2093e8a243b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=george.moussalem@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuncy7@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=praveenkumar.i@oss.qualcomm.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=varadarajan.narayanan@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox