* [PATCH 08/12] dtc: be more quiet with "make -s"
[not found] ` <1348868177-21205-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
@ 2012-09-28 21:36 ` Arnd Bergmann
2012-09-28 21:55 ` Stephen Warren
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2012-09-28 21:36 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Michal Marek, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Gibson,
arm-DgEjT+Ai2ygdnm+yROfE0A
On a normal build, we get output from both make and from dtc
about each file that is being processed.
DTC arch/arm/boot/vexpress-v2p-ca5s.dtb
DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca5s.dts"
DTC arch/arm/boot/vexpress-v2p-ca9.dtb
DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca9.dts"
DTC arch/arm/boot/vexpress-v2p-ca15-tc1.dtb
DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts"
DTC arch/arm/boot/vexpress-v2p-ca15_a7.dtb
DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts"
When both lines refer to the same action. When building with "make -s",
the "DTC: dts->dtb ..." line is the only output we currently get.
This patch makes dtc not output the message when the "-q" flag is passed,
and ensures that we pass it in both cases.
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Michal Marek <mmarek-AlSwsSmVLrQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: David Gibson <dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org>
---
scripts/Makefile.lib | 2 +-
scripts/dtc/dtc.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 0be6f11..662528a 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -264,7 +264,7 @@ $(obj)/%.dtb.S: $(obj)/%.dtb
$(call cmd,dt_S_dtb)
quiet_cmd_dtc = DTC $@
-cmd_dtc = $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) -d $(depfile) $<
+cmd_dtc = $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) -q -d $(depfile) $<
# Bzip2
# ---------------------------------------------------------------------------
diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
index 2ef5e2e..a1586ff 100644
--- a/scripts/dtc/dtc.c
+++ b/scripts/dtc/dtc.c
@@ -188,8 +188,9 @@ int main(int argc, char *argv[])
if (minsize)
fprintf(stderr, "DTC: Use of \"-S\" is deprecated; it will be removed soon, use \"-p\" instead\n");
- fprintf(stderr, "DTC: %s->%s on file \"%s\"\n",
- inform, outform, arg);
+ if (!quiet)
+ fprintf(stderr, "DTC: %s->%s on file \"%s\"\n",
+ inform, outform, arg);
if (depname) {
depfile = fopen(depname, "w");
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 08/12] dtc: be more quiet with "make -s"
2012-09-28 21:36 ` [PATCH 08/12] dtc: be more quiet with "make -s" Arnd Bergmann
@ 2012-09-28 21:55 ` Stephen Warren
2012-09-29 7:27 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2012-09-28 21:55 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Michal Marek, devicetree-discuss, linux-kernel,
David Gibson, arm
On 09/28/2012 03:36 PM, Arnd Bergmann wrote:
> On a normal build, we get output from both make and from dtc
> about each file that is being processed.
>
> DTC arch/arm/boot/vexpress-v2p-ca5s.dtb
> DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca5s.dts"
> DTC arch/arm/boot/vexpress-v2p-ca9.dtb
> DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca9.dts"
> DTC arch/arm/boot/vexpress-v2p-ca15-tc1.dtb
> DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts"
> DTC arch/arm/boot/vexpress-v2p-ca15_a7.dtb
> DTC: dts->dtb on file "/git/arnd/linux-arm/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts"
>
> When both lines refer to the same action. When building with "make -s",
> the "DTC: dts->dtb ..." line is the only output we currently get.
>
> This patch makes dtc not output the message when the "-q" flag is passed,
> and ensures that we pass it in both cases.
Just as an FYI, the upstream dtc no longer prints this message, and I
just posted a patch to pull that whole upstream dtc into the kernel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 08/12] dtc: be more quiet with "make -s"
2012-09-28 21:55 ` Stephen Warren
@ 2012-09-29 7:27 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2012-09-29 7:27 UTC (permalink / raw)
To: Stephen Warren
Cc: linux-arm-kernel, Michal Marek, devicetree-discuss, linux-kernel,
David Gibson, arm
On Friday 28 September 2012, Stephen Warren wrote:
> On 09/28/2012 03:36 PM, Arnd Bergmann wrote:
> > This patch makes dtc not output the message when the "-q" flag is passed,
> > and ensures that we pass it in both cases.
>
> Just as an FYI, the upstream dtc no longer prints this message, and I
> just posted a patch to pull that whole upstream dtc into the kernel.
Ok, excellent!
Michal, please ignore my patch then.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-29 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1348868177-21205-1-git-send-email-arnd@arndb.de>
[not found] ` <1348868177-21205-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2012-09-28 21:36 ` [PATCH 08/12] dtc: be more quiet with "make -s" Arnd Bergmann
2012-09-28 21:55 ` Stephen Warren
2012-09-29 7:27 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox