* [patch] iio: adc: twl6030-gpadc: returning success instead of error
@ 2013-08-27 1:19 Dan Carpenter
[not found] ` <20130827011902.GC17061-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-08-27 1:19 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Grant Likely, Rob Herring, Oleksandr Kozaruk, Graeme Gregory,
Balaji T K, linux-iio-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
I've moved the goto down a line after we set the error code.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index a558516..0ea96c0 100644
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
ret = -ETIMEDOUT;
goto err;
} else if (timeout < 0) {
- goto err;
ret = -EINTR;
+ goto err;
}
switch (mask) {
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <20130827011902.GC17061-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>]
* Re: [patch] iio: adc: twl6030-gpadc: returning success instead of error [not found] ` <20130827011902.GC17061-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org> @ 2013-08-28 19:47 ` Jonathan Cameron 0 siblings, 0 replies; 2+ messages in thread From: Jonathan Cameron @ 2013-08-28 19:47 UTC (permalink / raw) To: Dan Carpenter Cc: Jonathan Cameron, Grant Likely, Rob Herring, Oleksandr Kozaruk, Graeme Gregory, Balaji T K, linux-iio-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA On 08/27/13 02:19, Dan Carpenter wrote: > I've moved the goto down a line after we set the error code. > > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sorry, I was being slow, but Wei Youngjun has already posted a fix for this one. Just applied to the togreg branch of iio.git Thanks Jonathan > > diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c > index a558516..0ea96c0 100644 > --- a/drivers/iio/adc/twl6030-gpadc.c > +++ b/drivers/iio/adc/twl6030-gpadc.c > @@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev, > ret = -ETIMEDOUT; > goto err; > } else if (timeout < 0) { > - goto err; > ret = -EINTR; > + goto err; > } > > switch (mask) { > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-28 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-27 1:19 [patch] iio: adc: twl6030-gpadc: returning success instead of error Dan Carpenter
[not found] ` <20130827011902.GC17061-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-08-28 19:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox