From: Arpit Saini <arpit.saini@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Nabige Aala <nabige.aala@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Date: Mon, 6 Jul 2026 14:22:06 +0530 [thread overview]
Message-ID: <52b7ee6e-bd99-4555-8a49-6cdde1331714@oss.qualcomm.com> (raw)
In-Reply-To: <7815e3ac-30c7-4564-9a7a-6a1ecb9278c8@kernel.org>
Hi Krzyszto,
On 7/6/2026 12:03 PM, Krzysztof Kozlowski wrote:
> On 06/07/2026 08:04, Nabige Aala wrote:
>> + lcd_bias: regulator-lcd-bias {
>> + compatible = "regulator-fixed";
>> + regulator-name = "lcd_bias";
>> + vin-supply = <&vph_pwr>;
>> + gpio = <&tlmm 151 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + pinctrl-0 = <&lcd_bias_en>;
>> + pinctrl-names = "default";
>> + };
>> +
>> + vph_pwr: vph-pwr-regulator {
> Why so inconsistent names?
>
> Anyway, drop the node, not used and not controllable.
As per the schematics of LCD display Bias driver , vph_pwr is used as
vin for that.
So I created vph_pwr , if you want , I can drop that in next patchset.
Thanks,
Arpit
>> + compatible = "regulator-fixed";
>> + regulator-name = "vph_pwr";
>> + regulator-always-on;
>> + regulator-boot-on;
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-07-06 8:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 6:04 [PATCH v2 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala
2026-07-06 6:04 ` [PATCH v2 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
2026-07-06 12:59 ` Konrad Dybcio
2026-07-06 6:04 ` [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
2026-07-06 6:33 ` Krzysztof Kozlowski
2026-07-06 8:52 ` Arpit Saini [this message]
2026-07-06 9:19 ` Krzysztof Kozlowski
2026-07-06 13:48 ` Dmitry Baryshkov
2026-07-06 15:33 ` Krzysztof Kozlowski
2026-07-06 10:03 ` Konrad Dybcio
2026-07-06 6:04 ` [PATCH v2 3/4] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-07-06 6:04 ` [PATCH v2 4/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
2026-07-06 6:34 ` Krzysztof Kozlowski
2026-07-06 8:54 ` Arpit Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52b7ee6e-bd99-4555-8a49-6cdde1331714@oss.qualcomm.com \
--to=arpit.saini@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nabige.aala@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox