* [PATCH v2] arm64: dts: qcom: sm8650-valve-deckard: Add initial support of camera sensors
@ 2026-10-02 10:17 Vladimir Zapolskiy
2026-10-02 10:20 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Zapolskiy @ 2026-10-02 10:17 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
Neil Armstrong, linux-arm-msm, devicetree
Add initial support of camera sensors on Valve "Steam Frame" device.
The change enables CAMSS and adds description of
- a pair of OmniVision OV6211 monochrome eyetracking camera sensors,
- a pair of OmniVision OG01A1B monochrome front camera sensors.
There is another pair of OmniVision OG0VE10 camera sensors found on
the device, its description requires a combo mode feature support in
the SM8650 CAMSS CSIPHY driver.
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Changes from v1 to v2:
* added Abel's Reviewed-by tag, thanks for review of the change,
* split default/sleep pinctl controls (reported by Sashiko bot),
* fixed data-lanes value of OG01A1B endpoints (reported by Sashiko bot),
OTOH the reported out-of-range '<&pm8550vs_e_gpios 6 ...>' value is
a false positive error by the bot, the controller gets GPIO numbers
from 1 to 6 range.
Link to v1 of the change:
* https://lore.kernel.org/all/20261001145206.2442665-1-vladimir.zapolskiy@linaro.org/
.../boot/dts/qcom/sm8650-valve-deckard.dts | 207 ++++++++++++++++++
1 file changed, 207 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
index d25a09e162dd..4120e9d676c1 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
@@ -95,6 +95,66 @@ vph_pwr: regulator-vph-pwr {
regulator-boot-on;
};
+ vreg_cam_eyetracking_1p8: regulator-cam-eyetracking {
+ compatible = "regulator-fixed";
+ regulator-name = "cam_eyetracking_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ vin-supply = <&vreg_l5m_1p8>;
+ };
+
+ vreg_cam_front_left_1p2: regulator-cam-front-left-1p2 {
+ compatible = "regulator-fixed";
+ regulator-name = "cam_front_left_1p2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+
+ gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ vin-supply = <&vreg_l2n_1p2>;
+ };
+
+ vreg_cam_front_left_1p8: regulator-cam-front-left-1p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "cam_front_left_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ gpio = <&tlmm 36 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ vin-supply = <&vreg_l5n_1p8>;
+ };
+
+ vreg_cam_front_right_1p2: regulator-cam-front-right-1p2 {
+ compatible = "regulator-fixed";
+ regulator-name = "cam_front_right_1p2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+
+ gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ vin-supply = <&vreg_l2m_1p2>;
+ };
+
+ vreg_cam_front_right_1p8: regulator-cam-front-right-1p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "cam_front_right_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ gpio = <&tlmm 36 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ vin-supply = <&vreg_l5m_1p8>;
+ };
+
reserved-memory {
#address-cells = <2>;
#size-cells = <2>;
@@ -675,6 +735,153 @@ vreg_l6n_2p8: ldo6 {
};
};
+&camss {
+ vdd-csiphy01-0p9-supply = <&vreg_l2i_0p88>;
+ vdd-csiphy01-1p2-supply = <&vreg_l3i_1p2>;
+ vdd-csiphy24-0p9-supply = <&vreg_l2i_0p88>;
+ vdd-csiphy24-1p2-supply = <&vreg_l3i_1p2>;
+
+ status = "okay";
+
+ ports {
+ port@0 {
+ csiphy0_ep: endpoint {
+ data-lanes = <0 1>;
+ remote-endpoint = <&cam_front_left>;
+ };
+ };
+
+ port@1 {
+ csiphy1_ep: endpoint {
+ data-lanes = <0 1>;
+ remote-endpoint = <&cam_front_right>;
+ };
+ };
+
+ port@2 {
+ csiphy2_ep: endpoint {
+ data-lanes = <0>;
+ remote-endpoint = <&cam_eyetracking_left>;
+ };
+ };
+
+ port@4 {
+ csiphy4_ep: endpoint {
+ data-lanes = <0>;
+ remote-endpoint = <&cam_eyetracking_right>;
+ };
+ };
+ };
+};
+
+&cci0 {
+ status = "okay";
+};
+
+&cci0_i2c1 {
+ sensor@60 {
+ compatible = "ovti,ov6211";
+ reg = <0x60>;
+ clocks = <&camcc CAM_CC_MCLK4_CLK>;
+ assigned-clocks = <&camcc CAM_CC_MCLK4_CLK>;
+ assigned-clock-rates = <24000000>;
+ pinctrl-0 = <&cam4_default>;
+ pinctrl-1 = <&cam4_sleep>;
+ pinctrl-names = "default", "sleep";
+ reset-gpios = <&tlmm 195 GPIO_ACTIVE_LOW>;
+ avdd-supply = <&vreg_l6n_2p8>;
+ dovdd-supply = <&vreg_cam_eyetracking_1p8>;
+ dvdd-supply = <&vreg_l1n_1p1>;
+
+ port {
+ cam_eyetracking_left: endpoint {
+ link-frequencies = /bits/ 64 <480000000>;
+ remote-endpoint = <&csiphy2_ep>;
+ };
+ };
+ };
+};
+
+&cci1 {
+ status = "okay";
+};
+
+&cci1_i2c0 {
+ sensor@60 {
+ compatible = "ovti,ov6211";
+ reg = <0x60>;
+ clocks = <&camcc CAM_CC_MCLK2_CLK>;
+ assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>;
+ assigned-clock-rates = <24000000>;
+ pinctrl-0 = <&cam2_default>;
+ pinctrl-1 = <&cam2_sleep>;
+ pinctrl-names = "default", "sleep";
+ reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
+ avdd-supply = <&vreg_l6m_2p8>;
+ dovdd-supply = <&vreg_cam_eyetracking_1p8>;
+ dvdd-supply = <&vreg_l1m_1p1>;
+
+ port {
+ cam_eyetracking_right: endpoint {
+ link-frequencies = /bits/ 64 <480000000>;
+ remote-endpoint = <&csiphy4_ep>;
+ };
+ };
+ };
+};
+
+&cci2 {
+ status = "okay";
+};
+
+&cci2_i2c0 {
+ sensor@36 {
+ compatible = "ovti,og01a1b";
+ reg = <0x36>;
+ clocks = <&camcc CAM_CC_MCLK0_CLK>;
+ assigned-clocks = <&camcc CAM_CC_MCLK0_CLK>;
+ assigned-clock-rates = <19200000>;
+ pinctrl-0 = <&cam0_default>;
+ pinctrl-1 = <&cam0_sleep>;
+ pinctrl-names = "default", "sleep";
+ reset-gpios = <&pm8550vs_e_gpios 4 GPIO_ACTIVE_LOW>;
+ avdd-supply = <&vreg_l3m_2p8>;
+ dovdd-supply = <&vreg_cam_front_right_1p8>;
+ dvdd-supply = <&vreg_cam_front_right_1p2>;
+
+ port {
+ cam_front_right: endpoint {
+ data-lanes = <1 2>;
+ link-frequencies = /bits/ 64 <500000000>;
+ remote-endpoint = <&csiphy1_ep>;
+ };
+ };
+ };
+
+ sensor@60 {
+ compatible = "ovti,og01a1b";
+ reg = <0x60>;
+ clocks = <&camcc CAM_CC_MCLK1_CLK>;
+ assigned-clocks = <&camcc CAM_CC_MCLK1_CLK>;
+ assigned-clock-rates = <19200000>;
+ pinctrl-0 = <&cam1_default>;
+ pinctrl-1 = <&cam1_sleep>;
+ pinctrl-names = "default", "sleep";
+ reset-gpios = <&pm8550vs_e_gpios 6 GPIO_ACTIVE_LOW>;
+ avdd-supply = <&vreg_l3n_2p8>;
+ dovdd-supply = <&vreg_cam_front_left_1p8>;
+ dvdd-supply = <&vreg_cam_front_left_1p2>;
+
+ port {
+ cam_front_left: endpoint {
+ data-lanes = <1 2>;
+ link-frequencies = /bits/ 64 <500000000>;
+ remote-endpoint = <&csiphy0_ep>;
+ };
+ };
+ };
+};
+
&dispcc {
status = "disabled";
};
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8650-valve-deckard: Add initial support of camera sensors
2026-10-02 10:17 [PATCH v2] arm64: dts: qcom: sm8650-valve-deckard: Add initial support of camera sensors Vladimir Zapolskiy
@ 2026-10-02 10:20 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2026-10-02 10:20 UTC (permalink / raw)
To: Vladimir Zapolskiy, Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree
On 10/2/26 12:17, Vladimir Zapolskiy wrote:
> Add initial support of camera sensors on Valve "Steam Frame" device.
>
> The change enables CAMSS and adds description of
> - a pair of OmniVision OV6211 monochrome eyetracking camera sensors,
> - a pair of OmniVision OG01A1B monochrome front camera sensors.
>
> There is another pair of OmniVision OG0VE10 camera sensors found on
> the device, its description requires a combo mode feature support in
> the SM8650 CAMSS CSIPHY driver.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Changes from v1 to v2:
> * added Abel's Reviewed-by tag, thanks for review of the change,
> * split default/sleep pinctl controls (reported by Sashiko bot),
> * fixed data-lanes value of OG01A1B endpoints (reported by Sashiko bot),
>
> OTOH the reported out-of-range '<&pm8550vs_e_gpios 6 ...>' value is
> a false positive error by the bot, the controller gets GPIO numbers
> from 1 to 6 range.
>
> Link to v1 of the change:
> * https://lore.kernel.org/all/20261001145206.2442665-1-vladimir.zapolskiy@linaro.org/
>
> .../boot/dts/qcom/sm8650-valve-deckard.dts | 207 ++++++++++++++++++
> 1 file changed, 207 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
> index d25a09e162dd..4120e9d676c1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
> @@ -95,6 +95,66 @@ vph_pwr: regulator-vph-pwr {
> regulator-boot-on;
> };
>
> + vreg_cam_eyetracking_1p8: regulator-cam-eyetracking {
> + compatible = "regulator-fixed";
> + regulator-name = "cam_eyetracking_1p8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + vin-supply = <&vreg_l5m_1p8>;
> + };
> +
> + vreg_cam_front_left_1p2: regulator-cam-front-left-1p2 {
> + compatible = "regulator-fixed";
> + regulator-name = "cam_front_left_1p2";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> +
> + gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + vin-supply = <&vreg_l2n_1p2>;
> + };
> +
> + vreg_cam_front_left_1p8: regulator-cam-front-left-1p8 {
> + compatible = "regulator-fixed";
> + regulator-name = "cam_front_left_1p8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + gpio = <&tlmm 36 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + vin-supply = <&vreg_l5n_1p8>;
> + };
> +
> + vreg_cam_front_right_1p2: regulator-cam-front-right-1p2 {
> + compatible = "regulator-fixed";
> + regulator-name = "cam_front_right_1p2";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> +
> + gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + vin-supply = <&vreg_l2m_1p2>;
> + };
> +
> + vreg_cam_front_right_1p8: regulator-cam-front-right-1p8 {
> + compatible = "regulator-fixed";
> + regulator-name = "cam_front_right_1p8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + gpio = <&tlmm 36 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + vin-supply = <&vreg_l5m_1p8>;
> + };
> +
> reserved-memory {
> #address-cells = <2>;
> #size-cells = <2>;
> @@ -675,6 +735,153 @@ vreg_l6n_2p8: ldo6 {
> };
> };
>
> +&camss {
> + vdd-csiphy01-0p9-supply = <&vreg_l2i_0p88>;
> + vdd-csiphy01-1p2-supply = <&vreg_l3i_1p2>;
> + vdd-csiphy24-0p9-supply = <&vreg_l2i_0p88>;
> + vdd-csiphy24-1p2-supply = <&vreg_l3i_1p2>;
> +
> + status = "okay";
> +
> + ports {
> + port@0 {
> + csiphy0_ep: endpoint {
> + data-lanes = <0 1>;
> + remote-endpoint = <&cam_front_left>;
> + };
> + };
> +
> + port@1 {
> + csiphy1_ep: endpoint {
> + data-lanes = <0 1>;
> + remote-endpoint = <&cam_front_right>;
> + };
> + };
> +
> + port@2 {
> + csiphy2_ep: endpoint {
> + data-lanes = <0>;
> + remote-endpoint = <&cam_eyetracking_left>;
> + };
> + };
> +
> + port@4 {
> + csiphy4_ep: endpoint {
> + data-lanes = <0>;
> + remote-endpoint = <&cam_eyetracking_right>;
> + };
> + };
> + };
> +};
> +
> +&cci0 {
> + status = "okay";
> +};
> +
> +&cci0_i2c1 {
> + sensor@60 {
> + compatible = "ovti,ov6211";
> + reg = <0x60>;
> + clocks = <&camcc CAM_CC_MCLK4_CLK>;
> + assigned-clocks = <&camcc CAM_CC_MCLK4_CLK>;
> + assigned-clock-rates = <24000000>;
> + pinctrl-0 = <&cam4_default>;
> + pinctrl-1 = <&cam4_sleep>;
> + pinctrl-names = "default", "sleep";
> + reset-gpios = <&tlmm 195 GPIO_ACTIVE_LOW>;
> + avdd-supply = <&vreg_l6n_2p8>;
> + dovdd-supply = <&vreg_cam_eyetracking_1p8>;
> + dvdd-supply = <&vreg_l1n_1p1>;
> +
> + port {
> + cam_eyetracking_left: endpoint {
> + link-frequencies = /bits/ 64 <480000000>;
> + remote-endpoint = <&csiphy2_ep>;
> + };
> + };
> + };
> +};
> +
> +&cci1 {
> + status = "okay";
> +};
> +
> +&cci1_i2c0 {
> + sensor@60 {
> + compatible = "ovti,ov6211";
> + reg = <0x60>;
> + clocks = <&camcc CAM_CC_MCLK2_CLK>;
> + assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>;
> + assigned-clock-rates = <24000000>;
> + pinctrl-0 = <&cam2_default>;
> + pinctrl-1 = <&cam2_sleep>;
> + pinctrl-names = "default", "sleep";
> + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> + avdd-supply = <&vreg_l6m_2p8>;
> + dovdd-supply = <&vreg_cam_eyetracking_1p8>;
> + dvdd-supply = <&vreg_l1m_1p1>;
> +
> + port {
> + cam_eyetracking_right: endpoint {
> + link-frequencies = /bits/ 64 <480000000>;
> + remote-endpoint = <&csiphy4_ep>;
> + };
> + };
> + };
> +};
> +
> +&cci2 {
> + status = "okay";
> +};
> +
> +&cci2_i2c0 {
> + sensor@36 {
> + compatible = "ovti,og01a1b";
> + reg = <0x36>;
> + clocks = <&camcc CAM_CC_MCLK0_CLK>;
> + assigned-clocks = <&camcc CAM_CC_MCLK0_CLK>;
> + assigned-clock-rates = <19200000>;
> + pinctrl-0 = <&cam0_default>;
> + pinctrl-1 = <&cam0_sleep>;
> + pinctrl-names = "default", "sleep";
> + reset-gpios = <&pm8550vs_e_gpios 4 GPIO_ACTIVE_LOW>;
> + avdd-supply = <&vreg_l3m_2p8>;
> + dovdd-supply = <&vreg_cam_front_right_1p8>;
> + dvdd-supply = <&vreg_cam_front_right_1p2>;
> +
> + port {
> + cam_front_right: endpoint {
> + data-lanes = <1 2>;
> + link-frequencies = /bits/ 64 <500000000>;
> + remote-endpoint = <&csiphy1_ep>;
> + };
> + };
> + };
> +
> + sensor@60 {
> + compatible = "ovti,og01a1b";
> + reg = <0x60>;
> + clocks = <&camcc CAM_CC_MCLK1_CLK>;
> + assigned-clocks = <&camcc CAM_CC_MCLK1_CLK>;
> + assigned-clock-rates = <19200000>;
> + pinctrl-0 = <&cam1_default>;
> + pinctrl-1 = <&cam1_sleep>;
> + pinctrl-names = "default", "sleep";
> + reset-gpios = <&pm8550vs_e_gpios 6 GPIO_ACTIVE_LOW>;
> + avdd-supply = <&vreg_l3n_2p8>;
> + dovdd-supply = <&vreg_cam_front_left_1p8>;
> + dvdd-supply = <&vreg_cam_front_left_1p2>;
> +
> + port {
> + cam_front_left: endpoint {
> + data-lanes = <1 2>;
> + link-frequencies = /bits/ 64 <500000000>;
> + remote-endpoint = <&csiphy0_ep>;
> + };
> + };
> + };
> +};
> +
> &dispcc {
> status = "disabled";
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-02 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-02 10:17 [PATCH v2] arm64: dts: qcom: sm8650-valve-deckard: Add initial support of camera sensors Vladimir Zapolskiy
2026-10-02 10:20 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox