Devicetree
 help / color / mirror / Atom feed
From: Yijie Yang <yijie.yang@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: qcom: Add Maili SoC compatible
Date: Wed, 19 Aug 2026 17:10:42 +0800	[thread overview]
Message-ID: <54ead445-4b48-4c99-8670-5357451c1827@oss.qualcomm.com> (raw)
In-Reply-To: <7e66a373-7a3b-49ee-b8b4-8577544ae0ab@oss.qualcomm.com>



On 8/19/2026 5:05 PM, Konrad Dybcio wrote:
> On 8/19/26 11:04 AM, Krzysztof Kozlowski wrote:
>> On 19/08/2026 10:56, Konrad Dybcio wrote:
>>> On 8/19/26 9:02 AM, Yijie Yang wrote:
>>>>
>>>>
>>>> On 8/19/2026 2:35 PM, Krzysztof Kozlowski wrote:
>>>>> On 19/08/2026 08:28, Yijie Yang wrote:
>>>
>>> [...]
>>>
>>>>>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>>>>> @@ -175,6 +175,9 @@ properties:
>>>>>>>>                   - qcom,kaanapali-qrd
>>>>>>>>               - const: qcom,kaanapali
>>>>>>>>     +      - items:
>>>>>>>> +          - const: qcom,maili
>>>>>>>
>>>>>>> Heh? This cannot go alone.
>>>>>>
>>>>>> Keep only the SoC compatible string and exclude the board for now, as
>>>>>> the latter is not currently used.
>>>>>> https://lore.kernel.org/all/20260622-brainy-rapid-tody-dd7c3a@quoll/
>>>>>
>>>>> No, read my message there - this should be rejected! I even wrote:
>>>>>
>>>>> "But if ever this commit is used in argument "oh, compatible without
>>>>> user was accepted here by Krzysztof, so I can do the same", I will
>>>>> simply NAK such future contribution without reading the rest."
>>>>>
>>>>> So NAK because you did not even bother to read what I already stated!
>>>>
>>>> In patch 2/2, pd-mapper serves as the user. Is there any other reason to reject this binding?
>>>
>>> This defines/allows a top-level compatible of
>>>
>>> compatible = "qcom,maili";
>>>
>>> which is missing the board part, and that is strictly required.
>>
>> Not sure if you are agreeing with me or disagreeing...
> 
> Agreeing - I'm saying that we need the board compatible to be present
> in the tuple, which the submission doesn't contain
> 
> Konrad

Okay, will hold this binding for now.

-- 
Best Regards,
Yijie


  reply	other threads:[~2026-08-19  9:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19  5:42 [PATCH v1 0/2] Add initial Maili SoC support Prasad Kumpatla
2026-08-19  5:42 ` [PATCH v1 1/2] dt-bindings: arm: qcom: Add Maili SoC compatible Prasad Kumpatla
2026-08-19  5:50   ` Jingyi Wang
2026-08-19  6:04     ` Prasad Kumpatla
2026-08-19  5:51   ` sashiko-bot
2026-08-19  6:09   ` Krzysztof Kozlowski
2026-08-19  6:28     ` Yijie Yang
2026-08-19  6:35       ` Krzysztof Kozlowski
2026-08-19  7:02         ` Yijie Yang
2026-08-19  7:12           ` Krzysztof Kozlowski
2026-08-19  8:56           ` Konrad Dybcio
2026-08-19  9:04             ` Krzysztof Kozlowski
2026-08-19  9:05               ` Konrad Dybcio
2026-08-19  9:10                 ` Yijie Yang [this message]
2026-08-19  5:42 ` [PATCH v1 2/2] soc: qcom: pd-mapper: Add support for Maili SoC Prasad Kumpatla
2026-08-19  6:11   ` Krzysztof Kozlowski
2026-08-19  5:54 ` [PATCH v1 0/2] Add initial Maili SoC support Jingyi Wang
2026-08-19  6:04   ` Prasad Kumpatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ead445-4b48-4c99-8670-5357451c1827@oss.qualcomm.com \
    --to=yijie.yang@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasad.kumpatla@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox