Re: [PATCH 2/2] arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11)

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 7/2/26 8:31 AM, Kaipeng Zeng wrote:
> Introduce device tree for the Acer Swift Go Pro AI (SFA14-11).
> It is a laptop based on the Qualcomm Snapdragon X Elite (X1E78100) SoC.
> This device tree implementation references nodes from the x1-crd.dtsi.
> 
> Supported features:
> 
>  - Internal display & Brightness control
>  - Keyboard & Touchpad
>  - USB Type-C, Type-A
>  - Wi-Fi & Bluetooth
>  - ADSP & CDSP
>  - Adreno X1-85 GPU
>  - HDMI & USB Type-C display
>  - Webcam
> 
> Signed-off-by: Kaipeng Zeng <kaipeng94@gmail.com>
> ---

[...]

> +	pmic-glink {
> +		compatible = "qcom,x1e80100-pmic-glink",
> +			     "qcom,sm8550-pmic-glink",
> +			     "qcom,pmic-glink";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
> +				    <&tlmm 123 GPIO_ACTIVE_HIGH>,
> +				    <&tlmm 125 GPIO_ACTIVE_HIGH>;
> +
> +		nvmem-cells = <&charge_limit_en>,
> +			      <&charge_limit_end>,
> +			      <&charge_limit_delta>;
> +		nvmem-cell-names = "charge_limit_en",
> +				   "charge_limit_end",
> +				   "charge_limit_delta";
> +
> +		/* have only one typec */

I think this comment is superfluous

[...]

> +	reserved-memory {
> +		linux,cma {
> +			compatible = "shared-dma-pool";
> +			size = <0x0 0x8000000>;
> +			reusable;
> +			linux,cma-default;
> +		};
> +		adsp_fastrpc_mem: fastrpc-adsp {
> +			compatible = "shared-dma-pool";
> +			reusable;
> +			size = <0x0 0x800000>;
> +		};
> +		cdsp_fastrpc_mem: fastrpc-cdsp {
> +			compatible = "shared-dma-pool";
> +			reusable;
> +			size = <0x0 0x800000>;
> +		};
> +	};

The latter two will (likely?) be assigned in the common DTSI soon, you
can drop them


> +
> +	sound {
> +		compatible = "qcom,x1e80100-sndcard";
> +		model = "X1E80100-CRD";

This must match your machine

[...]

> +	wcd938x: audio-codec {

Nodes should be sorted - by 'reg' and unit address if there's one,
by name if there isn't (minus some special cases like GPIOs), see:

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html

> +		compatible = "qcom,wcd9385-codec";


> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&wcd_default>;

property-n
property-names

in this order, file-wide, please

[...]

> +&apps_rsc {
> +	regulators-0 {
> +		compatible = "qcom,pm8550-rpmh-regulators";
> +		qcom,pmic-id = "b";

Have you verified this against the DSDT of your device? Incorrect
settings may lead to hw damage

[...]

> +&iris {
> +	status = "okay";

You need to specify a firmare path

Konrad