From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kaipeng Zeng <kaipeng94@gmail.com>, devicetree@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org, konradybcio@kernel.org,
andersson@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Acer Swift Go Pro AI (SFA14-11)
Date: Thu, 2 Jul 2026 08:27:21 +0200 [thread overview]
Message-ID: <9d9645e5-2e63-4c22-8b5f-b0f4368c581f@kernel.org> (raw)
In-Reply-To: <20260702063156.35169-2-kaipeng94@gmail.com>
On 02/07/2026 08:31, Kaipeng Zeng wrote:
> Add compatible values for the Acer Swift Go Pro AI (SFA14-11),
> using "acer,sfa14-11".
"Add Acer Swift Go Pro AI (SFA14-11), a laptop based on the Snapdragon X
Elite (X1E78100) SoC."
That's it. Don't add unnecessary boilerplate.
>
> The laptop is based on the Snapdragon X Elite (X1E78100) SoC.
>
> Signed-off-by: Kaipeng Zeng <kaipeng94@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 50cc18a6ec5e..6b997d615bad 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1142,6 +1142,7 @@ properties:
>
> - items:
> - enum:
> + - acer,sfa14-11
Why no user-recognizable name is used? Look at other consumer products:
lenovo,thinkpad-x13s, lenovo,flex-5g, microsoft,surface-prox,
lenovo,thinkpad-t14s-lcd, tuxedo,elite14gen1, microsoft,denali,
asus,vivobook-s15... and so on.
> - medion,sprchrgd14s1
> - tuxedo,elite14gen1
> - const: qcom,x1e78100
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-02 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 6:31 [PATCH 0/2] Add device tree for Acer Swift Go Pro AI (SFA14-11) Kaipeng Zeng
2026-07-02 6:31 ` [PATCH 1/2] dt-bindings: arm: qcom: Add " Kaipeng Zeng
2026-07-02 6:27 ` Krzysztof Kozlowski [this message]
2026-07-02 6:35 ` Krzysztof Kozlowski
2026-07-02 9:29 ` Konrad Dybcio
2026-07-02 9:32 ` Krzysztof Kozlowski
2026-07-02 6:31 ` [PATCH 2/2] arm64: dts: qcom: Add support for " Kaipeng Zeng
2026-07-02 6:31 ` Krzysztof Kozlowski
2026-07-02 6:40 ` sashiko-bot
2026-07-02 11:45 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9645e5-2e63-4c22-8b5f-b0f4368c581f@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kaipeng94@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox