* [PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board
@ 2016-11-30 4:27 Seung-Woo Kim
[not found] ` <1480480062-3472-1-git-send-email-sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Seung-Woo Kim @ 2016-11-30 4:27 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-arm-kernel, linux-kernel, devicetree, robh+dt, mark.rutland,
catalin.marinas, will.deacon, kgene, krzk, javier, sw0312.kim,
cw00.choi, Ingi Kim
From: Ingi Kim <ingi2.kim@samsung.com>
This patch adds Kinetic ktd2692 flash led device node for TM2 board.
Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
index f21bdc2..3ba305f 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
@@ -58,6 +58,19 @@
reg = <0x0 0x20000000 0x0 0xc0000000>;
};
+ camera-flash {
+ compatible = "kinetic,ktd2692";
+ ctrl-gpios = <&gpc0 1 0>;
+ aux-gpios = <&gpc0 2 0>;
+
+ flash-led {
+ label = "ktd2692-flash";
+ led-max-microamp = <300000>;
+ flash-max-microamp = <1500000>;
+ flash-max-timeout-us = <1835000>;
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1480480062-3472-1-git-send-email-sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board [not found] ` <1480480062-3472-1-git-send-email-sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2016-11-30 4:48 ` Seung-Woo Kim 2016-11-30 8:36 ` Chanwoo Choi 0 siblings, 1 reply; 4+ messages in thread From: Seung-Woo Kim @ 2016-11-30 4:48 UTC (permalink / raw) To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8, kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A, javier-JPH+aEBZ4P+UEJcrhfAQsw, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ, Ingi Kim From: Ingi Kim <ingi2.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> This patch adds Kinetic ktd2692 flash led device node for TM2 board. Signed-off-by: Ingi Kim <ingi2.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Signed-off-by: Seung-Woo Kim <sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> --- Change from v1: - gpio active value is set with defined macro instead of value. --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index f21bdc2..0d454aa 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -58,6 +58,19 @@ reg = <0x0 0x20000000 0x0 0xc0000000>; }; + camera-flash { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>; + aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>; + + flash-led { + label = "ktd2692-flash"; + led-max-microamp = <300000>; + flash-max-microamp = <1500000>; + flash-max-timeout-us = <1835000>; + }; + }; + gpio-keys { compatible = "gpio-keys"; -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board 2016-11-30 4:48 ` [PATCH v2] " Seung-Woo Kim @ 2016-11-30 8:36 ` Chanwoo Choi 2016-11-30 8:44 ` Seung-Woo Kim 0 siblings, 1 reply; 4+ messages in thread From: Chanwoo Choi @ 2016-11-30 8:36 UTC (permalink / raw) To: Seung-Woo Kim, linux-samsung-soc Cc: linux-arm-kernel, linux-kernel, devicetree, robh+dt, mark.rutland, catalin.marinas, will.deacon, kgene, krzk, javier, Ingi Kim Dear Seung-Woo, I think that this patch looks good to me. But, When I tested this patch on my TM2 board, the flash turn off after some millisecond automatically. It is strange situation. Unfortunately, I don't know the cause. I think that we better to check this issue for more time. Best Regards, Chanwoo Choi On 2016년 11월 30일 13:48, Seung-Woo Kim wrote: > From: Ingi Kim <ingi2.kim@samsung.com> > > This patch adds Kinetic ktd2692 flash led device node for TM2 board. > > Signed-off-by: Ingi Kim <ingi2.kim@samsung.com> > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> > --- > Change from v1: > - gpio active value is set with defined macro instead of value. > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index f21bdc2..0d454aa 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -58,6 +58,19 @@ > reg = <0x0 0x20000000 0x0 0xc0000000>; > }; > > + camera-flash { > + compatible = "kinetic,ktd2692"; > + ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>; > + aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>; > + > + flash-led { > + label = "ktd2692-flash"; > + led-max-microamp = <300000>; > + flash-max-microamp = <1500000>; > + flash-max-timeout-us = <1835000>; > + }; > + }; > + > gpio-keys { > compatible = "gpio-keys"; > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board 2016-11-30 8:36 ` Chanwoo Choi @ 2016-11-30 8:44 ` Seung-Woo Kim 0 siblings, 0 replies; 4+ messages in thread From: Seung-Woo Kim @ 2016-11-30 8:44 UTC (permalink / raw) To: Chanwoo Choi Cc: linux-samsung-soc, linux-arm-kernel, linux-kernel, devicetree, robh+dt, mark.rutland, catalin.marinas, will.deacon, kgene, krzk, javier, Ingi Kim, Seung-Woo Kim Hello Chanwoo, On 2016년 11월 30일 17:36, Chanwoo Choi wrote: > Dear Seung-Woo, > > I think that this patch looks good to me. > But, When I tested this patch on my TM2 board, > the flash turn off after some millisecond automatically. Thank you for testing on your side. I will check on my side about the issue, and if I find, then I will send next version. Regards, - Seung-Woo Kim > > It is strange situation. Unfortunately, I don't know the cause. > I think that we better to check this issue for more time. > > Best Regards, > Chanwoo Choi > > On 2016년 11월 30일 13:48, Seung-Woo Kim wrote: >> From: Ingi Kim <ingi2.kim@samsung.com> >> >> This patch adds Kinetic ktd2692 flash led device node for TM2 board. >> >> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com> >> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> >> --- >> Change from v1: >> - gpio active value is set with defined macro instead of value. >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ >> 1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index f21bdc2..0d454aa 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -58,6 +58,19 @@ >> reg = <0x0 0x20000000 0x0 0xc0000000>; >> }; >> >> + camera-flash { >> + compatible = "kinetic,ktd2692"; >> + ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>; >> + aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>; >> + >> + flash-led { >> + label = "ktd2692-flash"; >> + led-max-microamp = <300000>; >> + flash-max-microamp = <1500000>; >> + flash-max-timeout-us = <1835000>; >> + }; >> + }; >> + >> gpio-keys { >> compatible = "gpio-keys"; >> >> > > -- Seung-Woo Kim Samsung Software R&D Center -- ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-30 8:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 4:27 [PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim
[not found] ` <1480480062-3472-1-git-send-email-sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-11-30 4:48 ` [PATCH v2] " Seung-Woo Kim
2016-11-30 8:36 ` Chanwoo Choi
2016-11-30 8:44 ` Seung-Woo Kim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox