public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add TRNG support for Glymur SoC
@ 2026-04-24  8:35 Harshal Dev
  2026-04-24  8:35 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: Document Glymur TRNG Harshal Dev
  2026-04-24  8:35 ` [PATCH v2 2/2] arm64: dts: qcom: glymur: add TRNG node Harshal Dev
  0 siblings, 2 replies; 5+ messages in thread
From: Harshal Dev @ 2026-04-24  8:35 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Bjorn Andersson, Konrad Dybcio,
	Dmitry Baryshkov
  Cc: Kuldeep Singh, linux-arm-msm, linux-crypto, devicetree,
	linux-kernel, Harshal Dev, Krzysztof Kozlowski, Konrad Dybcio

Document and add the device-tree node to enable TRNG for Glymur SoC.

Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
Changes in v2:
- Padded the address part to 8 hex digits with leading zeroes.
- Collected Reviewed-by tags from Konrad and Krzysztof.
- Link to v1: https://lore.kernel.org/r/20260416-glymur_trng_enablement-v1-0-60abcfd45403@oss.qualcomm.com

---
Harshal Dev (2):
      dt-bindings: crypto: qcom,prng: Document Glymur TRNG
      arm64: dts: qcom: glymur: add TRNG node

 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
 arch/arm64/boot/dts/qcom/glymur.dtsi                    | 5 +++++
 2 files changed, 6 insertions(+)
---
base-commit: 936c21068d7ade00325e40d82bfd2f3f29d9f659
change-id: 20260416-glymur_trng_enablement-31518b69fbca

Best regards,
-- 
Harshal Dev <harshal.dev@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: Document Glymur TRNG
  2026-04-24  8:35 [PATCH v2 0/2] Add TRNG support for Glymur SoC Harshal Dev
@ 2026-04-24  8:35 ` Harshal Dev
  2026-05-05  9:25   ` Herbert Xu
  2026-04-24  8:35 ` [PATCH v2 2/2] arm64: dts: qcom: glymur: add TRNG node Harshal Dev
  1 sibling, 1 reply; 5+ messages in thread
From: Harshal Dev @ 2026-04-24  8:35 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Bjorn Andersson, Konrad Dybcio,
	Dmitry Baryshkov
  Cc: Kuldeep Singh, linux-arm-msm, linux-crypto, devicetree,
	linux-kernel, Harshal Dev, Krzysztof Kozlowski

Document glymur compatible for the True Random Number Generator.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 41402599e9ab..498d6914135e 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -17,6 +17,7 @@ properties:
           - qcom,prng-ee  # 8996 and later using EE
       - items:
           - enum:
+              - qcom,glymur-trng
               - qcom,ipq5332-trng
               - qcom,ipq5424-trng
               - qcom,ipq9574-trng

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] arm64: dts: qcom: glymur: add TRNG node
  2026-04-24  8:35 [PATCH v2 0/2] Add TRNG support for Glymur SoC Harshal Dev
  2026-04-24  8:35 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: Document Glymur TRNG Harshal Dev
@ 2026-04-24  8:35 ` Harshal Dev
  2026-05-06  9:32   ` Kuldeep Singh
  1 sibling, 1 reply; 5+ messages in thread
From: Harshal Dev @ 2026-04-24  8:35 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Bjorn Andersson, Konrad Dybcio,
	Dmitry Baryshkov
  Cc: Kuldeep Singh, linux-arm-msm, linux-crypto, devicetree,
	linux-kernel, Harshal Dev, Konrad Dybcio

Glymur has a True Random Number Generator, add the node with the correct
compatible set.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index f23cf81ddb77..64bbd5691229 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -3675,6 +3675,11 @@ pcie3b_phy: phy@f10000 {
 			status = "disabled";
 		};
 
+		rng: rng@10c3000 {
+			compatible = "qcom,glymur-trng", "qcom,trng";
+			reg = <0x0 0x010c3000 0x0 0x1000>;
+		};
+
 		tcsr_mutex: hwlock@1f40000 {
 			compatible = "qcom,tcsr-mutex";
 			reg = <0x0 0x01f40000 0x0 0x20000>;

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: Document Glymur TRNG
  2026-04-24  8:35 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: Document Glymur TRNG Harshal Dev
@ 2026-05-05  9:25   ` Herbert Xu
  0 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2026-05-05  9:25 UTC (permalink / raw)
  To: Harshal Dev
  Cc: David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Vinod Koul, Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
	Kuldeep Singh, linux-arm-msm, linux-crypto, devicetree,
	linux-kernel, Krzysztof Kozlowski

On Fri, Apr 24, 2026 at 02:05:07PM +0530, Harshal Dev wrote:
> Document glymur compatible for the True Random Number Generator.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: qcom: glymur: add TRNG node
  2026-04-24  8:35 ` [PATCH v2 2/2] arm64: dts: qcom: glymur: add TRNG node Harshal Dev
@ 2026-05-06  9:32   ` Kuldeep Singh
  0 siblings, 0 replies; 5+ messages in thread
From: Kuldeep Singh @ 2026-05-06  9:32 UTC (permalink / raw)
  To: Harshal Dev, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Bjorn Andersson,
	Konrad Dybcio, Dmitry Baryshkov
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
	Konrad Dybcio

On 24-04-2026 14:05, Harshal Dev wrote:
> Glymur has a True Random Number Generator, add the node with the correct
> compatible set.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>

Tested-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>

root@qcom-armv8a:~# cat /sys/class/misc/hw_random/rng_current
qcom_hwrng
root@qcom-armv8a:~# cat /dev/random | rngtest -c 1000
rngtest 6.16
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions.  There is
NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

rngtest: starting FIPS tests...
rngtest: bits received from input: 20000032
rngtest: FIPS 140-2 successes: 1000
rngtest: FIPS 140-2 failures: 0
rngtest: FIPS 140-2(2001-10-10) Monobit: 0
rngtest: FIPS 140-2(2001-10-10) Poker: 0
rngtest: FIPS 140-2(2001-10-10) Runs: 0
rngtest: FIPS 140-2(2001-10-10) Long run: 0
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=1666666666.667; avg=54945054945.055;
max=0.000)bits/s
rngtest: FIPS tests speed: (min=186.995; avg=280.435; max=334.623)Mibits/s
rngtest: Program run time: 68912 microseconds
root@qcom-armv8a:~#

-- 
Regards
Kuldeep

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-06  9:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-24  8:35 [PATCH v2 0/2] Add TRNG support for Glymur SoC Harshal Dev
2026-04-24  8:35 ` [PATCH v2 1/2] dt-bindings: crypto: qcom,prng: Document Glymur TRNG Harshal Dev
2026-05-05  9:25   ` Herbert Xu
2026-04-24  8:35 ` [PATCH v2 2/2] arm64: dts: qcom: glymur: add TRNG node Harshal Dev
2026-05-06  9:32   ` Kuldeep Singh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox