[PATCH 0/4] Dongwoon DW9714 - correct vcc/vdd supply voltage

[PATCH 0/4] Dongwoon DW9714 - correct vcc/vdd supply voltage

[David Heidelberg via B4 Relay]

So much mess, as people defines 1.8V i2c level shifters instead of VDD.

I don't pocess any of these devices, so please test carefully,
you may need to in addition to this change put regulator-always-on to
the 1.8V which was previously abused instead of VDD. Careful about
combination when camera which pulls in 1.8V (usually iovdd) as a byproduct
takes care of i2c supply for the coil.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
David Heidelberg (4):
      media: dt-bindings: dongwoon,dw9714: Example shouldn't imply 1.8 V
      arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage
      arm64: dts: rockchip: rk3566-pinetab2: DW9714 coil requires higher voltage
      arm64: dts: imx8mq-librem5: Dongwoon DW9714 coil requires higher voltage

 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml | 4 ++--
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi                | 2 +-
 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts            | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi                | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
---
base-commit: 95d6a9ccef99117115e41e9adb271243bd5e985b
change-id: 20260801-pp-pro-camera-a14d1af483cd

Best regards,
--  
David Heidelberg <david@ixit.cz>

[PATCH 1/4] media: dt-bindings: dongwoon,dw9714: Example shouldn't imply 1.8 V

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

The datasheet says VDD should be between 2.3 to 4.3V, usually around
2.8V. Correct to prevent confusion and extend description.

Fixes: 2a96b40f366a ("media: dt-bindings: dongwoon,dw9714: convert to dtschema")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
index 66229a3dc05d6..7f5aa098351dc 100644
--- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
@@ -20,28 +20,28 @@ properties:
   reg:
     maxItems: 1
 
   powerdown-gpios:
     description:
       XSD pin for shutdown (active low)
 
   vcc-supply:
-    description: VDD power supply
+    description: VDD power supply (2.3 to 4.3V)
 
 required:
   - compatible
   - reg
 
 additionalProperties: false
 
 examples:
   - |
     i2c {
         #address-cells = <1>;
         #size-cells = <0>;
 
         camera-lens@c {
             compatible = "dongwoon,dw9714";
             reg = <0x0c>;
-            vcc-supply = <&reg_csi_1v8>;
+            vcc-supply = <&reg_vcm_2v8>;
         };
     };

-- 
2.53.0

[PATCH 2/4] arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
Usually it's around 2.8 V. Here it matches the avdd2v8_dvp.

Fixes: 9336eb829a18 ("arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro")
Cc: stable@vger.kernel.org
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index d46cdfe3f7849..bde35d9b2263e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -473,17 +473,17 @@ wcam_out: endpoint {
 			};
 		};
 	};
 
 	wcam_lens: camera-lens@c {
 		compatible = "dongwoon,dw9714";
 		reg = <0x0c>;
 		/* Same I2c bus as both cameras, depends on vcca1v8_codec for power. */
-		vcc-supply = <&vcc1v8_dvp>;
+		vcc-supply = <&avdd2v8_dvp>;
 	};
 
 	ucam: camera@36 {
 		compatible = "ovti,ov8858";
 		reg = <0x36>;
 		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from CIF_CLK0 */
 		clock-names = "xvclk";
 		dovdd-supply = <&vcc1v8_dvp>;

-- 
2.53.0

[PATCH 3/4] arm64: dts: rockchip: rk3566-pinetab2: DW9714 coil requires higher voltage

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
Usually it's around 2.8 V. Here it matches the vcc2v8_dvp.

1.8 V here is likely used for i2c level shifter.

Fixes: 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64 PineTab2")
Cc: stable@vger.kernel.org
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index 08bf40de17ead..96511f1bb51d6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -581,17 +581,17 @@ touchscreen@5d {
 &i2c2 {
 	clock-frequency = <400000>;
 	pinctrl-0 = <&i2c2m1_xfer>;
 	status = "okay";
 
 	vcm@c {
 		compatible = "dongwoon,dw9714";
 		reg = <0x0c>;
-		vcc-supply = <&vcc1v8_dvp>;
+		vcc-supply = <&vcc2v8_dvp>;
 	};
 
 	camera@36 {
 		compatible = "ovti,ov5648";
 		reg = <0x36>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&camerab_pdn_l &camerab_rst_l>;
 

-- 
2.53.0

[PATCH 4/4] arm64: dts: imx8mq-librem5: Dongwoon DW9714 coil requires higher voltage

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
Usually it's around 2.8 V. Here it matches the reg_vcam_2v8.

1.8 V here is likely used for i2c level shifter.

Fixes: f00df2bdb512 ("arm64: dts: imx8mq-librem5: describe the voice coil motor for focus control")
Cc: stable@vger.kernel.org
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index f5d529c5baf3e..583cba2d3bebf 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1167,17 +1167,17 @@ &i2c4 {
 	pinctrl-1 = <&pinctrl_i2c4_gpio>;
 	scl-gpios = <&gpio5 20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 	sda-gpios = <&gpio5 21 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 	status = "okay";
 
 	vcm@c {
 		compatible = "dongwoon,dw9714";
 		reg = <0x0c>;
-		vcc-supply = <&reg_csi_1v8>;
+		vcc-supply = <&reg_vcam_2v8>;
 	};
 
 	bat: fuel-gauge@36 {
 		compatible = "maxim,max17055";
 		reg = <0x36>;
 		interrupt-parent = <&gpio3>;
 		interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";

-- 
2.53.0

Re: [PATCH 4/4] arm64: dts: imx8mq-librem5: Dongwoon DW9714 coil requires higher voltage

[Sebastian Krzyszkowiak]

On sobota, 1 sierpnia 2026 02:35:23 czas środkowoeuropejski letni David 
Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
> Usually it's around 2.8 V. Here it matches the reg_vcam_2v8.

It doesn't - VCAM_2V8 isn't connected to DW9714 (and neither is CSI_1V8); 
VCAM_AFVDD is.

> 1.8 V here is likely used for i2c level shifter.

I'm not sure where you've got an I2C level shifter from, there's none involved 
there. CSI_1V8 is passed to the rear camera module as DOVDD and is consumed by 
S5K3L6 as VDDIO, and both S5K3L6 and DW9714 are connected to I2C4_SDA/
I2C4_SCL, operating at the 1.8V level, only though an EMI filter (F7 in the 
schematic).

> 
> Fixes: f00df2bdb512 ("arm64: dts: imx8mq-librem5: describe the voice coil
> motor for focus control") Cc: stable@vger.kernel.org
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi index
> f5d529c5baf3e..583cba2d3bebf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -1167,17 +1167,17 @@ &i2c4 {
>  	pinctrl-1 = <&pinctrl_i2c4_gpio>;
>  	scl-gpios = <&gpio5 20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  	sda-gpios = <&gpio5 21 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  	status = "okay";
> 
>  	vcm@c {
>  		compatible = "dongwoon,dw9714";
>  		reg = <0x0c>;
> -		vcc-supply = <&reg_csi_1v8>;
> +		vcc-supply = <&reg_vcam_2v8>;
>  	};
> 
>  	bat: fuel-gauge@36 {
>  		compatible = "maxim,max17055";
>  		reg = <0x36>;
>  		interrupt-parent = <&gpio3>;
>  		interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";

Re: [PATCH 4/4] arm64: dts: imx8mq-librem5: Dongwoon DW9714 coil requires higher voltage

[David Heidelberg]

On 03/08/2026 20:12, Sebastian Krzyszkowiak wrote:
> On sobota, 1 sierpnia 2026 02:35:23 czas środkowoeuropejski letni David
> Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
>> Usually it's around 2.8 V. Here it matches the reg_vcam_2v8.
> 
> It doesn't - VCAM_2V8 isn't connected to DW9714 (and neither is CSI_1V8);
> VCAM_AFVDD is.

I didn't realized we have datasheet here :)

> 
>> 1.8 V here is likely used for i2c level shifter.
> 
> I'm not sure where you've got an I2C level shifter from, there's none involved

it's copy-paste from previous commits.

> there. CSI_1V8 is passed to the rear camera module as DOVDD and is consumed by
> S5K3L6 as VDDIO, and both S5K3L6 and DW9714 are connected to I2C4_SDA/
> I2C4_SCL, operating at the 1.8V level, only though an EMI filter (F7 in the
> schematic).

I don't see the AFVDD in the [1], do you have it somewhere defined?

Thanks
David

[1] 
https://source.puri.sm/Librem5/linux/-/tree/pureos/latest/arch/arm64/boot/dts/freescale?ref_type=heads

> 
>>
>> Fixes: f00df2bdb512 ("arm64: dts: imx8mq-librem5: describe the voice coil
>> motor for focus control") Cc: stable@vger.kernel.org
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi index
>> f5d529c5baf3e..583cba2d3bebf 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> @@ -1167,17 +1167,17 @@ &i2c4 {
>>   	pinctrl-1 = <&pinctrl_i2c4_gpio>;
>>   	scl-gpios = <&gpio5 20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>>   	sda-gpios = <&gpio5 21 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>>   	status = "okay";
>>
>>   	vcm@c {
>>   		compatible = "dongwoon,dw9714";
>>   		reg = <0x0c>;
>> -		vcc-supply = <&reg_csi_1v8>;
>> +		vcc-supply = <&reg_vcam_2v8>;
>>   	};
>>
>>   	bat: fuel-gauge@36 {
>>   		compatible = "maxim,max17055";
>>   		reg = <0x36>;
>>   		interrupt-parent = <&gpio3>;
>>   		interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
>>   		pinctrl-names = "default";
> 
> 
> 
> 

-- 
David Heidelberg

Re: [PATCH 2/4] arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage

[Ondřej Jirman]

Hi,

On Sat, Aug 01, 2026 at 02:35:21AM +0200, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
> Usually it's around 2.8 V. Here it matches the avdd2v8_dvp.
> 
> Fixes: 9336eb829a18 ("arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro")
> Cc: stable@vger.kernel.org
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index d46cdfe3f7849..bde35d9b2263e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -473,17 +473,17 @@ wcam_out: endpoint {
>  			};
>  		};
>  	};
>  
>  	wcam_lens: camera-lens@c {
>  		compatible = "dongwoon,dw9714";
>  		reg = <0x0c>;
>  		/* Same I2c bus as both cameras, depends on vcca1v8_codec for power. */
> -		vcc-supply = <&vcc1v8_dvp>;
> +		vcc-supply = <&avdd2v8_dvp>;

This does not match reality, schematic says it's VCC2V8_DVP:

	https://xff.cz/dl/tmp/6253a0465329df41.png

regards,
	o.

>  	};
>  
>  	ucam: camera@36 {
>  		compatible = "ovti,ov8858";
>  		reg = <0x36>;
>  		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from CIF_CLK0 */
>  		clock-names = "xvclk";
>  		dovdd-supply = <&vcc1v8_dvp>;
> 
> -- 
> 2.53.0
> 
> 

Re: [PATCH 2/4] arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage

[David Heidelberg]

On 04/08/2026 09:39, Ondřej Jirman wrote:
> Hi,
> 
> On Sat, Aug 01, 2026 at 02:35:21AM +0200, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
>> Usually it's around 2.8 V. Here it matches the avdd2v8_dvp.
>>
>> Fixes: 9336eb829a18 ("arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> index d46cdfe3f7849..bde35d9b2263e 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> @@ -473,17 +473,17 @@ wcam_out: endpoint {
>>   			};
>>   		};
>>   	};
>>   
>>   	wcam_lens: camera-lens@c {
>>   		compatible = "dongwoon,dw9714";
>>   		reg = <0x0c>;
>>   		/* Same I2c bus as both cameras, depends on vcca1v8_codec for power. */
>> -		vcc-supply = <&vcc1v8_dvp>;
>> +		vcc-supply = <&avdd2v8_dvp>;
> 
> This does not match reality, schematic says it's VCC2V8_DVP:
> 
> 	https://xff.cz/dl/tmp/6253a0465329df41.png

Ahoj,

thanks for spotting this, since I know you have the device, would be too much to 
ask you to send standalone fix for PP Pro?

I would drop the change from the series.

David

P.S. I noticed I didn't mark this series RFC. Too late.

> 
> regards,
> 	o.
> 
>>   	};
>>   
>>   	ucam: camera@36 {
>>   		compatible = "ovti,ov8858";
>>   		reg = <0x36>;
>>   		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from CIF_CLK0 */
>>   		clock-names = "xvclk";
>>   		dovdd-supply = <&vcc1v8_dvp>;
>>
>> -- 
>> 2.53.0
>>
>>

-- 
David Heidelberg

Re: [PATCH 2/4] arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage

[Ondřej Jirman]

Hi,

On Tue, Aug 04, 2026 at 11:12:21AM +0200, David Heidelberg wrote:
> On 04/08/2026 09:39, Ondřej Jirman wrote:
> > Hi,
> > 
> > On Sat, Aug 01, 2026 at 02:35:21AM +0200, David Heidelberg via B4 Relay wrote:
> > > From: David Heidelberg <david@ixit.cz>
> > > 
> > > By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
> > > Usually it's around 2.8 V. Here it matches the avdd2v8_dvp.
> > > 
> > > Fixes: 9336eb829a18 ("arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > >   arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> > > index d46cdfe3f7849..bde35d9b2263e 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> > > @@ -473,17 +473,17 @@ wcam_out: endpoint {
> > >   			};
> > >   		};
> > >   	};
> > >   	wcam_lens: camera-lens@c {
> > >   		compatible = "dongwoon,dw9714";
> > >   		reg = <0x0c>;
> > >   		/* Same I2c bus as both cameras, depends on vcca1v8_codec for power. */
> > > -		vcc-supply = <&vcc1v8_dvp>;
> > > +		vcc-supply = <&avdd2v8_dvp>;
> > 
> > This does not match reality, schematic says it's VCC2V8_DVP:
> > 
> > 	https://xff.cz/dl/tmp/6253a0465329df41.png
> 
> Ahoj,
> 
> thanks for spotting this, since I know you have the device, would be too
> much to ask you to send standalone fix for PP Pro?
> 
> I would drop the change from the series.

Ok. Just for the reference, vcc1v8_dvp here feeds an enable pin for VCC2V8_DVP
LDO regulator (which is supplied from VCC3V3_SYS and not described in DT, yet).
So in practice enabling vcc1v8_dvp enables both VCC2V8_DVP and AVDD2V8_DVP and
while DT does not describe the HW in detail, it describes the only regulator
that is actually controllable and enables all needed power rails for the camera
modules all by itself in proper order/timing.

Not sure what's the DT maintainers idea here about whether DT has to describe
every detail of power rails routing, or just what's pragmatic.

Best regards,
	o.j.

> David
> 
> P.S. I noticed I didn't mark this series RFC. Too late.
> 
> > 
> > regards,
> > 	o.
> > 
> > >   	};
> > >   	ucam: camera@36 {
> > >   		compatible = "ovti,ov8858";
> > >   		reg = <0x36>;
> > >   		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from CIF_CLK0 */
> > >   		clock-names = "xvclk";
> > >   		dovdd-supply = <&vcc1v8_dvp>;
> > > 
> > > -- 
> > > 2.53.0
> > > 
> > > 
> 
> -- 
> David Heidelberg
> 

Re: [PATCH 2/4] arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage

[David Heidelberg]

On 06/08/2026 13:19, Ondřej Jirman wrote:
> Hi,
> 
> On Tue, Aug 04, 2026 at 11:12:21AM +0200, David Heidelberg wrote:
>> On 04/08/2026 09:39, Ondřej Jirman wrote:
>>> Hi,
>>>
>>> On Sat, Aug 01, 2026 at 02:35:21AM +0200, David Heidelberg via B4 Relay wrote:
>>>> From: David Heidelberg <david@ixit.cz>
>>>>
>>>> By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
>>>> Usually it's around 2.8 V. Here it matches the avdd2v8_dvp.
>>>>
>>>> Fixes: 9336eb829a18 ("arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro")
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>>> ---
>>>>    arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>>>> index d46cdfe3f7849..bde35d9b2263e 100644
>>>> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>>>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>>>> @@ -473,17 +473,17 @@ wcam_out: endpoint {
>>>>    			};
>>>>    		};
>>>>    	};
>>>>    	wcam_lens: camera-lens@c {
>>>>    		compatible = "dongwoon,dw9714";
>>>>    		reg = <0x0c>;
>>>>    		/* Same I2c bus as both cameras, depends on vcca1v8_codec for power. */
>>>> -		vcc-supply = <&vcc1v8_dvp>;
>>>> +		vcc-supply = <&avdd2v8_dvp>;
>>>
>>> This does not match reality, schematic says it's VCC2V8_DVP:
>>>
>>> 	https://xff.cz/dl/tmp/6253a0465329df41.png
>>
>> Ahoj,
>>
>> thanks for spotting this, since I know you have the device, would be too
>> much to ask you to send standalone fix for PP Pro?
>>
>> I would drop the change from the series.
> 
> Ok. Just for the reference, vcc1v8_dvp here feeds an enable pin for VCC2V8_DVP
> LDO regulator (which is supplied from VCC3V3_SYS and not described in DT, yet).
> So in practice enabling vcc1v8_dvp enables both VCC2V8_DVP and AVDD2V8_DVP and
> while DT does not describe the HW in detail, it describes the only regulator
> that is actually controllable and enables all needed power rails for the camera
> modules all by itself in proper order/timing.
> 
> Not sure what's the DT maintainers idea here about whether DT has to describe
> every detail of power rails routing, or just what's pragmatic.

My perception is that DT syntax should describe everything, except passive 
components.

No additional GPIO is needed to enable VCC and AVDD?

Here, it seems to me that explanation like this in DT could cover it. But I'm no 
authority here :)

David

> 
> Best regards,
> 	o.j.
> 
>> David
>>
>> P.S. I noticed I didn't mark this series RFC. Too late.
>>
>>>
>>> regards,
>>> 	o.
>>>
>>>>    	};
>>>>    	ucam: camera@36 {
>>>>    		compatible = "ovti,ov8858";
>>>>    		reg = <0x36>;
>>>>    		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from CIF_CLK0 */
>>>>    		clock-names = "xvclk";
>>>>    		dovdd-supply = <&vcc1v8_dvp>;
>>>>
>>>> -- 
>>>> 2.53.0
>>>>
>>>>
>>
>> -- 
>> David Heidelberg
>>

-- 
David Heidelberg

Re: [PATCH 2/4] arm64: dts: rockchip: rk3399-pinephone-pro: DW9714 coil requires higher voltage

[Ondřej Jirman]

On Thu, Aug 06, 2026 at 01:49:07PM +0200, David Heidelberg wrote:
> On 06/08/2026 13:19, Ondřej Jirman wrote:
> > Hi,
> > 
> > On Tue, Aug 04, 2026 at 11:12:21AM +0200, David Heidelberg wrote:
> > > On 04/08/2026 09:39, Ondřej Jirman wrote:
> > > > Hi,
> > > > 
> > > > On Sat, Aug 01, 2026 at 02:35:21AM +0200, David Heidelberg via B4 Relay wrote:
> > > > > From: David Heidelberg <david@ixit.cz>
> > > > > 
> > > > > By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
> > > > > Usually it's around 2.8 V. Here it matches the avdd2v8_dvp.
> > > > > 
> > > > > Fixes: 9336eb829a18 ("arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro")
> > > > > Cc: stable@vger.kernel.org
> > > > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > > > ---
> > > > >    arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
> > > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> > > > > index d46cdfe3f7849..bde35d9b2263e 100644
> > > > > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> > > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> > > > > @@ -473,17 +473,17 @@ wcam_out: endpoint {
> > > > >    			};
> > > > >    		};
> > > > >    	};
> > > > >    	wcam_lens: camera-lens@c {
> > > > >    		compatible = "dongwoon,dw9714";
> > > > >    		reg = <0x0c>;
> > > > >    		/* Same I2c bus as both cameras, depends on vcca1v8_codec for power. */
> > > > > -		vcc-supply = <&vcc1v8_dvp>;
> > > > > +		vcc-supply = <&avdd2v8_dvp>;
> > > > 
> > > > This does not match reality, schematic says it's VCC2V8_DVP:
> > > > 
> > > > 	https://xff.cz/dl/tmp/6253a0465329df41.png
> > > 
> > > Ahoj,
> > > 
> > > thanks for spotting this, since I know you have the device, would be too
> > > much to ask you to send standalone fix for PP Pro?
> > > 
> > > I would drop the change from the series.
> > 
> > Ok. Just for the reference, vcc1v8_dvp here feeds an enable pin for VCC2V8_DVP
> > LDO regulator (which is supplied from VCC3V3_SYS and not described in DT, yet).
> > So in practice enabling vcc1v8_dvp enables both VCC2V8_DVP and AVDD2V8_DVP and
> > while DT does not describe the HW in detail, it describes the only regulator
> > that is actually controllable and enables all needed power rails for the camera
> > modules all by itself in proper order/timing.
> > 
> > Not sure what's the DT maintainers idea here about whether DT has to describe
> > every detail of power rails routing, or just what's pragmatic.
> 
> My perception is that DT syntax should describe everything, except passive
> components.
> 
> No additional GPIO is needed to enable VCC and AVDD?

Yes, it's completely transparent. vcc1v8_dvp indirectly powers up all other
camera sensor regulators.

Regards,
	o.j.

> Here, it seems to me that explanation like this in DT could cover it. But
> I'm no authority here :)
> 
> David
> 
> > 
> > Best regards,
> > 	o.j.
> > 
> > > David
> > > 
> > > P.S. I noticed I didn't mark this series RFC. Too late.
> > > 
> > > > 
> > > > regards,
> > > > 	o.
> > > > 
> > > > >    	};
> > > > >    	ucam: camera@36 {
> > > > >    		compatible = "ovti,ov8858";
> > > > >    		reg = <0x36>;
> > > > >    		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from CIF_CLK0 */
> > > > >    		clock-names = "xvclk";
> > > > >    		dovdd-supply = <&vcc1v8_dvp>;
> > > > > 
> > > > > -- 
> > > > > 2.53.0
> > > > > 
> > > > > 
> > > 
> > > -- 
> > > David Heidelberg
> > > 
> 
> -- 
> David Heidelberg
>