Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default
@ 2026-07-09  9:12 Abel Vesa
  2026-07-09 13:08 ` Konrad Dybcio
  2026-07-09 19:32 ` Bjorn Andersson
  0 siblings, 2 replies; 5+ messages in thread
From: Abel Vesa @ 2026-07-09  9:12 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel, Abel Vesa

Since each serial engine will be enabled as needed in each board dts,
there is no point of disabling the first QUPv3 wrapper in SoC dtsi.

So enable it by default. This is also now in line with the other SoCs, and
also with the second QUPv3 wrapper.

Fixes: 844807e1f89d ("arm64: dts: qcom: eliza: Add QUPv3, GPI DMA, SDHCI and LLCC nodes")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 977de44b816e..8821d224a213 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -1232,8 +1232,6 @@ qupv3_1: geniqup@ac0000 {
 			#size-cells = <2>;
 			ranges;
 
-			status = "disabled";
-
 			i2c0: i2c@a80000 {
 				compatible = "qcom,geni-i2c";
 				reg = <0x0 0x00a80000 0x0 0x4000>;

---
base-commit: b9810cd75b9fb56a3425d391cba3f608502bd474
change-id: 20260709-dts-qcom-eliza-enable-qupv3-1st-fb30cdebab92

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default
  2026-07-09  9:12 [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default Abel Vesa
@ 2026-07-09 13:08 ` Konrad Dybcio
  2026-07-09 14:07   ` Abel Vesa
  2026-07-09 19:32 ` Bjorn Andersson
  1 sibling, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2026-07-09 13:08 UTC (permalink / raw)
  To: Abel Vesa, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Dmitry Baryshkov
  Cc: linux-arm-msm, devicetree, linux-kernel

On 7/9/26 11:12 AM, Abel Vesa wrote:
> Since each serial engine will be enabled as needed in each board dts,
> there is no point of disabling the first QUPv3 wrapper in SoC dtsi.
> 
> So enable it by default. This is also now in line with the other SoCs, and
> also with the second QUPv3 wrapper.
> 
> Fixes: 844807e1f89d ("arm64: dts: qcom: eliza: Add QUPv3, GPI DMA, SDHCI and LLCC nodes")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---

Go ahead and enable both QUP wrappers and both DMA controllers,
a subset of both is assigned to HLOS by default by the tz config

Konrad

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default
  2026-07-09 13:08 ` Konrad Dybcio
@ 2026-07-09 14:07   ` Abel Vesa
  2026-07-09 15:31     ` Konrad Dybcio
  0 siblings, 1 reply; 5+ messages in thread
From: Abel Vesa @ 2026-07-09 14:07 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov, linux-arm-msm, devicetree,
	linux-kernel

On 26-07-09 15:08:09, Konrad Dybcio wrote:
> On 7/9/26 11:12 AM, Abel Vesa wrote:
> > Since each serial engine will be enabled as needed in each board dts,
> > there is no point of disabling the first QUPv3 wrapper in SoC dtsi.
> > 
> > So enable it by default. This is also now in line with the other SoCs, and
> > also with the second QUPv3 wrapper.
> > 
> > Fixes: 844807e1f89d ("arm64: dts: qcom: eliza: Add QUPv3, GPI DMA, SDHCI and LLCC nodes")
> > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > ---
> 
> Go ahead and enable both QUP wrappers and both DMA controllers,
> a subset of both is assigned to HLOS by default by the tz config

But the other QUP and both DMA controllers are already enabled by
default.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default
  2026-07-09 14:07   ` Abel Vesa
@ 2026-07-09 15:31     ` Konrad Dybcio
  0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-07-09 15:31 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov, linux-arm-msm, devicetree,
	linux-kernel

On 7/9/26 4:07 PM, Abel Vesa wrote:
> On 26-07-09 15:08:09, Konrad Dybcio wrote:
>> On 7/9/26 11:12 AM, Abel Vesa wrote:
>>> Since each serial engine will be enabled as needed in each board dts,
>>> there is no point of disabling the first QUPv3 wrapper in SoC dtsi.
>>>
>>> So enable it by default. This is also now in line with the other SoCs, and
>>> also with the second QUPv3 wrapper.
>>>
>>> Fixes: 844807e1f89d ("arm64: dts: qcom: eliza: Add QUPv3, GPI DMA, SDHCI and LLCC nodes")
>>> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
>>> ---
>>
>> Go ahead and enable both QUP wrappers and both DMA controllers,
>> a subset of both is assigned to HLOS by default by the tz config
> 
> But the other QUP and both DMA controllers are already enabled by
> default.

OK good, thanks

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default
  2026-07-09  9:12 [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default Abel Vesa
  2026-07-09 13:08 ` Konrad Dybcio
@ 2026-07-09 19:32 ` Bjorn Andersson
  1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-07-09 19:32 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Dmitry Baryshkov, Abel Vesa
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel


On Thu, 09 Jul 2026 12:12:11 +0300, Abel Vesa wrote:
> Since each serial engine will be enabled as needed in each board dts,
> there is no point of disabling the first QUPv3 wrapper in SoC dtsi.
> 
> So enable it by default. This is also now in line with the other SoCs, and
> also with the second QUPv3 wrapper.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default
      commit: 2b36a8327827a80523fc4ac08cb80b42765fca55

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-07-09 19:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-09  9:12 [PATCH] arm64: dts: qcom: eliza: Enable first QUPv3 wrapper by default Abel Vesa
2026-07-09 13:08 ` Konrad Dybcio
2026-07-09 14:07   ` Abel Vesa
2026-07-09 15:31     ` Konrad Dybcio
2026-07-09 19:32 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox