From: Stephen Boyd <swboyd@chromium.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Brian Masney <masneyb@onstation.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 09/15] arm64: dts: msm8996: thermal: Add interrupt support
Date: Fri, 20 Sep 2019 16:19:52 -0700 [thread overview]
Message-ID: <5d855e99.1c69fb81.1d457.733b@mx.google.com> (raw)
In-Reply-To: <CAHLCerNqsf1j4vsOPjdav8+UtXtGP55k6_==jjg1QeZ1qCX1RA@mail.gmail.com>
Quoting Amit Kucheria (2019-09-20 15:14:58)
> On Fri, Sep 20, 2019 at 3:09 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > Ok so the plan is to change DT and then change it back? That sounds
> > quite bad so please fix the thermal core to not care about this before
> > applying these changes so that we don't churn DT.
>
> Hi Stephen,
>
> Our emails crossed paths. I think we could just make the property
> optional so that we can remove the property completely for drivers
> that support interrupts. Comments?
OK. This means that the delay properties become irrelevant once an
interrupt is there? I guess that's OK. My concern is that we need to
choose one or the other when it would be simpler to have both and
fallback to the delays so that DT migration strategies are purely
additive. It's not like the delays aren't calculated to be those numbers
anymore. They're just not going to be used.
>
> That is a bigger change to the bindings and I don't want to hold the
> tsens interrupt support hostage to agreement on this.
Alright. I admit I haven't looked into the details but is it hard for
some reason to make it use interrupts before delays?
next prev parent reply other threads:[~2019-09-20 23:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 21:52 [PATCH v4 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema Amit Kucheria
2019-09-27 16:29 ` Rob Herring
2019-09-20 21:52 ` [PATCH v4 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 09/15] arm64: dts: msm8996: " Amit Kucheria
2019-09-20 22:02 ` Stephen Boyd
2019-09-20 22:07 ` Amit Kucheria
2019-09-20 22:09 ` Stephen Boyd
2019-09-20 22:14 ` Amit Kucheria
2019-09-20 23:19 ` Stephen Boyd [this message]
2019-09-20 22:09 ` Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 10/15] arm64: dts: msm8998: " Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 11/15] arm64: dts: qcs404: " Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 12/15] arm: dts: msm8974: " Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 13/15] arm64: dts: msm8916: " Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d855e99.1c69fb81.1d457.733b@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox