Re: [PATCH v6 0/2] Pinefeat cef168 lens control board driver

[Alen Karnil <alen.karnil@ideasonboard.com>]

On 27/05/2026 20:49, Aliaksandr Smirnou wrote:
> On Wed, 27 May 2026 12:45:26 +0100, Alen Karnil wrote:
> 
>>> Could you provide the build error logs and the overlay files generated
>>> by the tool before you modified them?
>> using the configure.sh tool with imx477
>> imx477_378-overlay.dtsi
>> ...
> 
> The files generated after running the configure.sh tool look correct and
> match mine exactly.
> 
>> If put these into my kernel build I get:
>>
>> $ make dtbs
>>     DTCO     arch/arm64/boot/dts/overlays/camera-mux-2port.dtbo
>> arch/arm64/boot/dts/overlays/imx477_378.dtsi:26.20-31.3: ERROR
>> (duplicate_label): /fragment@200/__overlay__/pca@70/i2c@1/cef168@d:
>> Duplicate label 'vcm_node' on
>> /fragment@200/__overlay__/pca@70/i2c@1/cef168@d and
>> /fragment@200/__overlay__/pca@70/i2c@0/cef168@d
>> ERROR: Input tree has errors, aborting (use -f to force output)
>> make[3]: *** [scripts/Makefile.dtbs:142:
>> arch/arm64/boot/dts/overlays/camera-mux-2port.dtbo] Error 2
>> make[2]: *** [scripts/Makefile.build:544: arch/arm64/boot/dts/overlays]
>> Error 2
>> make[1]: *** [/home/admin/linux/Makefile:1498: dtbs] Error 2
>> make: *** [Makefile:248: __sub-make] Error 2
> 
> It looks like a different Makefile is being used. In the cef168
> repository's Makefile, there is no dtbs target. Also, our Makefile is
> only 27 lines long, while the log output indicates the error occurs at
> line 1498.
> 
I was using the kernel's makefile, basically following
https://www.raspberrypi.com/documentation/computers/linux_kernel.html
The kernel I am running has a LOCALVERSION set so it is 6.18.32-v8-afk+
(for reference)
> Could you please ensure you are using the Makefile provided in the cef168
> repository?
```
$ make
make -C "/lib/modules/`uname -r`/build" M="/home/admin/work/cef168" 
DTC_INCLUDE="/usr/src/linux-headers-`uname -r | sed 
's/rpt-.*/rpt-common-rpi/'`/include"
make[1]: Entering directory '/home/admin/linux'
make[2]: Entering directory '/home/admin/work/cef168'
   CC [M]  cef168.o
make[4]: *** No rule to make target 'imx477.dtbo', needed by 
'modules.order'.  Stop.
make[3]: *** [/home/admin/linux/Makefile:2024: .] Error 2
make[2]: *** [/home/admin/linux/Makefile:248: __sub-make] Error 2
make[2]: Leaving directory '/home/admin/work/cef168'
make[1]: *** [Makefile:248: __sub-make] Error 2
make[1]: Leaving directory '/home/admin/linux'
make: *** [Makefile:16: default] Error 2
```

This is what I got hung up on, which is why I moved onto copying the 
.dts* and building it from the kernel directory, which lead into the 
previous issue and me needing to roll my own .dts*

> 
>>>> there needs to be some further discussions on how we could
>>>> improve the user experience when it comes to enabling the vcm with
>>>> camera sensors.
>>>
>>> I agree. I started the discussion on the Raspberry Pi forum, but the
>>> driver needs to be merged first before moving forward with that.
>> Sure that makes sense, lets focus on the driver for now.
>>>
>>> https://forums.raspberrypi.com/viewtopic.php?p=2318070#p2318070
>>
>> Also you will most likely need to update the patch since the line
>> offsets have moved to work 6.18
> 
> Will do. Should I update the patch before or after your review?

I would prefer if you were to update it before just so we are in sync, 
thank you.