Re: [PATCH v6 0/2] Pinefeat cef168 lens control board driver

[Alen Karnil <alen.karnil@ideasonboard.com>]

Hi Aliaksandr,

I've been asked by Kieran Bingham to review your patches, I've 
reproduced your work on setup with a Pi 5 with a 6.18 kernel and I got a 
few questions

On 07/10/2025 20:57, Aliaksandr Smirnou wrote:
> This patch series adds support for the Pinefeat adapter, which interfaces
> Canon EF and EF-S lenses to non-Canon camera bodies. The cef168 circuit
> control board provides an I2C interface for electronic focus and aperture
> control. The driver integrates with the V4L2 sub-device API.
> 
> For more information about the product, see:
> https://github.com/pinefeat/cef168

I built the calibration application but it would not work out the box,
I can see that CEF168_V4L2_CID_CUSTOM is different between that is in 
the patch and in the application? Which is the correct one, does the 
patch need updating?

The tool to modify the device tree also did not work with the IMX477, I 
needed to manually modify my device tree to get the dtbo to build, there 
needs to be some further discussions on how we could improve the user 
experience when it comes to enabling the vcm with camera sensors.

> 
> Changes in v6:
>   - removed "focus_range" custom control, instead modified the range of
>     the standard "focus_absolute"
> 
> There were no changes in dt-bindings patch.
> 
> Link to v5: https://lore.kernel.org/all/20251005133228.62704-1-asmirnou@pinefeat.co.uk/
> 
> Patches:
>    dt-bindings: Pinefeat cef168 lens control board
>    media: i2c: Pinefeat cef168 lens control board driver
> 
>   .../bindings/media/i2c/pinefeat,cef168.yaml   |  47 +++
>   .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>   MAINTAINERS                                   |   7 +
>   drivers/media/i2c/Kconfig                     |   9 +
>   drivers/media/i2c/Makefile                    |   1 +
>   drivers/media/i2c/cef168.c                    | 317 ++++++++++++++++++
>   include/uapi/linux/v4l2-controls.h            |   6 +
>   7 files changed, 389 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
>   create mode 100644 drivers/media/i2c/cef168.c
> 
> 
> base-commit: 6093a688a07da07808f0122f9aa2a3eed250d853

Thank you,
Alen Karnil