* [PATCH] arm64: dts: qcom: sm8450: add missing power-domains property to usb qmpphy node
@ 2023-06-21 9:55 Neil Armstrong
2023-06-21 10:01 ` Konrad Dybcio
0 siblings, 1 reply; 4+ messages in thread
From: Neil Armstrong @ 2023-06-21 9:55 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Neil Armstrong
Add the missing property to fix the bindings check error:
arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: phy@88e8000: 'power-domains' is a required property
From schema: Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 5cd7296c7660..f921bd520e40 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2046,6 +2046,8 @@ usb_1_qmpphy: phy@88e8000 {
<&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
clock-names = "aux", "ref", "com_aux", "usb3_pipe";
+ power-domains = <&gcc USB30_PRIM_GDSC>;
+
resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
<&gcc GCC_USB3_PHY_PRIM_BCR>;
reset-names = "phy", "common";
---
base-commit: 15e71592dbae49a674429c618a10401d7f992ac3
change-id: 20230621-topic-sm8450-upstream-usb-phy-missing-power-domains-499a3d6c725f
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8450: add missing power-domains property to usb qmpphy node
2023-06-21 9:55 [PATCH] arm64: dts: qcom: sm8450: add missing power-domains property to usb qmpphy node Neil Armstrong
@ 2023-06-21 10:01 ` Konrad Dybcio
2023-06-21 10:39 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2023-06-21 10:01 UTC (permalink / raw)
To: Neil Armstrong, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 21.06.2023 11:55, Neil Armstrong wrote:
> Add the missing property to fix the bindings check error:
> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: phy@88e8000: 'power-domains' is a required property
> From schema: Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Are you sure about this one? Historically PHYs have had their own GDSCs.
May just be a wrong binding fwiw
Konrad
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 5cd7296c7660..f921bd520e40 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2046,6 +2046,8 @@ usb_1_qmpphy: phy@88e8000 {
> <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
> clock-names = "aux", "ref", "com_aux", "usb3_pipe";
>
> + power-domains = <&gcc USB30_PRIM_GDSC>;
> +
> resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
> <&gcc GCC_USB3_PHY_PRIM_BCR>;
> reset-names = "phy", "common";
>
> ---
> base-commit: 15e71592dbae49a674429c618a10401d7f992ac3
> change-id: 20230621-topic-sm8450-upstream-usb-phy-missing-power-domains-499a3d6c725f
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8450: add missing power-domains property to usb qmpphy node
2023-06-21 10:01 ` Konrad Dybcio
@ 2023-06-21 10:39 ` Neil Armstrong
2023-06-21 10:49 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Neil Armstrong @ 2023-06-21 10:39 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
Hi,
On 21/06/2023 12:01, Konrad Dybcio wrote:
> On 21.06.2023 11:55, Neil Armstrong wrote:
>> Add the missing property to fix the bindings check error:
>> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: phy@88e8000: 'power-domains' is a required property
>> From schema: Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> Are you sure about this one? Historically PHYs have had their own GDSCs.
>
> May just be a wrong binding fwiw
Indeed you're right, forget this patch USB30_PRIM_GDSC id for the controller
and starting from SM8550 a new one is used USB3_PHY_GDSC.
I'll fix the bindings.
Neil
>
> Konrad
>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 5cd7296c7660..f921bd520e40 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -2046,6 +2046,8 @@ usb_1_qmpphy: phy@88e8000 {
>> <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
>> clock-names = "aux", "ref", "com_aux", "usb3_pipe";
>>
>> + power-domains = <&gcc USB30_PRIM_GDSC>;
>> +
>> resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
>> <&gcc GCC_USB3_PHY_PRIM_BCR>;
>> reset-names = "phy", "common";
>>
>> ---
>> base-commit: 15e71592dbae49a674429c618a10401d7f992ac3
>> change-id: 20230621-topic-sm8450-upstream-usb-phy-missing-power-domains-499a3d6c725f
>>
>> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8450: add missing power-domains property to usb qmpphy node
2023-06-21 10:39 ` Neil Armstrong
@ 2023-06-21 10:49 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-06-21 10:49 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 21/06/2023 12:39, Neil Armstrong wrote:
> Hi,
>
> On 21/06/2023 12:01, Konrad Dybcio wrote:
>> On 21.06.2023 11:55, Neil Armstrong wrote:
>>> Add the missing property to fix the bindings check error:
>>> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: phy@88e8000: 'power-domains' is a required property
>>> From schema: Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>> Are you sure about this one? Historically PHYs have had their own GDSCs.
>>
>> May just be a wrong binding fwiw
>
> Indeed you're right, forget this patch USB30_PRIM_GDSC id for the controller
> and starting from SM8550 a new one is used USB3_PHY_GDSC.
>
> I'll fix the bindings.
https://lore.kernel.org/all/20230521202321.19778-2-dmitry.baryshkov@linaro.org/ does exactly that,
so no need to fix anything.
Neil
>
> Neil
>
>>
>> Konrad
>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> index 5cd7296c7660..f921bd520e40 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> @@ -2046,6 +2046,8 @@ usb_1_qmpphy: phy@88e8000 {
>>> <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
>>> clock-names = "aux", "ref", "com_aux", "usb3_pipe";
>>> + power-domains = <&gcc USB30_PRIM_GDSC>;
>>> +
>>> resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
>>> <&gcc GCC_USB3_PHY_PRIM_BCR>;
>>> reset-names = "phy", "common";
>>>
>>> ---
>>> base-commit: 15e71592dbae49a674429c618a10401d7f992ac3
>>> change-id: 20230621-topic-sm8450-upstream-usb-phy-missing-power-domains-499a3d6c725f
>>>
>>> Best regards,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-21 10:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 9:55 [PATCH] arm64: dts: qcom: sm8450: add missing power-domains property to usb qmpphy node Neil Armstrong
2023-06-21 10:01 ` Konrad Dybcio
2023-06-21 10:39 ` Neil Armstrong
2023-06-21 10:49 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox