From: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/7] spi: qcom-qspi: Fix incomplete error handling in runtime PM
Date: Fri, 24 Apr 2026 22:22:18 +0530 [thread overview]
Message-ID: <62c0372c-9683-487b-af53-03d15b4916f2@oss.qualcomm.com> (raw)
In-Reply-To: <c38284d9-f7a9-4a0f-a4c7-cafdb1a1f720@sirena.org.uk>
On 4/20/2026 9:59 PM, Mark Brown wrote:
> On Mon, Apr 20, 2026 at 11:42:49AM +0530, Viken Dadhaniya wrote:
>> The runtime PM functions had incomplete error handling that could leave the
>> system in an inconsistent state. If any operation failed midway through
>> suspend or resume, some resources would be left in the wrong state while
>> others were already changed, leading to potential clock/power imbalances.
>
>> +err_select_default_state:
>> + pinctrl_pm_select_default_state(dev);
>> +err_enable_icc:
>> + icc_enable(ctrl->icc_path_cpu_to_qspi);
>> +err_enable_clk:
>> + clk_bulk_prepare_enable(QSPI_NUM_CLKS, ctrl->clks);
>
> clk_bulk_prepare_enable() is marked __must_check.
I’ll update it in the next patch set.
next prev parent reply other threads:[~2026-04-24 16:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 6:12 [PATCH v3 0/7] Add QSPI support for QCS615 and improve interconnect handling Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 1/7] dt-bindings: spi: qcom,spi-qcom-qspi: Add qcom,qcs615-qspi compatible Viken Dadhaniya
2026-04-20 14:19 ` Krzysztof Kozlowski
2026-04-20 14:23 ` Mark Brown
2026-04-20 6:12 ` [PATCH v3 2/7] spi: qcom-qspi: Fix incomplete error handling in runtime PM Viken Dadhaniya
2026-04-20 9:51 ` Konrad Dybcio
2026-04-20 16:29 ` Mark Brown
2026-04-24 16:52 ` Viken Dadhaniya [this message]
2026-04-20 6:12 ` [PATCH v3 3/7] spi: qcom-qspi: Add interconnect support for memory path Viken Dadhaniya
2026-04-20 16:44 ` Mark Brown
2026-04-21 9:46 ` Konrad Dybcio
2026-04-23 4:41 ` Viken Dadhaniya
2026-04-23 11:20 ` Konrad Dybcio
2026-04-23 11:39 ` Mark Brown
2026-04-24 15:46 ` Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 4/7] arm64: dts: qcom: talos: Add QSPI support Viken Dadhaniya
2026-04-20 9:48 ` Konrad Dybcio
2026-04-20 12:29 ` Dmitry Baryshkov
2026-04-21 4:39 ` Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 5/7] arm64: dts: qcom: qcs615-ride: enable QSPI and NOR flash Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 6/7] arm64: dts: qcom: kodiak: Add QSPI memory interconnect path Viken Dadhaniya
2026-04-20 9:45 ` Konrad Dybcio
2026-04-20 6:12 ` [PATCH v3 7/7] arm64: dts: qcom: sc7180: " Viken Dadhaniya
2026-04-20 9:45 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62c0372c-9683-487b-af53-03d15b4916f2@oss.qualcomm.com \
--to=viken.dadhaniya@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox