From: Mark Brown <broonie@kernel.org>
To: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/7] spi: qcom-qspi: Add interconnect support for memory path
Date: Mon, 20 Apr 2026 17:44:09 +0100 [thread overview]
Message-ID: <e7873eb0-bfcc-4ad2-8016-17b0db80feea@sirena.org.uk> (raw)
In-Reply-To: <20260420-spi-nor-v3-3-7de325a29010@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
On Mon, Apr 20, 2026 at 11:42:50AM +0530, Viken Dadhaniya wrote:
> The QSPI controller has two interconnect paths:
> 1. qspi-config: CPU to QSPI controller for register access
> 2. qspi-memory: QSPI controller to memory for DMA operations
> @@ -729,6 +737,11 @@ static int qcom_qspi_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(ctrl->icc_path_cpu_to_qspi),
> "Failed to get cpu path\n");
>
> + ctrl->icc_path_mem = devm_of_icc_get(dev, "qspi-memory");
> + if (IS_ERR(ctrl->icc_path_mem))
> + return dev_err_probe(dev, PTR_ERR(ctrl->icc_path_mem),
> + "Failed to get memory path\n");
> +
Does this handle missing qspi-memory properly? It's not conditional on
the compatible so it'll run even for existing devices.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-20 16:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 6:12 [PATCH v3 0/7] Add QSPI support for QCS615 and improve interconnect handling Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 1/7] dt-bindings: spi: qcom,spi-qcom-qspi: Add qcom,qcs615-qspi compatible Viken Dadhaniya
2026-04-20 14:19 ` Krzysztof Kozlowski
2026-04-20 14:23 ` Mark Brown
2026-04-20 6:12 ` [PATCH v3 2/7] spi: qcom-qspi: Fix incomplete error handling in runtime PM Viken Dadhaniya
2026-04-20 9:51 ` Konrad Dybcio
2026-04-20 16:29 ` Mark Brown
2026-04-24 16:52 ` Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 3/7] spi: qcom-qspi: Add interconnect support for memory path Viken Dadhaniya
2026-04-20 16:44 ` Mark Brown [this message]
2026-04-21 9:46 ` Konrad Dybcio
2026-04-23 4:41 ` Viken Dadhaniya
2026-04-23 11:20 ` Konrad Dybcio
2026-04-23 11:39 ` Mark Brown
2026-04-24 15:46 ` Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 4/7] arm64: dts: qcom: talos: Add QSPI support Viken Dadhaniya
2026-04-20 9:48 ` Konrad Dybcio
2026-04-20 12:29 ` Dmitry Baryshkov
2026-04-21 4:39 ` Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 5/7] arm64: dts: qcom: qcs615-ride: enable QSPI and NOR flash Viken Dadhaniya
2026-04-20 6:12 ` [PATCH v3 6/7] arm64: dts: qcom: kodiak: Add QSPI memory interconnect path Viken Dadhaniya
2026-04-20 9:45 ` Konrad Dybcio
2026-04-20 6:12 ` [PATCH v3 7/7] arm64: dts: qcom: sc7180: " Viken Dadhaniya
2026-04-20 9:45 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7873eb0-bfcc-4ad2-8016-17b0db80feea@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox