Devicetree
 help / color / mirror / Atom feed
From: Ryan Brue <ryanbrue.dev@gmail.com>
To: Nickolay Goppen <setotau@mainlining.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Alexey Minnekhanov <alexeymin@minlexx.ru>
Subject: Re: [PATCH RFC 0/2] Novatek NT51021 DSI panel IC driver
Date: Mon, 7 Sep 2026 18:27:22 -0500	[thread overview]
Message-ID: <668b6dce-32f1-478b-b78b-06f8b5d7e5e8@gmail.com> (raw)
In-Reply-To: <54719b3e-d882-4b0c-b477-1e12dcf65133@mainlining.org>


On 9/7/26 1:42 AM, Nickolay Goppen wrote:
>
> 07.09.2026 09:01, Ryan Brue wrote:
>> One question on the binding, which is as much about my patch as yours.
>> Where does "boe,tv101wum-nx0" come from? Xiaomi's panel dtsi
>> (dsi-panel-nt51021-boe-10wu-video.dtsi) gives only
>>
>>      qcom,mdss-dsi-panel-name = "NT51021_BOE_BOE10";
>>
>> with no part number, and the register sequence in your driver matches
>> that file byte for byte. TV101WUM-NX0 is a real BOE part, and its
>> datasheet active area of 216.576 x 135.36 mm agrees nicely with the
>> 135 x 216 in that dtsi, so the attribution looks reasonable. But if it
>> is inferred rather than read off the panel or a BOM, it may be worth
>> saying so in the commit message, or naming the compatible after the
>> board the way panel-novatek-nt36523.c does for
>> xiaomi,elish-boe-nt36523.
>>
>> I ask because my module has no identity I can establish at all. It
>> answers no DSI read, DCS or generic, before or after sleep-out; the
>> vendor kernel and bootloader name it only "BOE", chosen from two board
>> ID straps; and its vendor-declared physical height is arithmetically
>> impossible, since 1200/136 and 1920/221 disagree by 1.5%. So I am
>> naming mine after the board, and would rather not accidentally imply it
>> is or is not your part.
>
> I've found these part numbers on the photos of a replacement panels 
> from the AliExpress.
>
> Also, for TV101WUM-NX0, I have a confirmation from Alexey Min, who 
> disassembled
> Xiaomi Mi Pad 4 Plus and took a photo of the panel's part number.
>
I searched around on AliExpress for my panel, and could not find 
anything about the BOE

part number for mine. Oh well, since there's some precedent for naming 
unknown BOE

glass after the device that has it, I am hoping that will be OK for my case.

>> If it is useful, I have the Fire HD 10 panel ready as a variant on top
>> of your series: two patches, binding and driver, adding
>> amazon,suez-boe-nt51021. The only change it needs in your code is
>> making mode_flags per variant. My vendor asks for sync-event video mode
>> with a continuously running HS clock rather than burst, and your two
>> panels keep exactly the flags they have now. Burst worked on my panel
>> too, so this is about matching what the module is characterised for,
>> not a fix.
> I will try to do that. Can I add you to the maintainers of this panel 
> driver?

Yes, you may. Once you get the v2 out, I'll get a patch ready on top of that
for the Fire Tablet's BOE panel!

>> I will hold that until your v2, since Neil's renaming will touch every
>> identifier it adds. Happy to test v2 on this hardware when you post it.
>>
>> Thanks for doing this first.
>>
>> Ryan
>

      reply	other threads:[~2026-09-07 23:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 20:09 [PATCH RFC 0/2] Novatek NT51021 DSI panel IC driver Nickolay Goppen
2026-08-29 20:09 ` [PATCH RFC 1/2] dt-bindings: display: panel: Add bindings for Novatek NT51021 Nickolay Goppen
2026-08-29 20:14   ` sashiko-bot
2026-08-29 20:18     ` Nickolay Goppen
2026-08-30 12:59   ` Neil Armstrong
2026-08-29 20:09 ` [PATCH RFC 2/2] drivers: gpu: drm: panel: Add BOE NT51021 driver Nickolay Goppen
2026-08-29 20:19   ` sashiko-bot
2026-08-29 20:27     ` Nickolay Goppen
2026-08-29 20:32       ` Nickolay Goppen
2026-08-29 20:35     ` Nickolay Goppen
2026-08-30 12:58   ` Neil Armstrong
2026-09-07  8:35   ` Uwe Kleine-König
2026-09-07  6:01 ` [PATCH RFC 0/2] Novatek NT51021 DSI panel IC driver Ryan Brue
2026-09-07  6:42   ` Nickolay Goppen
2026-09-07 23:27     ` Ryan Brue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=668b6dce-32f1-478b-b78b-06f8b5d7e5e8@gmail.com \
    --to=ryanbrue.dev@gmail.com \
    --cc=airlied@gmail.com \
    --cc=alexeymin@minlexx.ru \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=setotau@mainlining.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox