From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Nickolay Goppen <setotau@mainlining.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexey Minnekhanov <alexeymin@minlexx.ru>
Subject: Re: [PATCH RFC 2/2] drivers: gpu: drm: panel: Add BOE NT51021 driver
Date: Mon, 7 Sep 2026 10:35:13 +0200 [thread overview]
Message-ID: <ap52w_LsxykYh6T1@monoceros> (raw)
In-Reply-To: <20260829-qcom-novatek-nt51021-panels-v1-2-cc1ca61bd261@mainlining.org>
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
Hello,
On Sat, Aug 29, 2026 at 11:09:14PM +0300, Nickolay Goppen wrote:
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/regulator/consumer.h>
Please rely on <linux/of.h> to provide of_device_id and don't include
<linux/mod_devicetable.h>. If you want to stick to IWYU, include
<linux/device-id/of.h> instead.
Liebe Grüße
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-07 8:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 20:09 [PATCH RFC 0/2] Novatek NT51021 DSI panel IC driver Nickolay Goppen
2026-08-29 20:09 ` [PATCH RFC 1/2] dt-bindings: display: panel: Add bindings for Novatek NT51021 Nickolay Goppen
2026-08-29 20:14 ` sashiko-bot
2026-08-29 20:18 ` Nickolay Goppen
2026-08-30 12:59 ` Neil Armstrong
2026-08-29 20:09 ` [PATCH RFC 2/2] drivers: gpu: drm: panel: Add BOE NT51021 driver Nickolay Goppen
2026-08-29 20:19 ` sashiko-bot
2026-08-29 20:27 ` Nickolay Goppen
2026-08-29 20:32 ` Nickolay Goppen
2026-08-29 20:35 ` Nickolay Goppen
2026-08-30 12:58 ` Neil Armstrong
2026-09-07 8:35 ` Uwe Kleine-König [this message]
2026-09-07 6:01 ` [PATCH RFC 0/2] Novatek NT51021 DSI panel IC driver Ryan Brue
2026-09-07 6:42 ` Nickolay Goppen
2026-09-07 23:27 ` Ryan Brue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap52w_LsxykYh6T1@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=airlied@gmail.com \
--cc=alexeymin@minlexx.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=setotau@mainlining.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).