[PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema

[PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema

[Mikhail Lukianchikov]

Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
documentation from plain text to DT schema.

The conversion adds proper validation for the 'microchip,led-modes'
property inside the MDIO node.

Signed-off-by: Mikhail Lukianchikov <avermoal@gmail.com>
---
Changes in v3:
 - Added $ref to ethernet-phy.yaml for PHY node to use standard PHY properties.
 - Dropped redundant PHY description and manual 'reg' property definition.
 - Dropped root node and fake compatibles in the example.

Link to v2: https://lore.kernel.org/netdev/20260709181724.24682-2-avermoal@gmail.com

 .../bindings/net/microchip,lan7800.yaml       | 96 +++++++++++++++++++
 .../bindings/net/microchip,lan78xx.txt        | 53 ----------
 MAINTAINERS                                   |  3 +-
 3 files changed, 97 insertions(+), 55 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt

diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
new file mode 100644
index 000000000000..730999d11e8a
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
@@ -0,0 +1,96 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller
+
+maintainers:
+  - Rengarajan Sundararajan <Rengarajan.S@microchip.com>
+
+description:
+  The LAN7800/LAN7801/LAN7850 devices are usually configured by
+  programming their OTP or with an external EEPROM, but some
+  platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree
+  properties, if present, override the OTP and EEPROM.
+
+allOf:
+  - $ref: /schemas/usb/usb-device.yaml#
+  - $ref: /schemas/net/ethernet-controller.yaml#
+
+properties:
+  compatible:
+    enum:
+      - usb424,7800
+      - usb424,7801
+      - usb424,7850
+
+  reg:
+    maxItems: 1
+    description: USB port number
+
+  local-mac-address:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    minItems: 6
+    maxItems: 6
+    description:
+      MAC address to use if not stored in OTP or EEPROM. If present,
+      overrides OTP/EEPROM.
+
+  mdio:
+    $ref: /schemas/net/mdio.yaml#
+    unevaluatedProperties: false
+
+    patternProperties:
+      "^ethernet-phy(@[0-9a-f]+)?$":
+        $ref: /schemas/net/ethernet-phy.yaml#
+        unevaluatedProperties: false
+        type: object
+
+        properties:
+          microchip,led-modes:
+            $ref: /schemas/types.yaml#/definitions/uint32-array
+            minItems: 1
+            maxItems: 4
+            description:
+              Array of LED mode values for each of up to 4 LEDs.
+              Omitted LEDs are turned off. Allowed values are defined
+              in include/dt-bindings/net/microchip-lan78xx.h.
+
+        required:
+          - reg
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/net/microchip-lan78xx.h>
+
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethernet@1 {
+            compatible = "usb424,7800";
+            reg = <1>;
+            local-mac-address = [00 11 22 33 44 55];
+
+            mdio {
+                #address-cells = <1>;
+                #size-cells = <0>;
+                ethernet-phy@1 {
+                    reg = <1>;
+                    microchip,led-modes = <
+                        LAN78XX_LINK_1000_ACTIVITY
+                        LAN78XX_LINK_10_100_ACTIVITY
+                    >;
+                };
+            };
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/net/microchip,lan78xx.txt b/Documentation/devicetree/bindings/net/microchip,lan78xx.txt
deleted file mode 100644
index 11a679530ae6..000000000000
--- a/Documentation/devicetree/bindings/net/microchip,lan78xx.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-Microchip LAN78xx Gigabit Ethernet controller
-
-The LAN78XX devices are usually configured by programming their OTP or with
-an external EEPROM, but some platforms (e.g. Raspberry Pi 3 B+) have neither.
-The Device Tree properties, if present, override the OTP and EEPROM.
-
-Required properties:
-- compatible: Should be one of "usb424,7800", "usb424,7801" or "usb424,7850".
-
-The MAC address will be determined using the optional properties
-defined in ethernet.txt.
-
-Optional properties of the embedded PHY:
-- microchip,led-modes: a 0..4 element vector, with each element configuring
-  the operating mode of an LED. Omitted LEDs are turned off. Allowed values
-  are defined in "include/dt-bindings/net/microchip-lan78xx.h".
-
-Example:
-
-/* Based on the configuration for a Raspberry Pi 3 B+ */
-&usb {
-	usb-port@1 {
-		compatible = "usb424,2514";
-		reg = <1>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		usb-port@1 {
-			compatible = "usb424,2514";
-			reg = <1>;
-			#address-cells = <1>;
-			#size-cells = <0>;
-
-			ethernet: ethernet@1 {
-				compatible = "usb424,7800";
-				reg = <1>;
-				local-mac-address = [ 00 11 22 33 44 55 ];
-
-				mdio {
-					#address-cells = <0x1>;
-					#size-cells = <0x0>;
-					eth_phy: ethernet-phy@1 {
-						reg = <1>;
-						microchip,led-modes = <
-							LAN78XX_LINK_1000_ACTIVITY
-							LAN78XX_LINK_10_100_ACTIVITY
-						>;
-					};
-				};
-			};
-		};
-	};
-};
diff --git a/MAINTAINERS b/MAINTAINERS
index f37a81950e25..157a677a284f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -27928,10 +27928,9 @@ F:	drivers/usb/isp1760/*
 USB LAN78XX ETHERNET DRIVER
 M:	Thangaraj Samynathan <Thangaraj.S@microchip.com>
 M:	Rengarajan Sundararajan <Rengarajan.S@microchip.com>
-M:	UNGLinuxDriver@microchip.com
 L:	netdev@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/net/microchip,lan78xx.txt
+F:	Documentation/devicetree/bindings/net/microchip,lan7800.yaml
 F:	drivers/net/usb/lan78xx.*
 F:	include/dt-bindings/net/microchip-lan78xx.h
 
-- 
2.52.0

Re: [PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema

[Krzysztof Kozlowski]

On 11/07/2026 12:55, Mikhail Lukianchikov wrote:
> The conversion adds proper validation for the 'microchip,led-modes'
> property inside the MDIO node.

It was in the old binding, so I don't understand this part. You list
here changes done to the binding during conversion. I see no change, so
what does this refer to?

> 
> Signed-off-by: Mikhail Lukianchikov <avermoal@gmail.com>
> ---
> Changes in v3:
>  - Added $ref to ethernet-phy.yaml for PHY node to use standard PHY properties.
>  - Dropped redundant PHY description and manual 'reg' property definition.
>  - Dropped root node and fake compatibles in the example.
> 
> Link to v2: https://lore.kernel.org/netdev/20260709181724.24682-2-avermoal@gmail.com
> 
>  .../bindings/net/microchip,lan7800.yaml       | 96 +++++++++++++++++++
>  .../bindings/net/microchip,lan78xx.txt        | 53 ----------
>  MAINTAINERS                                   |  3 +-
>  3 files changed, 97 insertions(+), 55 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> new file mode 100644
> index 000000000000..730999d11e8a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller
> +
> +maintainers:
> +  - Rengarajan Sundararajan <Rengarajan.S@microchip.com>
> +
> +description:
> +  The LAN7800/LAN7801/LAN7850 devices are usually configured by
> +  programming their OTP or with an external EEPROM, but some
> +  platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree
> +  properties, if present, override the OTP and EEPROM.
> +
> +allOf:
> +  - $ref: /schemas/usb/usb-device.yaml#
> +  - $ref: /schemas/net/ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - usb424,7800
> +      - usb424,7801
> +      - usb424,7850
> +
> +  reg:
> +    maxItems: 1
> +    description: USB port number
> +
> +  local-mac-address:
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 6
> +    maxItems: 6
> +    description:
> +      MAC address to use if not stored in OTP or EEPROM. If present,
> +      overrides OTP/EEPROM.

Drop local-mac-address, already coming from network-class schema.

> +
> +  mdio:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false


...

> diff --git a/MAINTAINERS b/MAINTAINERS
> index f37a81950e25..157a677a284f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27928,10 +27928,9 @@ F:	drivers/usb/isp1760/*
>  USB LAN78XX ETHERNET DRIVER
>  M:	Thangaraj Samynathan <Thangaraj.S@microchip.com>
>  M:	Rengarajan Sundararajan <Rengarajan.S@microchip.com>
> -M:	UNGLinuxDriver@microchip.com

I don't understand this change. No one requested this. Not explained in
commit msg at all.

>  L:	netdev@vger.kernel.org
>  S:	Maintained
> -F:	Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> +F:	Documentation/devicetree/bindings/net/microchip,lan7800.yaml
>  F:	drivers/net/usb/lan78xx.*
>  F:	include/dt-bindings/net/microchip-lan78xx.h
>  


Best regards,
Krzysztof

Re: [PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The converted DT schema incorrectly rejects a 0-length `microchip,led-modes` property, breaking backward compatibility.
- [Medium] Silently dropping an active maintainer from the MAINTAINERS file without explanation.
--

--- Patch [1]: [PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema ---
commit 2888aafe795bb2f999fce4b5a449417cdf27043b
Author: Mikhail Lukianchikov <avermoal@gmail.com>

dt-bindings: net: microchip,lan78xx: convert to DT schema

Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
documentation from plain text to DT schema. The conversion adds proper
validation for the 'microchip,led-modes' property inside the MDIO node.

Link: https://lore.kernel.org/netdev/20260709181724.24682-2-avermoal@gmail.com

> diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> new file mode 100644
> index 0000000000000..730999d11e8a0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
[ ... ]
> +        properties:
> +          microchip,led-modes:
> +            $ref: /schemas/types.yaml#/definitions/uint32-array
> +            minItems: 1

[Severity: Medium]
Does setting minItems to 1 here improperly reject a 0-length property?

The original text binding specified this as a 0..4 element vector. If a device
tree uses an empty property to explicitly disable all LEDs, it will now fail
schema validation.

> +            maxItems: 4
> +            description:
> +              Array of LED mode values for each of up to 4 LEDs.
[ ... ]
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f37a81950e250..157a677a284fc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27928,10 +27928,9 @@ F:	drivers/usb/isp1760/*
>  USB LAN78XX ETHERNET DRIVER
>  M:	Thangaraj Samynathan <Thangaraj.S@microchip.com>
>  M:	Rengarajan Sundararajan <Rengarajan.S@microchip.com>
> -M:	UNGLinuxDriver@microchip.com

[Severity: Medium]
This isn't a bug, but was the UNGLinuxDriver@microchip.com maintainer email
intentionally removed?

The commit message doesn't mention dropping this group email, which will no
longer be automatically CC'd on patches to the LAN78XX driver.

>  L:	netdev@vger.kernel.org
>  S:	Maintained

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260711105537.11065-2-avermoal@gmail.com?part=1