From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
Date: Mon, 6 Jul 2026 09:17:13 +0200 [thread overview]
Message-ID: <68b98abf-4cd9-4906-a774-2b798c4576bb@oss.qualcomm.com> (raw)
In-Reply-To: <20260706-dts-qcom-style-checker-v1-1-16ce82a2bcfd@oss.qualcomm.com>
On 06/07/2026 09:03, Krzysztof Kozlowski wrote:
> index 7393978926e4..0796d9dbe158 100644
> --- a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> +++ b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> @@ -136,7 +136,7 @@ ramoops@81f20000 {
> * ABL is powering down display and controller if this node is
> * not named exactly "splash_region".
> */
If I only read comments... This will cause DTS style checker warning.
Honestly, we should not accept such code. Bootloader vendors were told
about ABI, they just ignore the problem because they can get away with it.
> - splash_region@e3940000 {
> + splash@e3940000 {
> reg = <0x0 0xe3940000 0x0 0x2b00000>;
> no-map;
> };
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-06 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 7:03 [PATCH 0/4] arm64: dts: qcom: Few style cleanups Krzysztof Kozlowski
2026-07-06 7:03 ` [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names Krzysztof Kozlowski
2026-07-06 7:10 ` sashiko-bot
2026-07-06 7:17 ` Krzysztof Kozlowski
2026-07-06 7:17 ` Krzysztof Kozlowski [this message]
2026-07-06 7:19 ` Luca Weiss
2026-07-06 7:37 ` Krzysztof Kozlowski
2026-07-06 7:03 ` [PATCH 2/4] arm64: dts: qcom: Use tab for indentation Krzysztof Kozlowski
2026-07-06 8:25 ` Konrad Dybcio
2026-07-06 7:03 ` [PATCH 3/4] arm64: dts: qcom: Use lowercase hex for unit addresses and values Krzysztof Kozlowski
2026-07-06 8:25 ` Konrad Dybcio
2026-07-06 7:03 ` [PATCH 4/4] arm64: dts: qcom: Correct whitespace around '=' Krzysztof Kozlowski
2026-07-06 8:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b98abf-4cd9-4906-a774-2b798c4576bb@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox