From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
Date: Mon, 6 Jul 2026 09:37:34 +0200 [thread overview]
Message-ID: <e8085b6b-35de-4f93-ad76-158bedb6d585@oss.qualcomm.com> (raw)
In-Reply-To: <DJRB0IFM6VRY.1H62MF66GWTN1@fairphone.com>
On 06/07/2026 09:19, Luca Weiss wrote:
> On Mon Jul 6, 2026 at 9:03 AM CEST, Krzysztof Kozlowski wrote:
>> DTS coding style prefers hyphens instead of underscores in the node
>> names. Change should be safe, because node names are not considered an
>> ABI.
>
> Until Qualcomm decides they are ABI :(
If such node-name-ABI ever comes from Qualcomm, I will NAK :)
Sashiko also pointed out the error and I will be sending v2.
I will introduce shellcheck-style exceptions for warnings to the
checker. But first let's fix all the warnings :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-06 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 7:03 [PATCH 0/4] arm64: dts: qcom: Few style cleanups Krzysztof Kozlowski
2026-07-06 7:03 ` [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names Krzysztof Kozlowski
2026-07-06 7:10 ` sashiko-bot
2026-07-06 7:17 ` Krzysztof Kozlowski
2026-07-06 7:17 ` Krzysztof Kozlowski
2026-07-06 7:19 ` Luca Weiss
2026-07-06 7:37 ` Krzysztof Kozlowski [this message]
2026-07-06 7:03 ` [PATCH 2/4] arm64: dts: qcom: Use tab for indentation Krzysztof Kozlowski
2026-07-06 8:25 ` Konrad Dybcio
2026-07-06 7:03 ` [PATCH 3/4] arm64: dts: qcom: Use lowercase hex for unit addresses and values Krzysztof Kozlowski
2026-07-06 8:25 ` Konrad Dybcio
2026-07-06 7:03 ` [PATCH 4/4] arm64: dts: qcom: Correct whitespace around '=' Krzysztof Kozlowski
2026-07-06 8:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8085b6b-35de-4f93-ad76-158bedb6d585@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox