From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] clk: qcom: add Global Clock controller (GCC) driver for IPQ9650 SoC
Date: Wed, 29 Apr 2026 09:31:24 +0530 [thread overview]
Message-ID: <6a2a4766-2dd8-4da0-a180-0c8ce3dc8d8a@oss.qualcomm.com> (raw)
In-Reply-To: <6ca50a86-0b2a-4eb1-8873-cb80f893174d@oss.qualcomm.com>
On 4/24/2026 5:00 PM, Konrad Dybcio wrote:
> On 4/15/26 3:33 PM, Kathiravan Thirumoorthy wrote:
>> Add support for the global clock controller found on IPQ9650 SoC.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
> [...]
>
>> +static struct clk_rcg2 gcc_pcnoc_bfdcd_clk_src = {
>> + .cmd_rcgr = 0x31004,
>> + .mnd_width = 0,
>> + .hid_width = 5,
>> + .parent_map = gcc_parent_map_0,
>> + .freq_tbl = ftbl_gcc_pcnoc_bfdcd_clk_src,
>> + .clkr.hw.init = &(const struct clk_init_data) {
>> + .name = "gcc_pcnoc_bfdcd_clk_src",
>> + .parent_data = gcc_parent_data_0,
>> + .num_parents = ARRAY_SIZE(gcc_parent_data_0),
>> + /*
>> + * There are no consumers for this source in kernel yet,
>> + * (will be added soon), so the clock framework
>> + * disables this source. But some of the clocks
>> + * initialized by boot loaders uses this source. So we
>> + * need to keep this clock ON. Add the
>> + * CLK_IGNORE_UNUSED flag so the clock will not be
>> + * disabled. Once the consumer in kernel is added, we
>> + * can get rid of this flag.
>> + */
>> + .flags = CLK_IS_CRITICAL,
> I think this clock is normally governed by RPM.. is there RPM/H on this
> platform? (doc access still pending..)
There is no RPM in this SoC.
> If not, what's your plan for this? icc-clk?
USB and PCIe clocks uses this source. So once those peripheral supports
are landed, we can get rid off this.
>
> Konrad
next prev parent reply other threads:[~2026-04-29 4:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 13:33 [PATCH 0/5] Add minimal boot support for Qualcomm IPQ9650 SoC Kathiravan Thirumoorthy
2026-04-15 13:33 ` [PATCH 1/5] dt-bindings: clock: add Qualcomm IPQ9650 GCC Kathiravan Thirumoorthy
2026-04-16 9:33 ` Krzysztof Kozlowski
2026-04-15 13:33 ` [PATCH 2/5] clk: qcom: add Global Clock controller (GCC) driver for IPQ9650 SoC Kathiravan Thirumoorthy
2026-04-16 6:34 ` Krzysztof Kozlowski
2026-04-16 8:12 ` Kathiravan Thirumoorthy
2026-04-24 11:30 ` Konrad Dybcio
2026-04-29 4:01 ` Kathiravan Thirumoorthy [this message]
2026-04-15 13:33 ` [PATCH 3/5] dt-bindings: qcom: add IPQ9650 boards Kathiravan Thirumoorthy
2026-04-16 9:34 ` Krzysztof Kozlowski
2026-04-15 13:33 ` [PATCH 4/5] arm64: dts: qcom: add IPQ9650 SoC and rdp488 board support Kathiravan Thirumoorthy
2026-04-16 9:35 ` Krzysztof Kozlowski
2026-04-16 9:54 ` Kathiravan Thirumoorthy
2026-04-24 11:21 ` Konrad Dybcio
2026-04-29 3:58 ` Kathiravan Thirumoorthy
2026-04-15 13:33 ` [PATCH 5/5] arm64: defconfig: enable IPQ9650 RDP488 base configs Kathiravan Thirumoorthy
2026-04-16 6:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2a4766-2dd8-4da0-a180-0c8ce3dc8d8a@oss.qualcomm.com \
--to=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox