Devicetree
 help / color / mirror / Atom feed
From: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 1/2] arm64: dts: qcom: kodiak: enable inline crypto engine for SDHC
Date: Tue, 7 Jul 2026 14:11:08 +0530	[thread overview]
Message-ID: <6af98083-a102-4614-a853-76d27d209118@oss.qualcomm.com> (raw)
In-Reply-To: <20260707075554.BB8E41F000E9@smtp.kernel.org>

>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
>> index 90e50c245c0cb..3692be65cc21b 100644
>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> [ ... ]
>> @@ -1050,6 +1050,8 @@ sdhc_1: mmc@7c4000 {
>>  			qcom,dll-config = <0x0007642c>;
>>  			qcom,ddr-config = <0x80040868>;
>>  
>> +			qcom,ice = <&sdhc_ice>;
> 
> [Severity: Low]
> Does this new property trigger a dtbs_check validation error?
> 
> The Documentation/devicetree/bindings/mmc/qcom,sdhci-msm.yaml schema uses
> unevaluatedProperties: false. Because the qcom,ice property is not
> currently documented in that schema, adding it to the SDHC controller node
> here causes make dtbs_check to report a validation failure.
> 
> Should the binding schema be updated to include qcom,ice alongside this
> device tree change?

As mentioned in cover letter too, dt-bindings with qcom,ice property is
accepted hence, sent v9 without bindings change.
Validated dtbs_check locally, taking dt-bindings as base kodiak/monaco
DT didn't give any error.

-- 
Regards
Kuldeep


  reply	other threads:[~2026-07-07  8:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  7:11 [PATCH v9 0/2] Enable sdhc inline crypto engine for kodiak and monaco Kuldeep Singh
2026-07-07  7:11 ` [PATCH v9 1/2] arm64: dts: qcom: kodiak: enable inline crypto engine for SDHC Kuldeep Singh
2026-07-07  7:55   ` sashiko-bot
2026-07-07  8:41     ` Kuldeep Singh [this message]
2026-07-07  7:11 ` [PATCH v9 2/2] arm64: dts: qcom: monaco: " Kuldeep Singh
2026-07-07  8:05   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6af98083-a102-4614-a853-76d27d209118@oss.qualcomm.com \
    --to=kuldeep.singh@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox