public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Prashanth K <prashanth.k@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable retimer on USB0 port
Date: Thu, 23 Apr 2026 13:37:06 +0530	[thread overview]
Message-ID: <6e8f523f-7ad4-4472-aca8-118de81223e7@oss.qualcomm.com> (raw)
In-Reply-To: <hctf2vexnfd2lbnggvoanm424rmpzadg6daqq4477audy6mu2e@nwyp3ijbhay3>



On 4/22/2026 5:22 PM, Dmitry Baryshkov wrote:
> On Wed, Apr 22, 2026 at 01:09:22PM +0200, Konrad Dybcio wrote:
>> On 4/22/26 1:04 PM, Prashanth K wrote:
>>>
>>>
>>> On 4/22/2026 4:13 PM, Konrad Dybcio wrote:
>>>> On 4/22/26 12:32 PM, Prashanth K wrote:
>>>>>
>>>>>
>>>>> On 4/22/2026 3:56 PM, Konrad Dybcio wrote:
>>>>>> On 4/22/26 11:39 AM, Prashanth K wrote:
>>>>>>> Add the retimer for usb_1_ss0 port (USB0), in order to enable
>>>>>>> super-speed enumeration on that port.
>>>>>>>
>>>>>>> Fixes: c11645afb0e2 ("arm64: dts: qcom: Add base HAMOA-IOT-EVK board")
>>>>>>> Cc: stable@vger.kernel.org
>>>>>>
>>>>>> This is a feature addition, not a fix
>>>>>>
>>>>>> [...]
>>>>>>
>>>>> Sure.
>>>>>>> +		ports {
>>>>>>> +			#address-cells = <1>;
>>>>>>> +			#size-cells = <0>;
>>>>>>> +
>>>>>>> +			port@0 {
>>>>>>> +				reg = <0>;
>>>>>>> +
>>>>>>> +				retimer_ss0_ss_out: endpoint {
>>>>>>> +					remote-endpoint = <&pmic_glink_ss0_ss_in>;
>>>>>>> +				};
>>>>>>> +			};
>>>>>>> +
>>>>>>> +			port@1 {
>>>>>>> +				reg = <1>;
>>>>>>> +
>>>>>>> +				retimer_ss0_ss_in: endpoint {
>>>>>>> +					remote-endpoint = <&usb_1_ss0_qmpphy_out>;
>>>>>>> +				};
>>>>>>> +			};
>>>>>>> +
>>>>>>
>>>>>> Stray \n, but you should really have a @2 port here as well.
>>>>>>
>>>>>> Konrad
>>>>> Can we ad port@2 and leave it empty?
>>>>
>>>> Why would you? Just connect it to port2 of the connector under pmic-glink
>>>>
>>>> Konrad
>>>
>>> Because the port@2 of pmic-glink (pmic_glink_ss0_sbu) is already
>>> connected to usb-1-ss0-sbu-mux (onn,fsusb42). This is different compared
>>> to other connectors.
>>
>> Are both the SBU mux and the Parade retimer present on board?
>>
>> The former is redundant since the retimer already has a superset of its
>> functionality, so that sounds rather odd.
> 
> fsusb42 might be also used to switch SBU lines for other purposes (e.g.
> for the debug).
> 
I just checked, fsusb42 is not present in evk, not sure why it was added
in the first place. Will link the retimer port@2 with pmic-glink.

Regards,
Prashanth K

      reply	other threads:[~2026-04-23  8:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22  9:39 [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable retimer on USB0 port Prashanth K
2026-04-22 10:26 ` Konrad Dybcio
2026-04-22 10:32   ` Prashanth K
2026-04-22 10:43     ` Konrad Dybcio
2026-04-22 11:04       ` Prashanth K
2026-04-22 11:09         ` Konrad Dybcio
2026-04-22 11:52           ` Dmitry Baryshkov
2026-04-23  8:07             ` Prashanth K [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e8f523f-7ad4-4472-aca8-118de81223e7@oss.qualcomm.com \
    --to=prashanth.k@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox