Re: [PATCH 1/3] dt-bindings: serial: 8250_omap: Update wakeup-source type property

[Kendall Willis <k-willis@ti.com>]

On 9/9/25 04:05, Markus Schneider-Pargmann wrote:
> On Fri Sep 5, 2025 at 8:38 PM CEST, Conor Dooley wrote:
>> On Thu, Sep 04, 2025 at 04:24:53PM -0500, Kendall Willis wrote:
>>> Allow the wakeup-source property to be either of type boolean or of a
>>> phandle array. The phandle array points to the system idle states that the
>>> UART can wakeup the system from.
>>>
>>> Signed-off-by: Kendall Willis <k-willis@ti.com>
>>> ---
>>>   Documentation/devicetree/bindings/serial/8250_omap.yaml | 8 +++++++-
>>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml
>>> index 1859f71297ff2..851a5291b4be4 100644
>>> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
>>> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
>>> @@ -69,7 +69,13 @@ properties:
>>>     clock-frequency: true
>>>     current-speed: true
>>>     overrun-throttle-ms: true
>>> -  wakeup-source: true
>>> +
>>> +  wakeup-source:
>>> +    oneOf:
>>> +      - type: boolean
>>> +      - $ref: /schemas/types.yaml#/definitions/phandle-array
>>> +        description:
>>> +          List of phandles to system idle states in which UARTs can wakeup the system.
>>
>> Is there a single other instance of the wakeup-source property being
>> used like this?
> 
> This was added to the dt-schema repository:
>    https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/wakeup-source.yaml
> 
> I don't think this needs to be repeated in every binding, so I think you
> can just drop this unless there are specifics for this device.
> 
> Best
> Markus

Okay, I will likely drop this patch in the next version. Thanks for 
reviewing :)

Best,
Kendall