public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Kendall Willis <k-willis@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <vigneshr@ti.com>,
	<linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <d-gole@ti.com>, <vishalm@ti.com>,
	<sebin.francis@ti.com>, <msp@baylibre.com>,
	<khilman@baylibre.com>, <a-kaur@ti.com>,
	<john.ogness@linutronix.de>, <andriy.shevchenko@linux.intel.com>,
	<yujiaoliang@vivo.com>, <b-liu@ti.com>,
	<u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH 1/3] dt-bindings: serial: 8250_omap: Update wakeup-source type property
Date: Tue, 9 Sep 2025 14:00:41 -0500	[thread overview]
Message-ID: <81915aee-55e7-44c8-9a43-23e77f3ddd6d@ti.com> (raw)
In-Reply-To: <20250905203829.GA1269545-robh@kernel.org>

On 9/5/25 15:38, Rob Herring wrote:
> On Thu, Sep 04, 2025 at 04:24:53PM -0500, Kendall Willis wrote:
>> Allow the wakeup-source property to be either of type boolean or of a
>> phandle array. The phandle array points to the system idle states that the
>> UART can wakeup the system from.
>>
>> Signed-off-by: Kendall Willis <k-willis@ti.com>
>> ---
>>   Documentation/devicetree/bindings/serial/8250_omap.yaml | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml
>> index 1859f71297ff2..851a5291b4be4 100644
>> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
>> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
>> @@ -69,7 +69,13 @@ properties:
>>     clock-frequency: true
>>     current-speed: true
>>     overrun-throttle-ms: true
>> -  wakeup-source: true
>> +
>> +  wakeup-source:
>> +    oneOf:
>> +      - type: boolean
>> +      - $ref: /schemas/types.yaml#/definitions/phandle-array
>> +        description:
>> +          List of phandles to system idle states in which UARTs can wakeup the system.
> 
> You don't need to be defining the type here. Did you find either type
> didn't work?

You're right, this should not be redefined. I'll be dropping this patch 
in the next version. Thanks for reviewing :)

Best,
Kendall

  reply	other threads:[~2025-09-09 19:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 21:24 [PATCH 0/3] serial: 8250: omap: Add wakeup support Kendall Willis
2025-09-04 21:24 ` [PATCH 1/3] dt-bindings: serial: 8250_omap: Update wakeup-source type property Kendall Willis
2025-09-05 18:38   ` Conor Dooley
2025-09-05 18:48     ` Dhruva Gole
2025-09-09  9:05     ` Markus Schneider-Pargmann
2025-09-09 18:59       ` Kendall Willis
2025-09-05 20:38   ` Rob Herring
2025-09-09 19:00     ` Kendall Willis [this message]
2025-09-04 21:24 ` [PATCH 2/3] dt-bindings: serial: 8250_omap: Add wakeup pinctrl state Kendall Willis
2025-09-05 20:41   ` Rob Herring
2025-09-09 21:26     ` Kendall Willis
2025-09-04 21:24 ` [PATCH 3/3] serial: 8250: omap: Support wakeup pinctrl state on suspend Kendall Willis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81915aee-55e7-44c8-9a43-23e77f3ddd6d@ti.com \
    --to=k-willis@ti.com \
    --cc=a-kaur@ti.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=b-liu@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=msp@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sebin.francis@ti.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=vigneshr@ti.com \
    --cc=vishalm@ti.com \
    --cc=yujiaoliang@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox