Re: Re: [PATCH net-next v10 1/4] dt-bindings: ethernet: eswin: relax internal delay model to range-based constraints

[李志 <lizhi2@eswincomputing.com>]

> -----Original Messages-----
> From: sashiko-bot@kernel.org
> Send time:Wednesday, 08/07/2026 14:43:22
> To: lizhi2@eswincomputing.com
> Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
> Subject: Re: [PATCH net-next v10 1/4] dt-bindings: ethernet: eswin: relax internal delay model to range-based constraints
> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] DT Binding and Driver mismatch: relaxed delay properties cause probe failure.
> --
> 
> --- Patch [1]: [PATCH net-next v10 1/4] dt-bindings: ethernet: eswin: relax internal delay model to range-based constraints ---
> commit 3dceaf931915c24887e11e00c0d85cb45cef4d39
> Author: Zhi Li <lizhi2@eswincomputing.com>
> 
> dt-bindings: ethernet: eswin: relax internal delay model to range-based constraints
> 
> This commit relaxes internal delay constraints for the EIC7700 Ethernet
> binding, replacing fixed enumerations with range-based definitions. It also
> makes the rx-internal-delay-ps and tx-internal-delay-ps properties optional.
> 
> > diff --git a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> > index 65882ff79d8d7..4e02fedae5c67 100644
> > --- a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> > +++ b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> [ ... ]
> > @@ -105,8 +109,6 @@ required:
> >    - phy-mode
> >    - resets
> >    - reset-names
> > -  - rx-internal-delay-ps
> > -  - tx-internal-delay-ps
> 
> [Severity: High]
> With this change, the DT schema makes these properties optional. However, does
> the eic7700-qos-eth driver still require them?
> 
> Looking at eic7700_dwmac_probe(), it appears to return an error if these
> properties are missing:
> 
> drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c:eic7700_dwmac_probe() {
>     ...
> 	} else {
> 		return dev_err_probe(&pdev->dev, -EINVAL,
> 			"missing required property rx-internal-delay-ps\n");
> 	}
>     ...
> 	} else {
> 		return dev_err_probe(&pdev->dev, -EINVAL,
> 			"missing required property tx-internal-delay-ps\n");
> 	}
>     ...
> }
> 
> Will this cause the probe to fail if a device tree omits these properties,
> as permitted by the updated schema?
> 

Hi Sashiko,

Thanks for the review.

These comments are all false positives due to performing the regression
analysis of one patch at once by AI.
These four patches are sequential modifications made for the purpose of
facilitating review.

Please perform deep regression anaylysis of this series after applying all the patches.

Andrew, do you have any comments on this V10 patch series?

Thanks,
Zhi Li

> >    - eswin,hsp-sp-csr
> >  
> >  unevaluatedProperties: false
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260707064033.1265-1-lizhi2@eswincomputing.com?part=1