public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vivian Wang <wangruikang@iscas.ac.cn>,
	Yixun Lan <dlan@gentoo.org>, Guodong Xu <guodong@riscstar.com>,
	Ze Huang <huangze@whut.edu.cn>,
	spacemit@lists.linux.dev
Cc: Vivian Wang <uwu@dram.page>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] riscv: dts: spacemit: Add DMA translation buses for K1
Date: Tue, 17 Jun 2025 08:21:51 +0200	[thread overview]
Message-ID: <74e3c488-4457-4026-9597-806b98fd4e11@kernel.org> (raw)
In-Reply-To: <20250617-k1-dma-buses-rfc-wip-v1-1-c8ec192fbf58@iscas.ac.cn>

On 17/06/2025 07:21, Vivian Wang wrote:
> The SpacemiT K1 has various static translations of DMA accesses. Add
> these as simple-bus nodes. Devices actually using these translation will
> be added in later patches.
> 
> The bus names are assigned according to consensus with SpacemiT [1].


Read the feedback there:

"So, as you are submitting the first node(s) under network_bus: bus@5, you
should have this added into your patchset, instead of sending out with
none."

Plus simple bus within MMIO node needs unit address. IOW, don't mix MMIO
with non-MMIO. I also suspect this does not pass checks, so the tools
can do our review...

Best regards,
Krzysztof

  reply	other threads:[~2025-06-17  6:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17  5:21 [PATCH RFC] riscv: dts: spacemit: Add DMA translation buses for K1 Vivian Wang
2025-06-17  6:21 ` Krzysztof Kozlowski [this message]
2025-06-17  8:48   ` Vivian Wang
2025-06-17  9:35     ` Krzysztof Kozlowski
2025-06-17 10:10       ` Vivian Wang
2025-06-19 15:11 ` Alex Elder
2025-06-19 15:42   ` Vivian Wang
2025-06-20 10:56     ` Yixun Lan
2025-06-20 14:10       ` Guodong Xu
2025-06-20 14:57         ` Yixun Lan
2025-06-23  7:01           ` Yixun Lan
2025-06-23  9:32             ` Guodong Xu
2025-06-23  9:42               ` Vivian Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74e3c488-4457-4026-9597-806b98fd4e11@kernel.org \
    --to=krzk@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=guodong@riscstar.com \
    --cc=huangze@whut.edu.cn \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=uwu@dram.page \
    --cc=wangruikang@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox